Fix typo in ClientCertificateCredentialOptions (Azure#15901)

* Fix typo in ClientCertificateCredentialOptions * Update api of Azure.Identity Co-authored-by: Noam Hershtig <nohersht@microsoft.com>
annelo-msft · Feb 17, 2021 · 9211d77 · 9211d77
1 parent 8415543
commit 9211d77
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 5 deletions.
diff --git a/sdk/identity/Azure.Identity/api/Azure.Identity.netstandard2.0.cs b/sdk/identity/Azure.Identity/api/Azure.Identity.netstandard2.0.cs
@@ -68,7 +68,7 @@ public partial class ClientCertificateCredentialOptions : Azure.Identity.TokenCr
         public ClientCertificateCredentialOptions() { }
         public bool AllowUnencryptedCache { get { throw null; } set { } }
         public bool EnablePersistentCache { get { throw null; } set { } }
-        public bool IncludeX5CCliamHeader { get { throw null; } set { } }
+        public bool IncludeX5CClaimHeader { get { throw null; } set { } }
     }
     public partial class ClientSecretCredential : Azure.Core.TokenCredential
     {

diff --git a/sdk/identity/Azure.Identity/src/ClientCertificateCredential.cs b/sdk/identity/Azure.Identity/src/ClientCertificateCredential.cs
@@ -133,7 +133,7 @@ internal ClientCertificateCredential(string tenantId, string clientId, IX509Cert
 
             _pipeline = pipeline ?? CredentialPipeline.GetInstance(options);
 
-            _client = client ?? new MsalConfidentialClient(_pipeline, tenantId, clientId, certificateProvider, (options as ClientCertificateCredentialOptions)?.IncludeX5CCliamHeader ?? false, options as ITokenCacheOptions);
+            _client = client ?? new MsalConfidentialClient(_pipeline, tenantId, clientId, certificateProvider, (options as ClientCertificateCredentialOptions)?.IncludeX5CClaimHeader ?? false, options as ITokenCacheOptions);
         }
 
         /// <summary>

diff --git a/sdk/identity/Azure.Identity/src/ClientCertificateCredentialOptions.cs b/sdk/identity/Azure.Identity/src/ClientCertificateCredentialOptions.cs
@@ -22,6 +22,6 @@ public class ClientCertificateCredentialOptions : TokenCredentialOptions, IToken
         /// <summary>
         /// Will include x5c header to enable subject name / issuer based authentication for the <see cref="ClientCertificateCredential"/>.
         /// </summary>
-        public bool IncludeX5CCliamHeader { get; set; }
+        public bool IncludeX5CClaimHeader { get; set; }
     }
 }
diff --git a/sdk/identity/Azure.Identity/tests/ClientCertificateCredentialLiveTests.cs b/sdk/identity/Azure.Identity/tests/ClientCertificateCredentialLiveTests.cs
@@ -102,13 +102,13 @@ public async Task FromX509Certificate2()
         }
 
         [Test]
-        public async Task IncludeX5CCliamHeader()
+        public async Task IncludeX5CClaimHeader()
         {
             var tenantId = TestEnvironment.ServicePrincipalTenantId;
             var clientId = TestEnvironment.ServicePrincipalClientId;
             var certPath = TestEnvironment.ServicePrincipalSniCertificatePath;
 
-            var options = InstrumentClientOptions(new ClientCertificateCredentialOptions { IncludeX5CCliamHeader = true });
+            var options = InstrumentClientOptions(new ClientCertificateCredentialOptions { IncludeX5CClaimHeader = true });
 
             var credential = new ClientCertificateCredential(tenantId, clientId, certPath, options);
 

diff --git a/...ntialLiveTests/IncludeX5CCliamHeader.json → ...ntialLiveTests/IncludeX5CClaimHeader.json b/...ntialLiveTests/IncludeX5CCliamHeader.json → ...ntialLiveTests/IncludeX5CClaimHeader.json
diff --git a/...LiveTests/IncludeX5CCliamHeaderAsync.json → ...LiveTests/IncludeX5CClaimHeaderAsync.json b/...LiveTests/IncludeX5CCliamHeaderAsync.json → ...LiveTests/IncludeX5CClaimHeaderAsync.json