Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the preview language version #16098

Merged
2 commits merged into from
Oct 19, 2020

Conversation

pakrym
Copy link
Contributor

@pakrym pakrym commented Oct 19, 2020

Fixes: #16084

@ghost
Copy link

ghost commented Oct 19, 2020

Hello @pakrym!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@@ -70,7 +70,7 @@ public async Task GetCursor()
It.IsAny<long>(),
It.IsAny<long>(),
It.IsAny<CancellationToken>()))
.Returns((bool _, string path, long _, long _, CancellationToken _) => Task.FromResult(chunks[path].Object));
.Returns((bool _, string path, long __, long ___, CancellationToken ____) => Task.FromResult(chunks[path].Object));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did it not compile? I recall having same problem. Bumping installed .NET SDK solved that for me.
Btw. The multiple _ look funny.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature (lambda parameter discard) is a preview compiler feature.

@ghost ghost merged commit a53bdce into Azure:master Oct 19, 2020
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

annelo-msft pushed a commit to annelo-msft/azure-sdk-for-net that referenced this pull request Feb 17, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LangVersion is set to preview for Track 2 libraries
3 participants