Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the preview language version #16098

Merged
2 commits merged into from
Oct 19, 2020
Merged

Remove the preview language version #16098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7d597d
Remove the preview language version
pakrym Oct 19, 2020
0d9e735
Remove new features
pakrym Oct 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion eng/Directory.Build.Data.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,6 @@
<DelaySign>false</DelaySign>
<PublicSign>false</PublicSign>
<ImportDefaultReferences>false</ImportDefaultReferences>
<LangVersion>preview</LangVersion>
<DocumentationFile>$(IntermediateOutputPath)$(TargetFramework)\$(MSBuildProjectName).xml</DocumentationFile>

<!-- The set of tags that should be added to the packages -->
Expand Down
1 change: 0 additions & 1 deletion samples/linecounter/LineCounter.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk.Web">
<PropertyGroup>
<TargetFramework>netcoreapp3.0</TargetFramework>
<LangVersion>preview</LangVersion>
<UserSecretsId>67ca5d37-051b-4ab1-b013-c74a2d4edb76</UserSecretsId>
</PropertyGroup>
<ItemGroup>
Expand Down
1 change: 0 additions & 1 deletion sdk/eventhub/Microsoft.Azure.EventHubs/tests/Microsoft.Azure.EventHubs.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
<GenerateRuntimeConfigurationFiles>true</GenerateRuntimeConfigurationFiles>
<VersionPrefix>2.2.0</VersionPrefix>
<TargetFrameworks>$(RequiredTargetFrameworks)</TargetFrameworks>
<LangVersion>preview</LangVersion>
<IsClientLibrary>true</IsClientLibrary>
</PropertyGroup>

Expand Down
2 changes: 1 addition & 1 deletion sdk/identity/Azure.Identity/tests/SharedTokenCacheCredentialTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public async Task VerifyAuthenticationRecordOption()
var mockMsalClient = new MockMsalPublicClient
{
Accounts = new List<IAccount> { new MockAccount("nonexpecteduser@mockdomain.com") },
ExtendedSilentAuthFactory = (_, account, _, _) =>
ExtendedSilentAuthFactory = (_, account, __, ___) =>
{
Assert.AreEqual(expectedUsername, account.Username);

Expand Down
10 changes: 5 additions & 5 deletions sdk/storage/Azure.Storage.Blobs.ChangeFeed/tests/ShardTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ public async Task GetCursor()
It.IsAny<long>(),
It.IsAny<long>(),
It.IsAny<CancellationToken>()))
.Returns((bool _, string path, long _, long _, CancellationToken _) => Task.FromResult(chunks[path].Object));
.Returns((bool _, string path, long __, long ___, CancellationToken ____) => Task.FromResult(chunks[path].Object));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did it not compile? I recall having same problem. Bumping installed .NET SDK solved that for me.
Btw. The multiple _ look funny.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature (lambda parameter discard) is a preview compiler feature.


ShardFactory shardFactory = new ShardFactory(
containerClient.Object,
Expand Down Expand Up @@ -172,7 +172,7 @@ public async Task HasNext_False()
It.IsAny<long>(),
It.IsAny<long>(),
It.IsAny<CancellationToken>()))
.Returns((bool _, string path, long _, long _, CancellationToken _) => Task.FromResult(chunks[path].Object));
.Returns((bool _, string path, long __, long ___, CancellationToken ____) => Task.FromResult(chunks[path].Object));

chunks["chunk5"].Setup(r => r.HasNext()).Returns(false);

Expand Down Expand Up @@ -271,7 +271,7 @@ public async Task HasNext_ChunksLeft()
It.IsAny<long>(),
It.IsAny<long>(),
It.IsAny<CancellationToken>()))
.Returns((bool _, string path, long _, long _, CancellationToken _) => Task.FromResult(chunks[path].Object));
.Returns((bool _, string path, long __, long ___, CancellationToken ____) => Task.FromResult(chunks[path].Object));

ShardFactory shardFactory = new ShardFactory(
containerClient.Object,
Expand Down Expand Up @@ -366,7 +366,7 @@ public async Task HasNext_CurrentChunkHasNext()
It.IsAny<long>(),
It.IsAny<long>(),
It.IsAny<CancellationToken>()))
.Returns((bool _, string path, long _, long _, CancellationToken _) => Task.FromResult(chunks[path].Object));
.Returns((bool _, string path, long __, long ___, CancellationToken ____) => Task.FromResult(chunks[path].Object));

chunks["chunk5"].Setup(r => r.HasNext()).Returns(true);

Expand Down Expand Up @@ -482,7 +482,7 @@ public async Task Next()
It.IsAny<long>(),
It.IsAny<long>(),
It.IsAny<CancellationToken>()))
.Returns((bool _, string path, long _, long _, CancellationToken _) => Task.FromResult(chunks[path].Object));
.Returns((bool _, string path, long __, long ___, CancellationToken ____) => Task.FromResult(chunks[path].Object));

chunks["chunk2"].SetupSequence(r => r.HasNext())
.Returns(true)
Expand Down