Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added PlayAudio Api on ConversationClient (Out-Call Scenario) #21430

Merged
merged 6 commits into from
May 28, 2021
Merged

Added PlayAudio Api on ConversationClient (Out-Call Scenario) #21430

merged 6 commits into from
May 28, 2021

Conversation

Paresh-Arvind-Patil
Copy link
Member

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

  • If the check fails at the Verify Code Generation step, please ensure:

    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

    Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:

      `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@ghost ghost added the Communication label May 27, 2021
ajaych-ms
ajaych-ms approved these changes May 28, 2021
View reviewed changes
Copy link
Member

@ajaych-ms ajaych-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Paresh-Arvind-Patil Paresh-Arvind-Patil merged commit ba8e7a9 into feature/communication-ServerCalling-preview1 May 28, 2021
@Paresh-Arvind-Patil Paresh-Arvind-Patil deleted the dev/papati/adding_playAudio_api_for_out-call branch May 28, 2021 22:18
minnieliu pushed a commit that referenced this pull request Jun 8, 2021
@zihzhan-msft @navali-msft @Paresh-Arvind-Patil
Feature/communication server calling preview1 (#21017)
b227152 
* Onboard ServerCalling feature project.

* Onboard Server Calling Test project.

* Onboard Server Calling Test project.

* New apis and models for different operations.

* Update Recorded Test files.

* Naming changes and fix build.

* Resolve comments.

* Removed operationContext from Recording apis (#21309)

Co-authored-by: Paresh Arvind Patil <papati@microsoft.com>

* Onboard ServerCalling feature project.

* Onboard Server Calling Test project.

* New apis and models for different operations.

* Onboard Server Calling Test project.

* Update Recorded Test files.

* Naming changes and fix build.

* Resolve comments.

* Address comments.

* Fix build

* Fixed the typo CallRecordingStateChangeEvent EventType (#21434)

Co-authored-by: Paresh Arvind Patil <papati@microsoft.com>

* remove remaining context & request (#21437)

* Update swagger.

* Update swagger link to a perm url.

* Added PlayAudio Api on ConversationClient (Out-Call Scenario) (#21430)

* Added playAudio and cancelMedia api for out-call

* Added PlayAudio api on ConversationClient

* Updated the PlayAudio url description

* Updated as per  PR feedback

* Re-build the swagger updating the auto-genrated files

Co-authored-by: Paresh Arvind Patil <papati@microsoft.com>

* Udpate Sdk based on new Swagger.

* Update API version.

* Address comments.

* Update apis with new swagger, address CallState enum.

* Update Live test to use Instrumented Client.

* Fix broken link

* Fix broken link

* Fix broken link

* Adding AudioFileId and CallbackUri parameter in PlayAudio Api (Out-Call) (#21503)

* Adding AudioFileId and callbackuri for PlayAudio Api out-call

* minor fixes

* Made Param optional

Co-authored-by: Paresh Arvind Patil <papati@microsoft.com>

* Mark failed live test as Ignore to unblock build.

* Added events in the swagger, added model for creating serializer, com… (#21535)

* Added events in the swagger, added model for creating serializer, comments updated, invite participant change to add participant

* comments fix.

* fixes based on comments

* Set operation context as optional and last parameter

* NIT fix

* NIT fix (#21540)

* Fix build Analyze.

* Fix build Analyze.

* Minor fix for ConvClient joinCall api.

* Minor fix for ConvClient joinCall api. (#21558)

* Address comments.

* Added unit test for recording apis (#21578)

Co-authored-by: Paresh Arvind Patil <papati@microsoft.com>

* Address comments.

* Specify parameters in RestApiCall.

* Update Namespace to CallingServer.

* Update links in md files.

* Update links in md files.

* Update CallClient.cs

* Update ConversationClient.cs

* Feature/zihzhan livetesting (#21677)

* Enable living testing.

* Test Playback.

* Add playaudio test record.

* Add createcall test record.

* Add delete call record.

* Add hangup call test record.

* Add cancelAllMediaOperations call test record.

* Enable living tests.

* Address comments.

Co-authored-by: Naveed Ali <navali@microsoft.com>
Co-authored-by: Paresh Arvind Patil <patilaparesh@gmail.com>
Co-authored-by: Paresh Arvind Patil <papati@microsoft.com>
Co-authored-by: navali-msft <66667092+navali-msft@users.noreply.github.com>
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this pull request Feb 1, 2023
@komo23x @namanag16
@ZhidaLiu @libc16
CodeGen from PR 21761 in Azure/azure-rest-api-specs
bce19f6 
Machinelearningservices microsoft.machine learning services 2022 12 01 preview (Azure#21761)

* Adds base for updating Microsoft.MachineLearningServices from version preview/2022-10-01-preview to version 2022-12-01-preview

* Updates readme

* Updates API version in new specs and examples

* Add Dec API Registries Swagger (Azure#21419)

* add december registries swagger + examples

* add status code 202 in examples

* fix 202 examples

* fixes

* fixes

* fix

* add 202 back in for put/patch

Co-authored-by: Komal Yadav <komalyadav@microsoft.com>

* remove location (Azure#21430)

Co-authored-by: Komal Yadav <komalyadav@microsoft.com>

* remove readonly flag on schedules property for CI (Azure#21653)

Co-authored-by: Naman Agarwal <naagarw@microsoft.com>

* add missing workspace properties (Azure#21725)

* December preview updating mfe.json specs (Azure#21510)

* December preview updating mfe.json specs

* MFE Dec 2022 Preview API - Adding logbase

* MFE 2022-12-01-preview swagger spec model validation fix

* MFE 2022-12-01-preview swagger spec model validation fix, add missing location

* MFE 2022-12-01-preview swagger spec model validation - typo fix

* MFE 2022-12-01-preview swagger spec model validation - fix api version in automljob example

* MFE 2022-12-01-preview swagger spec model validation - fix for multiselectenabled error

* MFE 2022-12-01-preview swagger spec model validation - fix for multiselectenabled error

* Fix  for 1006 - RemovedDefinition (RecurrenceTrigger,CronTrigger) (Azure#21822)

* fix ReadonlyPropertyChanged of MLC (Azure#21814)

Co-authored-by: Bingchen Li <bingchenli@microsoft.com>

* fixed custom-words conflict (Azure#21829)

* fix custom-words conflict merge (Azure#21830)

* example fix (INVALID_REQUEST_PARAMETER) (Azure#21832)

Co-authored-by: Ivaliy Ivanov <ivaliyivanov@Ivaliys-MacBook-Air.local>

* example fix, use correct api preview version  - (INVALID_REQUEST_PARAMETER) (Azure#21833)

Co-authored-by: Ivaliy Ivanov <ivaliyivanov@Ivaliys-MacBook-Air.local>

* Revert breaking change for MLC swagger 2022-12-01-preview (Azure#21885)

Co-authored-by: Bingchen Li <bingchenli@microsoft.com>

* Revert Connection Category back to enum. (Azure#21939)

* revert provisioning state change (Azure#21940)

* remove body (Azure#21978)

Co-authored-by: Komal Yadav <komalyadav@microsoft.com>

* Addressed comments, added x-ms-long-running-operation to a patch call (Azure#22005)

* Addressed comments, added x-ms-long-running-operation to a patch call

* fix examples for patch - remove body

* fixed formatting

* Ivalbert fix patch2 (Azure#22006)

* Addressed comments, added x-ms-long-running-operation to a patch call

* fix examples for patch - remove body

* fixed formatting

* fixed formatting

* Updated custom words (Azure#22262)

* Fixed prettier errors (Azure#22237)

* fixed examples for LRO_RESPONSE_HEADER check (Azure#22293)

* fixed examples for LRO_RESPONSE_HEADER check (Azure#22294)

* Example fix - OBJECT_MISSING_REQUIRED_PROPERTY - Missing required property: triggerType (Azure#22317)

---------

Co-authored-by: Komal Yadav <23komal.yadav23@gmail.com>
Co-authored-by: Komal Yadav <komalyadav@microsoft.com>
Co-authored-by: Naman Agarwal <namanag16@gmail.com>
Co-authored-by: Naman Agarwal <naagarw@microsoft.com>
Co-authored-by: ZhidaLiu <zhili@microsoft.com>
Co-authored-by: libc16 <88697960+libc16@users.noreply.github.com>
Co-authored-by: Bingchen Li <bingchenli@microsoft.com>
Co-authored-by: Ivaliy Ivanov <ivaliyivanov@Ivaliys-MacBook-Air.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrwhit chrwhit chrwhit left review comments

@bharat-kalyan-namburi bharat-kalyan-namburi bharat-kalyan-namburi approved these changes

@ajaych-ms ajaych-ms ajaych-ms approved these changes

@navali-msft navali-msft Awaiting requested review from navali-msft

@zihzhan-msft zihzhan-msft Awaiting requested review from zihzhan-msft

@arifsaikat-microsoft arifsaikat-microsoft Awaiting requested review from arifsaikat-microsoft

Assignees
No one assigned
Labels
Communication
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Paresh-Arvind-Patil @chrwhit @ajaych-ms @bharat-kalyan-namburi