Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated models to handle nullable and make events properties readonly #21978

Conversation

navali-msft
Copy link
Member

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

  • If the check fails at the Verify Code Generation step, please ensure:

    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

    Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:

      `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`
    

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

amnguye and others added 30 commits June 4, 2021 10:59
…21550)

* Fixed regression in BlobProperties where IsLatestVersion was not setting the value

* Rerecorded one more test

* Update BlobProperties to set properties by using internal constructor

* Updated tests to remove unused BlobProperties

* Make BlobProperties properties internal
* Move WebPubSub to LLC + extensions

* Small changes

* Moved to LLC + extensions

* changes

* Finished moving to generated surface area

* updated API file

* PR review feedback incorporated

* regenerated APIs

* fixed a bug
* Update README.md

adding dependency injection section

* Update README.md

Proposing changes based on the chat with @KrzysztofCwalina and @davidfowl.

The changes are around simplifying the samples and using the configuration instead of the hard coded connection string.

* Update README.md

Change the method named used and show the configuration snippet as well.

* Update sdk/servicebus/Azure.Messaging.ServiceBus/README.md

Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>

* Update sdk/servicebus/Azure.Messaging.ServiceBus/README.md

Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>

* minor edits

Co-authored-by: Alex Ghiondea <AlexGhiondea@users.noreply.github.com>
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
The focus of these changes is to clamp the calculation for the natural
delay (before it is clamped to the `MaxDelay`) to prevent overflowing
the `TimeSpan` type.
* add AuthenticationScope client option

* formatting

* nit

* Update sdk/containerregistry/Azure.Containers.ContainerRegistry/src/ContainerRegistryClientOptions.cs

Co-authored-by: Jeremy Meng <yumeng@microsoft.com>

* add negative test for AuthenticationScope

* add directions to the README

* nits

* fix auth scope setting in recorded tests

* remove lines

* removing negative test since we don't record calls from identity

* update API

* updates to README

* nit

Co-authored-by: Jeremy Meng <yumeng@microsoft.com>
This reverts commit b3f9203
as test are still flaky. Need to ping service
Update AutoRest C# version to 3.0.0-beta.20210603.1
The focus of these changes is to expose an additional set of connection
options for configuring the transport.  Included are options for

- A custom send buffer size
- A custom receive buffer size
- A delegate to participate in SSL certificate validation
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
* API feedback changes
* Update ShareLink sample

Fixes #21543

* Include auto-gen sources
* this gets allocations in line. but isn't great.

* temporarily disable the probe.

* try Azure/autorest#4152

* Revert "temporarily disable the probe."

This reverts commit f5d1587.

* fix empty path.

* mocking.

* fix 403.

* I really dislike url-encoding...

* private protected. nice.

* fix tests.

* datalake.

* fix that.

* shares.

* queues

* batch.

* this works.

* this works. too.
* Support cloud event handshake

* Fix CloudEvent handshake

* Update README

* Fix

* Update sdk/eventgrid/Microsoft.Azure.WebJobs.Extensions.EventGrid/src/TriggerBinding/HttpRequestProcessor.cs

Co-authored-by: Jesse Squire <jesse.squire@gmail.com>

Co-authored-by: Jesse Squire <jesse.squire@gmail.com>
* Batch receive fixes

* Use AwaitWithCancellation

* volatile

* Remove unnecessary catch

* Fix tests

* Fix flaky tests

* Fix test
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this pull request Feb 1, 2023
Machinelearningservices microsoft.machine learning services 2022 12 01 preview (Azure#21761)

* Adds base for updating Microsoft.MachineLearningServices from version preview/2022-10-01-preview to version 2022-12-01-preview

* Updates readme

* Updates API version in new specs and examples

* Add Dec API Registries Swagger (Azure#21419)

* add december registries swagger + examples

* add status code 202 in examples

* fix 202 examples

* fixes

* fixes

* fix

* add 202 back in for put/patch

Co-authored-by: Komal Yadav <komalyadav@microsoft.com>

* remove location (Azure#21430)

Co-authored-by: Komal Yadav <komalyadav@microsoft.com>

* remove readonly flag on schedules property for CI (Azure#21653)

Co-authored-by: Naman Agarwal <naagarw@microsoft.com>

* add missing workspace properties (Azure#21725)

* December preview updating mfe.json specs (Azure#21510)

* December preview updating mfe.json specs

* MFE Dec 2022 Preview API - Adding logbase

* MFE 2022-12-01-preview swagger spec model validation fix

* MFE 2022-12-01-preview swagger spec model validation fix, add missing location

* MFE 2022-12-01-preview swagger spec model validation - typo fix

* MFE 2022-12-01-preview swagger spec model validation - fix api version in automljob example

* MFE 2022-12-01-preview swagger spec model validation - fix for multiselectenabled error

* MFE 2022-12-01-preview swagger spec model validation - fix for multiselectenabled error

* Fix  for 1006 - RemovedDefinition (RecurrenceTrigger,CronTrigger) (Azure#21822)

* fix ReadonlyPropertyChanged of MLC (Azure#21814)

Co-authored-by: Bingchen Li <bingchenli@microsoft.com>

* fixed custom-words conflict (Azure#21829)

* fix custom-words conflict merge (Azure#21830)

* example fix (INVALID_REQUEST_PARAMETER) (Azure#21832)

Co-authored-by: Ivaliy Ivanov <ivaliyivanov@Ivaliys-MacBook-Air.local>

* example fix, use correct api preview version  - (INVALID_REQUEST_PARAMETER) (Azure#21833)

Co-authored-by: Ivaliy Ivanov <ivaliyivanov@Ivaliys-MacBook-Air.local>

* Revert breaking change for MLC swagger 2022-12-01-preview (Azure#21885)

Co-authored-by: Bingchen Li <bingchenli@microsoft.com>

* Revert Connection Category back to enum. (Azure#21939)

* revert provisioning state change (Azure#21940)

* remove body (Azure#21978)

Co-authored-by: Komal Yadav <komalyadav@microsoft.com>

* Addressed comments, added x-ms-long-running-operation to a patch call (Azure#22005)

* Addressed comments, added x-ms-long-running-operation to a patch call

* fix examples for patch - remove body

* fixed formatting

* Ivalbert fix patch2 (Azure#22006)

* Addressed comments, added x-ms-long-running-operation to a patch call

* fix examples for patch - remove body

* fixed formatting

* fixed formatting

* Updated custom words (Azure#22262)

* Fixed prettier errors (Azure#22237)

* fixed examples for LRO_RESPONSE_HEADER check (Azure#22293)

* fixed examples for LRO_RESPONSE_HEADER check (Azure#22294)

* Example fix - OBJECT_MISSING_REQUIRED_PROPERTY - Missing required property: triggerType (Azure#22317)

---------

Co-authored-by: Komal Yadav <23komal.yadav23@gmail.com>
Co-authored-by: Komal Yadav <komalyadav@microsoft.com>
Co-authored-by: Naman Agarwal <namanag16@gmail.com>
Co-authored-by: Naman Agarwal <naagarw@microsoft.com>
Co-authored-by: ZhidaLiu <zhili@microsoft.com>
Co-authored-by: libc16 <88697960+libc16@users.noreply.github.com>
Co-authored-by: Bingchen Li <bingchenli@microsoft.com>
Co-authored-by: Ivaliy Ivanov <ivaliyivanov@Ivaliys-MacBook-Air.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.