[MetricsAdvisor] Added missing DatasourceCredential types #21587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinelski
added
Client
kinelski
commented
Jun 4, 2021
...dvisor/Azure.AI.MetricsAdvisor/src/Models/Credential/ServicePrincipalDatasourceCredential.cs
Show resolved
Hide resolved
kinelski
commented
Jun 4, 2021
sdk/metricsadvisor/Azure.AI.MetricsAdvisor/tests/Models/DatasourceCredentialsTests.cs
Show resolved
Hide resolved
kinelski
requested review from
maririos
and removed request for
tg-msft and
KrzysztofCwalina
maririos
approved these changes
Jun 4, 2021
| @@ -768,6 +768,11 @@ public abstract partial class DataFeedSource | |||
| public static bool operator !=(Azure.AI.MetricsAdvisor.Models.DataFeedStatus left, Azure.AI.MetricsAdvisor.Models.DataFeedStatus right) { throw null; } | |||
| public override string ToString() { throw null; } | |||
| } | |||
| public partial class DataLakeGen2SharedKeyDatasourceCredential : Azure.AI.MetricsAdvisor.Models.DatasourceCredential | |||
There was a problem hiding this comment.
I imagine there is a reason why the name needs to be super specific?
There was a problem hiding this comment.
Data Lake Gen 2 is the name of the service to which this credential is used. Shared Key specifies the type of credential. We will need to create other datasource credentials for different types of authentication.
...r/Azure.AI.MetricsAdvisor/src/Models/Credential/DataLakeGen2SharedKeyDatasourceCredential.cs
Outdated
Show resolved
Hide resolved
...r/Azure.AI.MetricsAdvisor/src/Models/Credential/DataLakeGen2SharedKeyDatasourceCredential.cs
Outdated
Show resolved
Hide resolved
…al/DataLakeGen2SharedKeyDatasourceCredential.cs Co-authored-by: Mariana Rios Flores <mariari@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #18609.
Adding the three remaining
DatasourceCredentialtypes. It's pretty much the same thing as theServicePrincipalDatasourceCredentialwe added in a previous PR.