Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MetricsAdvisor] Added missing DatasourceCredential types #21587

Merged
merged 13 commits into from
Jun 4, 2021
1 change: 1 addition & 0 deletions sdk/metricsadvisor/Azure.AI.MetricsAdvisor/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## 1.0.0-beta.4 (Unreleased)

### New Features
- Added `DatasourceCredential` CRUD operations to the `MetricsAdvisorAdministrationClient`. This API provides new ways of authenticating to a `DataFeedSource`.
- Added properties `Value` and `ExpectedValue` to `DataPointAnomaly` to provide more information about the anomalous data point.
- Added properties `ValueOfRootNode` and `ExpectedValueOfRootNode` to `AnomalyIncident` to provide more information about the anomalous data point at the root node of the indicent.
- Response headers that were marked as `REDACTED` in error messages and logs are now exposed by default.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -769,6 +769,11 @@ internal DataFeedSource() { }
public static bool operator !=(Azure.AI.MetricsAdvisor.Models.DataFeedStatus left, Azure.AI.MetricsAdvisor.Models.DataFeedStatus right) { throw null; }
public override string ToString() { throw null; }
}
public partial class DataLakeGen2SharedKeyDatasourceCredential : Azure.AI.MetricsAdvisor.Models.DatasourceCredential
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine there is a reason why the name needs to be super specific?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data Lake Gen 2 is the name of the service to which this credential is used. Shared Key specifies the type of credential. We will need to create other datasource credentials for different types of authentication.

{
public DataLakeGen2SharedKeyDatasourceCredential(string name, string accountKey) { }
public void UpdateAccountKey(string accountKey) { }
}
public partial class DataPointAnomaly
{
internal DataPointAnomaly() { }
Expand Down Expand Up @@ -1118,6 +1123,16 @@ public ServicePrincipalDatasourceCredential(string name, string clientId, string
public string TenantId { get { throw null; } set { } }
public void UpdateClientSecret(string clientSecret) { }
}
public partial class ServicePrincipalInKeyVaultDatasourceCredential : Azure.AI.MetricsAdvisor.Models.DatasourceCredential
{
public ServicePrincipalInKeyVaultDatasourceCredential(string name, System.Uri endpoint, string keyVaultClientId, string keyVaultClientSecret, string tenantId, string secretNameForClientId, string secretNameForClientSecret) { }
public System.Uri Endpoint { get { throw null; } set { } }
public string KeyVaultClientId { get { throw null; } set { } }
public string SecretNameForClientId { get { throw null; } set { } }
public string SecretNameForClientSecret { get { throw null; } set { } }
public string TenantId { get { throw null; } set { } }
public void UpdateKeyVaultClientSecret(string keyVaultClientSecret) { }
}
public partial class SeverityCondition
{
public SeverityCondition(Azure.AI.MetricsAdvisor.Models.AnomalySeverity minimumAlertSeverity, Azure.AI.MetricsAdvisor.Models.AnomalySeverity maximumAlertSeverity) { }
Expand Down Expand Up @@ -1149,6 +1164,11 @@ public SmartDetectionCondition(double sensitivity, Azure.AI.MetricsAdvisor.Model
public static bool operator !=(Azure.AI.MetricsAdvisor.Models.SnoozeScope left, Azure.AI.MetricsAdvisor.Models.SnoozeScope right) { throw null; }
public override string ToString() { throw null; }
}
public partial class SqlConnectionStringDatasourceCredential : Azure.AI.MetricsAdvisor.Models.DatasourceCredential
{
public SqlConnectionStringDatasourceCredential(string name, string connectionString) { }
public void UpdateConnectionString(string connectionString) { }
}
public partial class SqlServerDataFeedSource : Azure.AI.MetricsAdvisor.Models.DataFeedSource
{
public SqlServerDataFeedSource(string connectionString, string query) { }
Expand Down

This file was deleted.

This file was deleted.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

This file was deleted.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading