Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use service.projects to ignore KV track 1 tests #21756

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Use service.projects to ignore KV track 1 tests #21756

merged 1 commit into from
Jun 10, 2021

Conversation

heaths
Copy link
Member

@heaths heaths commented Jun 9, 2021

Fixes #13029

@heaths heaths requested a review from schaabs as a code owner June 9, 2021 22:44
@ghost ghost added the KeyVault label Jun 9, 2021
@heaths heaths requested review from christothes and pakrym June 9, 2021 22:45
@pakrym
Copy link
Contributor

pakrym commented Jun 10, 2021

Do we want to move them to a separate CI run like we did in EH?

cc @jsquire

@heaths
Copy link
Member Author

heaths commented Jun 10, 2021

For CIs as in "net - keyvault - ci", or CIs in general e.g. include "net - keyvault - test"? These still run in the CIs and I think that's fine - they're fast enough - but for live tests it's good to consider. That said, they are deprecated. I'll start a discussion offline.

@heaths heaths merged commit 101b181 into Azure:master Jun 10, 2021
@heaths heaths deleted the issue13029 branch June 10, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pakrym pakrym pakrym approved these changes

@schaabs schaabs Awaiting requested review from schaabs

@christothes christothes Awaiting requested review from christothes

Assignees
No one assigned
Labels
KeyVault
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate track 1 live test mitigation to new standard
2 participants
@heaths @pakrym