Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use service.projects to ignore KV track 1 tests #21756

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Use service.projects to ignore KV track 1 tests #21756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions ...icrosoft.Azure.KeyVault.Extensions/tests/Microsoft.Azure.KeyVault.Extensions.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@
<Description>Microsoft Azure Key Vault Extensions tests</Description>
<VersionPrefix>1.0.0</VersionPrefix>
<TargetFrameworks>$(RequiredTargetFrameworks)</TargetFrameworks>
<DefineConstants Condition="'$(AZURE_KEYVAULT_TEST_MODE)'=='Live'">
$(DefineConstants);
AZURE_KEYVAULT_TEST_MODE_LIVE;
</DefineConstants>
</PropertyGroup>
<ItemGroup>
<None Update="appsettings.json">
Expand Down
6 changes: 0 additions & 6 deletions sdk/keyvault/Microsoft.Azure.KeyVault.Extensions/tests/Tests/KeyVaultKeyResolverTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@
using Microsoft.Rest.ClientRuntime.Azure.TestFramework;
using Xunit;

// Avoid compiling the test class. Disabling just the test methods still causes the fixture to instantiate and dispose, which still breaks live tests.
// See https://github.com/Azure/azure-sdk-for-net/issues/8420 for status and more information about why these tests are disabled.
#if !AZURE_KEYVAULT_TEST_MODE_LIVE

namespace Microsoft.Azure.KeyVault.Extensions.Tests
{
/// <summary>
Expand Down Expand Up @@ -223,5 +219,3 @@ private void VerifyResolver(KeyVaultClient client, string vault, string baseIden
}
}
}

#endif
6 changes: 0 additions & 6 deletions sdk/keyvault/Microsoft.Azure.KeyVault/tests/KeyVaultOperationsTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,6 @@
using Microsoft.Rest.Serialization;
using Xunit;

// Avoid compiling the test class. Disabling just the test methods still causes the fixture to instantiate and dispose, which still breaks live tests.
// See https://github.com/Azure/azure-sdk-for-net/issues/8420 for status and more information about why these tests are disabled.
#if !AZURE_KEYVAULT_TEST_MODE_LIVE

namespace Microsoft.Azure.KeyVault.Tests
{
public class Operations : IClassFixture<KeyVaultTestFixture>
Expand Down Expand Up @@ -4298,5 +4294,3 @@ private static Uri GetSasDefinitionTemplateUri(string blobUri, string startTime,
#endregion
}
}

#endif
4 changes: 0 additions & 4 deletions sdk/keyvault/Microsoft.Azure.KeyVault/tests/Microsoft.Azure.KeyVault.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,6 @@
<PropertyGroup>
<Description>Microsoft.Azure.KeyVault.Tests Class Library</Description>
<TargetFrameworks>$(RequiredTargetFrameworks)</TargetFrameworks>
<DefineConstants Condition="'$(AZURE_KEYVAULT_TEST_MODE)'=='Live'">
$(DefineConstants);
AZURE_KEYVAULT_TEST_MODE_LIVE;
</DefineConstants>
</PropertyGroup>
<ItemGroup>
<None Update="appsettings.json">
Expand Down
6 changes: 6 additions & 0 deletions sdk/keyvault/service.projects
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<Project>
<ItemGroup>
<!-- Remove data plane tests from nightly live runs: https://github.com/Azure/azure-sdk-for-net/issues/13029 -->
<ProjectReference Remove="$(MSBuildThisFileDirectory)Microsoft.Azure.*\**\*.csproj" Condition="'$(AZURE_KEYVAULT_TEST_MODE)' == 'Live'" />
</ItemGroup>
</Project>