-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade open telemetry package dependencies for Azure Monitor OpenTelemetry Exporter #22017
Upgrade open telemetry package dependencies for Azure Monitor OpenTelemetry Exporter #22017
Conversation
vishweshbankwar
commented
Jun 21, 2021
•
edited
Loading
edited
- Upgrading OpenTelemetry to use 1.1.0-beta4
- Updgrading OpenTelemetry.Extensions.Hosting, OpenTelemetry.Instrumentation.AspNetCore and OpenTelemetry.Instrumentation.Http to 1.0.0-rc5
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps: For data-plane/track 2 SDKs Issue the following command as a pull request comment:
For track 1 management-plane SDKsPlease open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification. |
/check-enforcer override |
@@ -98,7 +98,7 @@ | |||
<PackageReference Update="System.IdentityModel.Tokens.Jwt" Version="5.4.0" /> | |||
|
|||
<!-- OpenTelemetry dependency approved for Azure.Monitor.OpenTelemetry.Exporter package only --> | |||
<PackageReference Update="OpenTelemetry" Version="1.0.1" Condition="'$(MSBuildProjectName)' == 'Azure.Monitor.OpenTelemetry.Exporter'" /> | |||
<PackageReference Update="OpenTelemetry" Version="1.1.0-beta4" Condition="'$(MSBuildProjectName)' == 'Azure.Monitor.OpenTelemetry.Exporter'" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pakrym what's the recommended practice for integration with the upcoming release of OpenTelemetry?
- Create a separate branch? (any branching naming rule?)
- Use main branch for anything that is not yet GA'ed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the main branch is OK while the exporter is in preview.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT given the exporter is still preview.
Let's see if @pakrym would suggest putting this in a feature branch.