Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade open telemetry package dependencies for Azure Monitor OpenTelemetry Exporter #22017

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Upgrade open telemetry package dependencies for Azure Monitor OpenTelemetry Exporter #22017

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions eng/Packages.Data.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@
<PackageReference Update="System.IdentityModel.Tokens.Jwt" Version="5.4.0" />

<!-- OpenTelemetry dependency approved for Azure.Monitor.OpenTelemetry.Exporter package only -->
<PackageReference Update="OpenTelemetry" Version="1.0.1" Condition="'$(MSBuildProjectName)' == 'Azure.Monitor.OpenTelemetry.Exporter'" />
<PackageReference Update="OpenTelemetry" Version="1.1.0-beta4" Condition="'$(MSBuildProjectName)' == 'Azure.Monitor.OpenTelemetry.Exporter'" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pakrym what's the recommended practice for integration with the upcoming release of OpenTelemetry?

  1. Create a separate branch? (any branching naming rule?)
  2. Use main branch for anything that is not yet GA'ed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the main branch is OK while the exporter is in preview.

</ItemGroup>

<!--
Expand Down Expand Up @@ -210,9 +210,9 @@
<PackageReference Update="NSubstitute" Version="3.1.0" />
<PackageReference Update="NUnit" Version="3.13.2" />
<PackageReference Update="NUnit3TestAdapter" Version="3.17.0" />
<PackageReference Update="OpenTelemetry.Extensions.Hosting" Version="1.0.0-rc2" />
<PackageReference Update="OpenTelemetry.Instrumentation.AspNetCore" Version="1.0.0-rc2" />
<PackageReference Update="OpenTelemetry.Instrumentation.Http" Version="1.0.0-rc2" />
<PackageReference Update="OpenTelemetry.Extensions.Hosting" Version="1.0.0-rc5" />
<PackageReference Update="OpenTelemetry.Instrumentation.AspNetCore" Version="1.0.0-rc5" />
<PackageReference Update="OpenTelemetry.Instrumentation.Http" Version="1.0.0-rc5" />
<PackageReference Update="Polly" Version="7.1.0" />
<PackageReference Update="Portable.BouncyCastle" Version="1.8.5" />
<PackageReference Update="PublicApiGenerator" Version="10.0.1" />
Expand Down