[Resources] add generated files from Subscriptions 2021-01-01 #23144

tjegbejimba · 2021-08-05T22:20:23Z

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

Please open PR in Draft mode if it is:
- Work in progress or not intended to be merged.
- Encountering multiple pipeline failures and working on fixes.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
I have read the contribution guidelines.
The pull request does not introduce breaking changes.

General Guidelines and Best Practices

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

SDK Generation Guidelines

The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

Include updated management metadata.
Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.
If the check fails at the Verify Code Generation step, please ensure:
- Do not modify any code in generated folders.
- Do not selectively include/remove generated files in the PR.
- Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
  Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.
Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:
```
  `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`
```

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

yungezz · 2021-08-20T08:04:49Z

hi @fengzhou-msft could you help review the PR? thanks

fengzhou-msft · 2021-08-23T14:11:54Z

@tjegbejimba there are some test failures, can you take a look?

archerzz

@tjegbejimba
Codes looks good. Please fix the error in pipeline. Thanks.

check-enforcer · 2021-09-21T06:50:01Z

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps:

For data-plane/track 2 SDKs Issue the following command as a pull request comment:

/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run net - [service] - ci

For track 1 management-plane SDKs

Please open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification.

archerzz · 2021-09-22T03:05:46Z

/check-enforcer reset

archerzz · 2021-09-22T03:06:03Z

/check-enforcer evaluate

viananth · 2021-09-27T16:25:33Z

/check-enforcer reset

viananth · 2021-09-27T16:26:12Z

/check-enforcer evaluate

viananth · 2021-09-28T04:09:44Z

@archerzz Check-Enforcer seems to keep getting stuck. Could you please help resolve this?

viananth · 2021-09-29T17:52:40Z

@fengzhou-msft I'm not sure why Check-Enforcer is stuck in "In progress" for days. Could you please help resolve this and merge the PR? Appreciate the help!

viananth · 2021-10-06T05:15:06Z

@fengzhou-msft is there any additional changes required in this PR? Can we merge it if it looks good?

archerzz · 2021-10-08T02:41:50Z

/check-enforcer reset

archerzz · 2021-10-08T02:42:49Z

/check-enforcer evaluate

fengzhou-msft · 2021-10-08T03:07:45Z

/azp run net - mgmt - ci

archerzz · 2021-10-08T05:00:03Z

@viananth @tjegbejimba Would you mind if you could take a look at the broken tests? Thanks.
Ignore checker-enforcer for now, since it seems not working.

archerzz · 2021-10-15T01:41:32Z

/check-enforcer reset

archerzz · 2021-10-15T01:41:50Z

/check-enforcer evaluate

archerzz · 2021-10-15T01:42:01Z

/azp run net - mgmt - ci

archerzz · 2021-10-18T02:09:30Z

/check-enforcer reset

archerzz · 2021-10-18T02:10:08Z

/azp run net - mgmt - ci

archerzz · 2021-10-18T08:35:09Z

/azp run net - mgmt - ci

azure-pipelines · 2021-10-18T08:35:22Z

Azure Pipelines successfully started running 1 pipeline(s).

archerzz · 2021-10-18T12:52:38Z

/azp run net - mgmt - ci

azure-pipelines · 2021-10-18T12:52:50Z

Azure Pipelines successfully started running 1 pipeline(s).

archerzz · 2021-10-18T13:45:11Z

@viananth @tjegbejimba There are still some tests broken. Could you please take a look at it? Thanks.

viananth · 2021-11-23T00:23:11Z

/azp run net - mgmt - ci

azure-pipelines · 2021-11-23T00:23:22Z

Azure Pipelines successfully started running 1 pipeline(s).

viananth · 2022-01-04T19:18:22Z

/azp run net - mgmt - ci

azure-pipelines · 2022-01-04T19:18:34Z

Azure Pipelines successfully started running 1 pipeline(s).

Release of microsoft.network api version: 2022 11 01 (Azure#23652) * Adds base for updating Microsoft.Network from version stable/2022-09-01 to version 2022-11-01 * Updates readme * Updates API version in new specs and examples * remove loadDistributionPolicy from appgw PUT request body example (Azure#23144) * remove loadDistributionPolicy from appgw PUT request body example * remove loadDistributionPolicy from appgw PUT request body example2 * remove loadDistributionPolicy from appgw PUT request body example * remove duplicates * add private link configuration to see if it will fix validation error * remove privateLinkConfig related * revert changes to see if still get validation error * update back to original changes * add response resource id to fix modelValidation error * add connection resource * Selector in Exclusions should not be required as Operator EqualsAny does not need a Selector (Azure#23184) * Application Gateway WAF Rate Limit feature swagger changes (Azure#23021) * Application Gateway WAF Rate Limit feature swagger changes * Fixing lint errors * Updated rate limit feature examples * Fix for applicationGatewayIpConfigurations property and make the priority parameter as required for NSG (Azure#23210) * Fix for applicationGatewayIpConfigurations property This swagger definition is defining property applicationGatewayIpConfigurations, ``` "applicationGatewayIpConfigurations": { "type": "array", "items": { "$ref": "./applicationGateway.json#/definitions/ApplicationGatewayIPConfiguration" }, "description": "Application gateway IP configurations of virtual network resource." } ``` but actual rest api returned applicationGatewayIPConfigurations, the P is upper case while in swagger it is lower case. ``` { "name": "subnet-agw", "id": "/subscriptions/<sub-id>/resourceGroups/<rg-name>/providers/Microsoft.Network/virtualNetworks/<vnet-name>/subnets/subnet-agw", "properties": { "applicationGatewayIPConfigurations": [ { "id": "/subscriptions/<sub-id>/resourceGroups/<rg-name>/providers/Microsoft.Network/applicationGateways/<agw-name>/gatewayIPConfigurations/appGatewayIpConfig" } ] }, "type": "Microsoft.Network/virtualNetworks/subnets" } ``` * Making priority property required [This is the API invoked](https://learn.microsoft.com/en-us/rest/api/virtualnetwork/network-security-groups/create-or-update?tabs=HTTP#code-try-0). For the NSG security rules without priorities, seems like the priority parameter is required. Azure portal works as expected. I don't think that's allowed but according to the schema it is because the priority property is not marked as required. I tried to create a NSG security rule without the priorities and it failed with below. Request Body: ``` { "properties": { "securityRules": [ { "name": "rule1", "properties": { "protocol": "*", "sourceAddressPrefix": "*", "destinationAddressPrefix": "*", "access": "Allow", "destinationPortRange": "80", "sourcePortRange": "*", "direction": "Inbound" } } ] }, "location": "eastus" } ``` Response received: ``` { "error": { "code": "SecurityRuleInvalidPriority", "message": "Security rule has invalid Priority. Value provided: 0 Allowed range 100-4096.", "details": [] } } ``` This PR will make the priority parameter as required. * Update NetworkSecurityGroupDelete.json * Update NetworkSecurityGroupRuleDelete.json * Update NetworkSecurityGroupDelete.json * Undo previous change of making fields optional within Exclusion (Azure#23325) * Nivishenker/http headers to insert (Azure#23295) * new app rule property - http header to insert * prettier * add to 22-11-01 * removed changes from 22-09-01 * fixed example * delete RCG example * fix delete examples * added a Location header * prettier fix * Application Gateway WAF Log scrubbing swagger changes (Azure#23022) * Log scrubbing API changes * Update examples * Addressing comments * Fix * Update property in load balancer for Connection Draining Phase 1 (Azure#23082) * Update property in load balancer for Coneection Draining Phase 1 * Fix model validation * Azure Firewall Packet Capture API. Cancelled PR from 2022-09-01 and created for 2022-11-01 (Azure#23114) * moving packet-capture api to 2022-11-01 release from 2022-09-01 * fixing the LRO response header error for model validation * Changes for Additional nic and corrections (Azure#23522) * Changes for Additional nic and corrections * Fixes for tool reported issues * Fix for SpellCheck, ModelValidation * Defining Location in NetworkVirtualApplianceDelete for async * Minor fix * Minor fix * Minor fix * PrettierCheck fixed * Fixing VirtualApplianceAdditionalNicProperties * ModelValidation fixed * Correcting the location header string * Correcting location header * Prettied Check Fix * Fix * Fix * Add inspection limit changes (Azure#23536) * Fixed headers for examples (Azure#23554) * Fix response of API: List of advertised/learned BGP routes (Azure#23555) * fix response type * fix format * fix example, add x-ms-identifiers * AuxiliarySku on Nic (Azure#23552) * Adding auxiliary sku property on nic * Adding AcceleratedConnections to AuxMode * modifying the auxSku values * Removing accidental change --------- Co-authored-by: Prachi Pravin Bhavsar <prbhavsar@microsoft.com> * migrated latest pr from incorrect branch (Azure#23589) * Changes for NVA connection (Azure#23173) * Changes for NVA connection * Changes to address validation failures * Fix some ModelValidation errors * Fix some ModelValidation errors * Fix some ModelValidation errors * Fix some ModelValidation errors * Fix some ModelValidation errors * Addressing some review comments * Addressing some review comments * Addressing some review comments * Addressing some review comments * Addressing some review comments * Fix camel case for property name * Fixing resourceUri to Camel case in example files * Fix SDK duplication error * Fix one LintDiff error * try fix lintdiff errors * fix lro erro in lintdiff * fix model validation error * Bastion S360 for 2022-11 version (Azure#23595) * Release microsoft.network 2022 11 01 (Azure#23564) * Application Gateway WAF Rate Limit feature swagger changes * Fixing lint errors * Updated rate limit feature examples * rateLimitDuration and rateLimitThreshold are not mandatory. There are only mandatory if ruleType is RateLimitRule. This validation will be done in NRP. * Fix attempt 2. Removed minimum constraint from rateLimitThreshold. Validation will be done in NRP * Remove the minimum number for the option field requestBodyInspectLimitInKB (Azure#23663) * Remove minimum value for optional field requestBodyInspectLimitInKB * Remove exlcusiveMinimum --------- Co-authored-by: htippanaboya <102244326+htippanaboya@users.noreply.github.com> Co-authored-by: tracyMicro <127259533+tracyMicro@users.noreply.github.com> Co-authored-by: tejasshah7 <49326906+tejasshah7@users.noreply.github.com> Co-authored-by: sraghavan-msft <98118843+sraghavan-msft@users.noreply.github.com> Co-authored-by: navba-MSFT <57353862+navba-MSFT@users.noreply.github.com> Co-authored-by: NiviShenker <99583088+NiviShenker@users.noreply.github.com> Co-authored-by: Sindhu Aluguvelli <sindhureddy216@gmail.com> Co-authored-by: phrazfipho <121897152+phrazfipho@users.noreply.github.com> Co-authored-by: nikhilpadhye1 <68977752+nikhilpadhye1@users.noreply.github.com> Co-authored-by: JainRah <108508612+JainRah@users.noreply.github.com> Co-authored-by: karanbazaz <karan.bazaz@gmail.com> Co-authored-by: yeliMSFT <95386492+yeliMSFT@users.noreply.github.com> Co-authored-by: pracsb <78512712+pr-work@users.noreply.github.com> Co-authored-by: Prachi Pravin Bhavsar <prbhavsar@microsoft.com> Co-authored-by: nanditaashok-ms <122581061+nanditaashok-ms@users.noreply.github.com> Co-authored-by: anvrao1 <109107918+anvrao1@users.noreply.github.com> Co-authored-by: baoqihuang0326 <119557638+baoqihuang0326@users.noreply.github.com>

tjegbejimba added 2 commits August 5, 2021 15:12

add newest subscription files

a87c17a

Merge branch 'main' of https://github.com/Azure/azure-sdk-for-net

4ff4ff0

tjegbejimba requested review from allenjzhang, archerzz, ArcturusZhang, fengzhou-msft, m-nash, markcowl and yungezz as code owners August 5, 2021 22:20

openapi-assignment-bot bot assigned yungezz Aug 5, 2021

yungezz assigned fengzhou-msft Aug 20, 2021

yungezz added the Mgmt This issue is related to a management-plane library. label Aug 20, 2021

fengzhou-msft closed this Aug 23, 2021

fengzhou-msft reopened this Aug 23, 2021

archerzz approved these changes Sep 18, 2021

View reviewed changes

archerzz requested changes Sep 18, 2021

View reviewed changes

Merge branch 'main' into main

ae5dcb0

tjegbejimba requested review from ArthurMa1978 and Yao725 as code owners September 21, 2021 06:39

tjegbejimba requested a review from archerzz September 29, 2021 18:57

fengzhou-msft closed this Sep 30, 2021

fengzhou-msft reopened this Sep 30, 2021

Update Microsoft.Azure.Management.ResourceManager.csproj

643de64

tjegbejimba added 2 commits October 14, 2021 12:39

fix test errors

3e380be

Merge branch 'main' of https://github.com/tjegbejimba/azure-sdk-for-net

da454df

Update Microsoft.Azure.Management.ResourceManager.csproj

5a9b6f5

tjegbejimba closed this Jan 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Resources] add generated files from Subscriptions 2021-01-01 #23144

[Resources] add generated files from Subscriptions 2021-01-01 #23144

tjegbejimba commented Aug 5, 2021

yungezz commented Aug 20, 2021

fengzhou-msft commented Aug 23, 2021

archerzz left a comment

check-enforcer bot commented Sep 21, 2021

archerzz commented Sep 22, 2021

archerzz commented Sep 22, 2021

viananth commented Sep 27, 2021

viananth commented Sep 27, 2021

viananth commented Sep 28, 2021

viananth commented Sep 29, 2021

viananth commented Oct 6, 2021

archerzz commented Oct 8, 2021

archerzz commented Oct 8, 2021

fengzhou-msft commented Oct 8, 2021

archerzz commented Oct 8, 2021

archerzz commented Oct 15, 2021

archerzz commented Oct 15, 2021

archerzz commented Oct 15, 2021

archerzz commented Oct 18, 2021

archerzz commented Oct 18, 2021

archerzz commented Oct 18, 2021

azure-pipelines bot commented Oct 18, 2021

archerzz commented Oct 18, 2021

azure-pipelines bot commented Oct 18, 2021

archerzz commented Oct 18, 2021

viananth commented Nov 23, 2021

azure-pipelines bot commented Nov 23, 2021

viananth commented Jan 4, 2022

azure-pipelines bot commented Jan 4, 2022

[Resources] add generated files from Subscriptions 2021-01-01 #23144

[Resources] add generated files from Subscriptions 2021-01-01 #23144

Conversation

tjegbejimba commented Aug 5, 2021

All SDK Contribution checklist:

General Guidelines and Best Practices

Testing Guidelines

SDK Generation Guidelines

Additional management plane SDK specific contribution checklist:

Management plane SDK Troubleshooting

Old outstanding PR cleanup

yungezz commented Aug 20, 2021

fengzhou-msft commented Aug 23, 2021

archerzz left a comment

Choose a reason for hiding this comment

check-enforcer bot commented Sep 21, 2021

What is Check Enforcer?

Why am I getting this message?

What should I do now?

What if I am onboarding a new service?

For data-plane/track 2 SDKs Issue the following command as a pull request comment:

For track 1 management-plane SDKs

archerzz commented Sep 22, 2021

archerzz commented Sep 22, 2021

viananth commented Sep 27, 2021

viananth commented Sep 27, 2021

viananth commented Sep 28, 2021

viananth commented Sep 29, 2021

viananth commented Oct 6, 2021

archerzz commented Oct 8, 2021

archerzz commented Oct 8, 2021

fengzhou-msft commented Oct 8, 2021

archerzz commented Oct 8, 2021

archerzz commented Oct 15, 2021

archerzz commented Oct 15, 2021

archerzz commented Oct 15, 2021

archerzz commented Oct 18, 2021

archerzz commented Oct 18, 2021

archerzz commented Oct 18, 2021

azure-pipelines bot commented Oct 18, 2021

archerzz commented Oct 18, 2021

azure-pipelines bot commented Oct 18, 2021

archerzz commented Oct 18, 2021

viananth commented Nov 23, 2021

azure-pipelines bot commented Nov 23, 2021

viananth commented Jan 4, 2022

azure-pipelines bot commented Jan 4, 2022