Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RepairAction property to VMSS AutoRepairs feature #25095

Merged
merged 8 commits into from
Jan 14, 2022
Merged

Add RepairAction property to VMSS AutoRepairs feature #25095

merged 8 commits into from
Jan 14, 2022

Conversation

frank-pang-msft
Copy link
Contributor

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
    - N/A
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.
    - Had issues running the UpdatePkg_Version.ps1 command

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
    - N/A
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.
    - Added Compute_2021-11-01

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

  • If the check fails at the Verify Code Generation step, please ensure:

    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

    Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:

      `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@ghost ghost added the Compute label Nov 2, 2021
@Yao725
Copy link
Member

Yao725 commented Dec 2, 2021

/azp run net - mgmt - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Yao725
Copy link
Member

Yao725 commented Dec 2, 2021

@frank-pang-msft , could you please fix the failed tests?

AnupVasudevaRao
AnupVasudevaRao reviewed Dec 2, 2021
View reviewed changes
sdk/compute/Microsoft.Azure.Management.Compute/tests/VMScaleSetTests/VMScaleSetScenarioTests.cs
Assert.Equal("replace", getResponse.AutomaticRepairsPolicy.RepairAction, ignoreCase: true);

// Test other repair actions. Must disable before changing repair action
foreach (string repairAction in new List<string> { "restart", "reimage" })
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"restart", "reimage"

as in previous comment, constants (or enums) are preferred

AnupVasudevaRao
AnupVasudevaRao reviewed Dec 2, 2021
View reviewed changes
sdk/eng/mgmt/mgmtmetadata/compute_resource-manager.txt Outdated
@@ -0,0 +1,15 @@
Installing AutoRest version: v2
AutoRest installed successfully.
Copy link

@AnupVasudevaRao AnupVasudevaRao Dec 2, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious: what is this file for?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it gets generated with SDK generation. Not to worry about. I will take it out if it needs be

@grizzlytheodore
Copy link
Member

/azp run

@azure-pipelines
Copy link

Pull request contains merge conflicts.

@grizzlytheodore grizzlytheodore merged commit 4ff3c91 into Azure:feature/cplat-2021-11-01 Jan 14, 2022
ArthurMa1978 pushed a commit that referenced this pull request Jan 27, 2022
@grizzlytheodore @karthikka4820
@frank-pang-msft @chasevanb @cvanbuskirk-microsoft @raktdas @kamusta-msft @sukodava @ms-saypaul @vbhasker-msft @avjai @xielexie
Update for Compute 2021-11-01 version (#26370)
6e05fea 
* update with api version 2021-11-01

* update with api version 2021-11-01

* update virtualmachine to virtualMachine in swagger

* update test to preserve resource group until finally block

* test updates and new recordings

* update from swagger sync

* Added SDK changes for scaling VMSS with PublicIpPrefix (patch updates) (#26031)

* Add RepairAction property to VMSS AutoRepairs feature (#25095)

* Add RepairAction property to VMSS AutoRepairs feature

* Include metadata file

* Add session record and updated test

* Update TestVMScaleSetScenarioOperations_OrchestrationService.json

* Restore files that shouldn't have been changed

* Add orchestration service record

* Delete compute_resource-manager.txt

Co-authored-by: Theodore Chang <thchan@microsoft.com>

* sdk gen (#25670)

Co-authored-by: Chase Van Buskirk <cvanbuskirk@microsoft.com>

* Added sdk changes for vmss vm customization (#25785)

* Added sdk changes for vmss vm customization

* Added sdk changes for vmss vm customization

* init (#25620)

Co-authored-by: Theodore Chang <thchan@microsoft.com>

* Initial commit (#25383)

* SDK changes for CVM for api-version 2021-11-01 (#25645)

* sdk changes for CVM

* save changes for securityType and diskSecurityprofile

Add PMK scenario

* Added recorded file

* DedicatedHost Reboot Feature SDK (#25258)

* ran autorest on azure-rest-api-specs after adding dhreboot to compute.json

* ran autorest again, since i made some swagger changes

* created test

* renamed reboot to restart

* updated swagger, and ran the generate command again to update the sdk

* restart test passing. Added recorded test as well

* rebuilt sdk with async=true, removed unnecessary line in test, and reran test after change

* Adding the new paramaters zone/placementGroupId to ForceRecoveryServiceFabricPlatformUpdateDomainWalk (#25897)

* add filter for List VMSS operations  (#25802)

* fdsaf

* generated change

* Adding VMScaleSet Flex Filter Test

* Update generate.ps1

* add recording

Co-authored-by: LexieXie <lexiexie@microsoft.com>
Co-authored-by: xielexie <94083876+xielexie@users.noreply.github.com>

* add customizations

* fix errors

* regenerated from master

* fix customization

* fix customization

* fix a test

* new test recordings

* change version name

* remove unnecessary variable

* update recording test

* fix changes

Co-authored-by: karthikka4820 <88366202+karthikka4820@users.noreply.github.com>
Co-authored-by: frank-pang-msft <92764154+frank-pang-msft@users.noreply.github.com>
Co-authored-by: Chase VanBuskirk <chasevanb@gmail.com>
Co-authored-by: Chase Van Buskirk <cvanbuskirk@microsoft.com>
Co-authored-by: Raktima Das <raktdas@microsoft.com>
Co-authored-by: kamusta-msft <56413142+kamusta-msft@users.noreply.github.com>
Co-authored-by: sukodava <78733210+sukodava@users.noreply.github.com>
Co-authored-by: ms-saypaul <67093296+ms-saypaul@users.noreply.github.com>
Co-authored-by: vbhasker-msft <93355049+vbhasker-msft@users.noreply.github.com>
Co-authored-by: avjai <34567499+avjai@users.noreply.github.com>
Co-authored-by: LexieXie <lexiexie@microsoft.com>
Co-authored-by: xielexie <94083876+xielexie@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnupVasudevaRao AnupVasudevaRao AnupVasudevaRao left review comments

@grizzlytheodore grizzlytheodore grizzlytheodore left review comments

@archerzz archerzz Awaiting requested review from archerzz

@ArcturusZhang ArcturusZhang Awaiting requested review from ArcturusZhang

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978

@fengzhou-msft fengzhou-msft Awaiting requested review from fengzhou-msft

@m-nash m-nash Awaiting requested review from m-nash

@Yao725 Yao725 Awaiting requested review from Yao725

@AlexGhiondea AlexGhiondea Awaiting requested review from AlexGhiondea

Assignees

@Yao725 Yao725

Labels
Compute Do Not Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frank-pang-msft @Yao725 @grizzlytheodore @AnupVasudevaRao