Update for Compute 2021-11-01 version #26370

grizzlytheodore · 2022-01-14T21:17:12Z

All SDK Contribution checklist:

This PR is for Compute Rest API 2021-11-01 version: Azure/azure-rest-api-specs#17120
Tests that use CRP calls were re-recorded to use the 2021-11-01 version.
New features were added for this version with new test coverages and recordings.
Customizations were added for changed signature changes to avoid breaking changes.

This checklist is used to make sure that common guidelines for a pull request are followed.

Please open PR in Draft mode if it is:
- Work in progress or not intended to be merged.
- Encountering multiple pipeline failures and working on fixes.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
I have read the contribution guidelines.
The pull request does not introduce breaking changes.

General Guidelines and Best Practices

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

SDK Generation Guidelines

The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

Include updated management metadata.
Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.
If the check fails at the Verify Code Generation step, please ensure:
- Do not modify any code in generated folders.
- Do not selectively include/remove generated files in the PR.
- Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
  Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.
Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:
```
  `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`
```

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

…zure-sdk-for-net into feature/cplat-2021-11-01

#26031)

* Add RepairAction property to VMSS AutoRepairs feature * Include metadata file * Add session record and updated test * Update TestVMScaleSetScenarioOperations_OrchestrationService.json * Restore files that shouldn't have been changed * Add orchestration service record * Delete compute_resource-manager.txt Co-authored-by: Theodore Chang <thchan@microsoft.com>

Co-authored-by: Chase Van Buskirk <cvanbuskirk@microsoft.com>

* Added sdk changes for vmss vm customization * Added sdk changes for vmss vm customization

Co-authored-by: Theodore Chang <thchan@microsoft.com>

* sdk changes for CVM * save changes for securityType and diskSecurityprofile Add PMK scenario * Added recorded file

* ran autorest on azure-rest-api-specs after adding dhreboot to compute.json * ran autorest again, since i made some swagger changes * created test * renamed reboot to restart * updated swagger, and ran the generate command again to update the sdk * restart test passing. Added recorded test as well * rebuilt sdk with async=true, removed unnecessary line in test, and reran test after change

…ceFabricPlatformUpdateDomainWalk (#25897)

* fdsaf * generated change * Adding VMScaleSet Flex Filter Test * Update generate.ps1 * add recording Co-authored-by: LexieXie <lexiexie@microsoft.com> Co-authored-by: xielexie <94083876+xielexie@users.noreply.github.com>

…zure-sdk-for-net into feature/cplat-2021-11-01

check-enforcer · 2022-01-14T21:32:00Z

This pull request is protected by Check Enforcer.
For more information about how to run a pipeline against this pull request, see this.

sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/IVirtualMachinesOperations.cs

…zure-sdk-for-net into feature/cplat-2021-11-01

fengzhou-msft · 2022-01-24T07:27:50Z

@grizzlytheodore please fix the failed tests.

grizzlytheodore · 2022-01-24T19:38:56Z

@fengzhou-msft I am having a hard time solving the CI failure. Looking at the CI failure log, if I search for [FAIL] I see that test Compute.Tests.VMScaleSetUpdateTests.TestVMScaleSetScalingOperations is failing with:
System.Collections.Generic.KeyNotFoundException : Unable to find a matching HTTP request for URL 'GET /subscriptions/e37510d7-33b6-4676-886f-ee75bcc01871/providers/Microsoft.Compute/locations/SoutheastAsia/publishers/MicrosoftWindowsServer/artifacttypes/vmimage/offers/WindowsServer/skus/2012-R2-Datacenter/versions?$top=1&api-version=2021-11-01'. Calling method Item().

However I can find that line is recorded here for that test.

Also, I am getting different number of tests failing in playback mode in my VM, and in my personal workstation. Also the numbers change when I run all the tests vs just the failing ones.

Any advice?

grizzlytheodore · 2022-01-26T17:12:29Z

@fengzhou-msft please review/merge !

haagha · 2022-02-14T16:25:45Z

...pute/Microsoft.Azure.Management.Compute/src/Generated/VirtualMachineScaleSetVMsOperations.cs

@@ -269,7 +269,7 @@ public async Task<AzureOperationResponse<VirtualMachineScaleSetVM>> GetWithHttpM
            }
            // Construct URL
            var _baseUrl = Client.BaseUri.AbsoluteUri;
-            var _url = new System.Uri(new System.Uri(_baseUrl + (_baseUrl.EndsWith("/") ? "" : "/")), "subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/virtualMachineScaleSets/{vmScaleSetName}/virtualmachines/{instanceId}").ToString();
+            var _url = new System.Uri(new System.Uri(_baseUrl + (_baseUrl.EndsWith("/") ? "" : "/")), "subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/virtualMachineScaleSets/{vmScaleSetName}/virtualMachines/{instanceId}").ToString();


I think this line change might the reason for breaking of some SDK calls relating VMSSVMs? @grizzlytheodore @fengzhou-msft

@ArthurMa1978

Updated the examples for better documentationj (Azure#26370)

grizzlytheodore and others added 19 commits October 28, 2021 20:11

update with api version 2021-11-01

f8ab326

update with api version 2021-11-01

33a9764

Merge branch 'feature/cplat-2021-11-01' of https://github.com/Azure/a…

fd5e03e

…zure-sdk-for-net into feature/cplat-2021-11-01

update virtualmachine to virtualMachine in swagger

ab0fabf

update test to preserve resource group until finally block

0ac0707

test updates and new recordings

ebf6183

Merge branch 'feature/cplat-2021-11-01' of https://github.com/Azure/a…

f6c07d9

…zure-sdk-for-net into feature/cplat-2021-11-01

update from swagger sync

5a5a96b

Added SDK changes for scaling VMSS with PublicIpPrefix (patch updates) (

b77c378

#26031)

sdk gen (#25670)

00602fa

Co-authored-by: Chase Van Buskirk <cvanbuskirk@microsoft.com>

Added sdk changes for vmss vm customization (#25785)

5278e55

* Added sdk changes for vmss vm customization * Added sdk changes for vmss vm customization

init (#25620)

2f450af

Co-authored-by: Theodore Chang <thchan@microsoft.com>

Initial commit (#25383)

0128233

SDK changes for CVM for api-version 2021-11-01 (#25645)

11375ec

* sdk changes for CVM * save changes for securityType and diskSecurityprofile Add PMK scenario * Added recorded file

Adding the new paramaters zone/placementGroupId to ForceRecoveryServi…

dc9a75a

…ceFabricPlatformUpdateDomainWalk (#25897)

add filter for List VMSS operations (#25802)

a3d532e

* fdsaf * generated change * Adding VMScaleSet Flex Filter Test * Update generate.ps1 * add recording Co-authored-by: LexieXie <lexiexie@microsoft.com> Co-authored-by: xielexie <94083876+xielexie@users.noreply.github.com>

add customizations

c8300fa

ghost added the Compute label Jan 14, 2022

Merge branch 'feature/cplat-2021-11-01' of https://github.com/Azure/a…

dc0d42e

…zure-sdk-for-net into feature/cplat-2021-11-01

grizzlytheodore added 2 commits January 19, 2022 10:29

fix errors

e0d06c1

regenerated from master

5711993

grizzlytheodore commented Jan 19, 2022

View reviewed changes

sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/IVirtualMachinesOperations.cs Show resolved Hide resolved

grizzlytheodore commented Jan 19, 2022

View reviewed changes

sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/IVirtualMachinesOperations.cs Show resolved Hide resolved

grizzlytheodore added 4 commits January 19, 2022 12:43

fix customization

5f9c7cd

merge main to this branch

312323c

fix customization

fae522a

fix a test

7beb839

grizzlytheodore added 2 commits January 20, 2022 19:54

new test recordings

58b2caf

change version name

cc07de0

grizzlytheodore marked this pull request as ready for review January 20, 2022 20:00

grizzlytheodore requested review from archerzz, ArcturusZhang, ArthurMa1978, fengzhou-msft, m-nash, markcowl and Yao725 as code owners January 20, 2022 20:00

openapi-assignment-bot bot assigned fengzhou-msft Jan 20, 2022

grizzlytheodore changed the title ~~Feature/cplat 2021 11 01~~ Update for Compute 2021-11-01 version Jan 20, 2022

grizzlytheodore added 3 commits January 20, 2022 17:04

remove unnecessary variable

68762a2

update recording test

a60d41a

Merge branch 'feature/cplat-2021-11-01' of https://github.com/Azure/a…

c67e0eb

…zure-sdk-for-net into feature/cplat-2021-11-01

fix changes

f2d164b

ArthurMa1978 approved these changes Jan 27, 2022

View reviewed changes

ArthurMa1978 merged commit 6e05fea into main Jan 27, 2022

ArthurMa1978 deleted the feature/cplat-2021-11-01 branch January 27, 2022 23:51

haagha reviewed Feb 14, 2022

View reviewed changes

azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this pull request Oct 30, 2023

CodeGen from PR 26370 in Azure/azure-rest-api-specs

429bc88

Updated the examples for better documentationj (Azure#26370)

azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this pull request Dec 22, 2023

CodeGen from PR 26370 in Azure/azure-rest-api-specs

0ec1e00

Updated the examples for better documentationj (Azure#26370)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update for Compute 2021-11-01 version #26370

Update for Compute 2021-11-01 version #26370

grizzlytheodore commented Jan 14, 2022 •

edited

Loading

check-enforcer bot commented Jan 14, 2022

fengzhou-msft commented Jan 24, 2022

grizzlytheodore commented Jan 24, 2022

grizzlytheodore commented Jan 26, 2022

haagha Feb 14, 2022 •

edited

Loading

haagha Feb 14, 2022

Update for Compute 2021-11-01 version #26370

Update for Compute 2021-11-01 version #26370

Conversation

grizzlytheodore commented Jan 14, 2022 • edited Loading

All SDK Contribution checklist:

General Guidelines and Best Practices

Testing Guidelines

SDK Generation Guidelines

Additional management plane SDK specific contribution checklist:

Management plane SDK Troubleshooting

Old outstanding PR cleanup

check-enforcer bot commented Jan 14, 2022

fengzhou-msft commented Jan 24, 2022

grizzlytheodore commented Jan 24, 2022

grizzlytheodore commented Jan 26, 2022

haagha Feb 14, 2022 • edited Loading

Choose a reason for hiding this comment

haagha Feb 14, 2022

Choose a reason for hiding this comment

grizzlytheodore commented Jan 14, 2022 •

edited

Loading

haagha Feb 14, 2022 •

edited

Loading