[Identity] Class documentation improvements #32043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvaneck
requested review from
schaabs,
christothes and
ShivangiReja
as code owners
ghost
added
the
|
API change check API changes are not detected in this pull request. |
christothes
approved these changes
Oct 26, 2022
This adds additional details to the docstrings for some of the credential classes. Users may find the added info helpful. Also added missing envvar in README. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
pvaneck
force-pushed
the
identity-class-docs
branch
from
a33bd88
to
c94df56
Compare
scottaddie
approved these changes
Oct 27, 2022
sdk/identity/Azure.Identity/src/Credentials/EnvironmentCredential.cs
Outdated
Show resolved
Hide resolved
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
schaabs
pushed a commit
to schaabs/azure-sdk-for-net
that referenced
this pull request
Nov 8, 2022
This adds additional details to the docstrings for some of the credential classes. Users may find the added info helpful. Also added missing envvar in README. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
schaabs
added a commit
that referenced
this pull request
Nov 8, 2022
* [Identity] Update documentation (#31867) This updates the README and TROUBLESHOOTING files for greater consistency with other language docs and for general enhancement. Code snippets were added for the README. Ref: #31064 Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com> Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com> * fix error messages with AADSTS and az login (#31949) * fix error messages with AADSTS and az login * Update SharedTokenCacheCredential XML class documentation (#32195) * [Identity] Class documentation improvements (#32043) This adds additional details to the docstrings for some of the credential classes. Users may find the added info helpful. Also added missing envvar in README. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com> * Update Azure.Identity changelog (#32216) * Handle Managed Identity json parse errors as CredentialUnAvailableException (#32272) * handle json parse errors as CredentialNotAvailable * update changelog for 1.8.0 release * update csproj version Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com> Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com> Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com> Co-authored-by: Christopher Scott <chriss@microsoft.com>
sofiar-msft
pushed a commit
to sofiar-msft/azure-sdk-for-net
that referenced
this pull request
Dec 7, 2022
This adds additional details to the docstrings for some of the credential classes. Users may find the added info helpful. Also added missing envvar in README. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds additional details to the docstrings for some of the credential classes. Users may find the added info helpful.
Ref: #30961