Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Managed Identity json parse errors as CredentialUnAvailableException #32272

Merged
merged 2 commits into from
Nov 3, 2022

Conversation

christothes
Copy link
Member

@christothes christothes commented Nov 3, 2022

fixes #32061
fixes #30467

@ghost ghost added the Azure.Identity label Nov 3, 2022
@christothes christothes self-assigned this Nov 3, 2022
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@christothes christothes merged commit ffe9238 into main Nov 3, 2022
@christothes christothes deleted the chriss/imds-parse-error branch November 3, 2022 17:42
schaabs pushed a commit to schaabs/azure-sdk-for-net that referenced this pull request Nov 8, 2022
…eption (Azure#32272)

* handle json parse errors as CredentialNotAvailable
schaabs added a commit that referenced this pull request Nov 8, 2022
* [Identity] Update documentation (#31867)

This updates the README and TROUBLESHOOTING files for
greater consistency with other language docs and for general
enhancement. Code snippets were added for the README.

Ref: #31064

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>

* fix error messages with AADSTS and az login (#31949)

* fix error messages with AADSTS and az login

* Update SharedTokenCacheCredential XML class documentation (#32195)

* [Identity] Class documentation improvements (#32043)

This adds additional details to the docstrings for
some of the credential classes. Users may find the
added info helpful.

Also added missing envvar in README.

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>

* Update Azure.Identity changelog (#32216)

* Handle Managed Identity json parse errors as CredentialUnAvailableException (#32272)

* handle json parse errors as CredentialNotAvailable

* update changelog for 1.8.0 release

* update csproj version

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com>
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
Co-authored-by: Christopher Scott <chriss@microsoft.com>
sofiar-msft pushed a commit to sofiar-msft/azure-sdk-for-net that referenced this pull request Dec 7, 2022
…eption (Azure#32272)

* handle json parse errors as CredentialNotAvailable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants