Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ApiRevisionId and other test fixes #4120

Merged
merged 2 commits into from
Mar 13, 2018
Merged

Fix ApiRevisionId and other test fixes #4120

merged 2 commits into from
Mar 13, 2018

Conversation

solankisamir
Copy link
Member

@solankisamir solankisamir commented Mar 9, 2018

Description

Swagger Spec: Azure/azure-rest-api-specs#2622

  • Test fixes for couple of tests
  • Added easy property to retrieve Logger Credentials Property
  • Fix for changing to ApiRevisionId
  • Re-recorded all tests.

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@solankisamir
Copy link
Member Author

@shahabhijeet can you take a look? Build passed.

@solankisamir
Copy link
Member Author

@shahabhijeet can you take a look today? We want to publish the nuget today.

@dsgouda dsgouda self-assigned this Mar 12, 2018
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the version number to 4.1.0-preview in the .csproj since there are breaking changes.
Also pull down the latest changes and run
msbuild build.proj /t:build /p:Scope=SDKs\ApiManagement and commit any artifacts that may be generated

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @shahabhijeet PTAL and merge

@dsgouda dsgouda merged commit 8e94ed2 into Azure:psSdkJson6 Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants