Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Microsoft.Logic API Version: 2018-07-01-preview #4770

Merged
merged 5 commits into from
Sep 21, 2018
Merged

New Microsoft.Logic API Version: 2018-07-01-preview #4770

merged 5 commits into from
Sep 21, 2018

Conversation

refortie
Copy link
Contributor

@refortie refortie commented Sep 17, 2018 •
edited
Loading

Description

REST spec PRs:
Add new microsoft.logic version
Change some string Microsoft.Logic modeled enums back into enums
Remove default response from Sessions

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@refortie
Copy link
Contributor Author

This introduces a lot of breaking changes. We are doing a version up of the APIs

@refortie refortie changed the title New Microsoft.Logic API Version New Microsoft.Logic API Version - 2018-07-01-preview Sep 17, 2018
@refortie refortie changed the title New Microsoft.Logic API Version - 2018-07-01-preview New Microsoft.Logic API Version: 2018-07-01-preview Sep 17, 2018
dsgouda
dsgouda suggested changes Sep 18, 2018
View reviewed changes
src/SDKs/Logic/Logic.Tests/Logic.Tests.csproj
<None Update="TestData\IntegrationAccountAssemblyContent.dll">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Update="TestData\IntegrationAccountCertificate.cer">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an authentication certificate? Not sure if we can check this in
@shahabhijeet FYI

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a file that had already existed in the repo to be used in tests. I'm not sure how the tests worked without the file being included. They don't work locally when I don't include it. In general this isn't a cert to anything in particular, just a cert in general.

Copy link
Member

@shahabhijeet shahabhijeet Sep 21, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@refortie if this is a self-signed cert, this should be fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a self signed cert.

src/SDKs/Logic/Logic.Tests/Logic.Tests.csproj Show resolved Hide resolved
src/SDKs/Logic/Management.Logic/Microsoft.Azure.Management.Logic.csproj Outdated
@@ -5,7 +5,7 @@

<PropertyGroup>
<Description>Microsoft Azure LogicApps Management Library</Description>
<Version>3.1.0</Version>
<Version>4.0.0</Version>
<PackageId>Microsoft.Azure.Management.Logic</PackageId>
<PackageTags>Microsoft Azure LogicApps management;LogicApps;LogicApps management;</PackageTags>
<PackageReleaseNotes/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add PackageReleaseNotes here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added, please let me know if the formatting is incorrect

@dsgouda
Copy link
Contributor

dsgouda commented Sep 18, 2018

Please fix the CI errors reported

@refortie
Updates from the PR:
590e0cc 
* Change the tests to generate proper session records
* Added to the changelog
dsgouda
dsgouda suggested changes Sep 21, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need an approval from @shahabhijeet regarding the cert

src/SDKs/Logic/Management.Logic/Microsoft.Azure.Management.Logic.csproj Show resolved Hide resolved
@refortie
PR updates:
ca0f69e 
Decrease size of Changelog
Remove conditional on warnings as errors
dsgouda
dsgouda approved these changes Sep 21, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will let @shahabhijeet take a look and we are good to merge

@dsgouda
Copy link
Contributor

dsgouda commented Sep 21, 2018

Talked to @shahabhijeet , self signed certificates are acceptable, thanks!

@dsgouda dsgouda merged commit 09b6933 into Azure:psSdkJson6 Sep 21, 2018
This was referenced Oct 17, 2022
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahabhijeet shahabhijeet shahabhijeet left review comments

@dsgouda dsgouda dsgouda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@refortie @dsgouda @shahabhijeet