Enable WarnAsError for official builds #5351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed issue #5352 to track the KeyVault test methods I commented out. |
4 tasks
Fixes a few existing warnings: - Disables semver 2 nuget package version warning - Commented out some test code that is giving warnings about not being marked as Fact. Will fill a follow-up issues about those tests.
weshaggard
force-pushed
the
EnableWarnAsError
branch
from
9f2fe8b
to
ee24fc8
Compare
The DotNETCoreCLI task doesn't support extra arguments when calling the pack command so we need to directly call pack instead. see microsoft/azure-pipelines-tasks#9789
weshaggard
force-pushed
the
EnableWarnAsError
branch
from
ee24fc8
to
cb07c66
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few existing warnings:
about not being marked as Fact. Will fill a follow-up
issues about those tests.
@Azure/azure-sdk-eng