[ServiceBus] Normalize ServiceBusAdministrationClient name parameter naming. #14225
Assignees
Labels
blocking-release
Blocks release
Client
This issue points to a problem in the data-plane of the library.
help wanted
This issue is tracking work for which community contributions would be welcomed and appreciated
Service Bus
Milestone
Comments
KieranBrantnerMagee
added
Service Bus
Client
|
In the latest API view, I see |
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-python
that referenced
this issue
May 26, 2021
[Hub Generated] Review request for Microsoft.BotService to add version preview/2021-05-01 (Azure#14225) * Adds base for updating Microsoft.BotService from version stable/2021-03-01 to version 2021-05-01 * Updates readme * Updates API version in new specs and examples * add operation result api's to support async operations * add private links support * fix issues in examples * fix more errors * fix prettier issues * add missing private links operation. some more fixes * fix model validation errors * address comments * remove properties bag * remove unintentional change in unrelated api * update example * change api version to have preview suffix * fix lint and model validation errors * change folder name to preview to match api version * add breaking changes from base branch * fix api version * fix prettier warnings * update readme * Update specification/botservice/resource-manager/readme.md Co-authored-by: JianyeXi <59603451+jianyexi@users.noreply.github.com> * check if rename works * remove system data since it's not support for other botservice * remove references to common types.json resource to avoid conflicts Co-authored-by: Swagat Mishra <swagatm@microsoft.com> Co-authored-by: JianyeXi <59603451+jianyexi@users.noreply.github.com>
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-python
that referenced
this issue
May 26, 2021
[Hub Generated] Review request for Microsoft.BotService to add version preview/2021-05-01 (Azure#14225) * Adds base for updating Microsoft.BotService from version stable/2021-03-01 to version 2021-05-01 * Updates readme * Updates API version in new specs and examples * add operation result api's to support async operations * add private links support * fix issues in examples * fix more errors * fix prettier issues * add missing private links operation. some more fixes * fix model validation errors * address comments * remove properties bag * remove unintentional change in unrelated api * update example * change api version to have preview suffix * fix lint and model validation errors * change folder name to preview to match api version * add breaking changes from base branch * fix api version * fix prettier warnings * update readme * Update specification/botservice/resource-manager/readme.md Co-authored-by: JianyeXi <59603451+jianyexi@users.noreply.github.com> * check if rename works * remove system data since it's not support for other botservice * remove references to common types.json resource to avoid conflicts Co-authored-by: Swagat Mishra <swagatm@microsoft.com> Co-authored-by: JianyeXi <59603451+jianyexi@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Is your feature request related to a problem? Please describe.
See this comment
In short, the other "name" fields within the ServiceBusAdministrationClient are being changed to be explicitly queue_name, topic_name, etc. This should be consistent even for the "final named argument", as this makes it consistent with ARM call patterns.
Describe the solution you'd like
Follow the guidance in the aformentioned comment, normalize with other name fields and with -mgmt sdk.
Describe alternatives you've considered
The current status quo is the alternative, see the comment chain for discussion on relative merits.
The text was updated successfully, but these errors were encountered: