[ServiceBus]remove topic parameter object settability #14116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (instead of objects)
…l entity objects, for non-update functions.
KieranBrantnerMagee
added
Service Bus
Client
KieranBrantnerMagee
requested review from
annatisch,
rakshith91,
yunhaoling and
YijunXieMS
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
KieranBrantnerMagee
requested review from
changlong-liu,
jsntcy and
msyyc
as code owners
annatisch
reviewed
Oct 1, 2020
| @@ -603,11 +594,11 @@ def get_subscription_runtime_properties(self, topic, subscription_name, **kwargs | |||
| entry.title, entry.content.subscription_description) | |||
| return subscription | |||
|
|
|||
| def create_subscription(self, topic, name, **kwargs): | |||
| # type: (Union[str, TopicProperties], str, Any) -> SubscriptionProperties | |||
| def create_subscription(self, topic_name, name, **kwargs): | |||
There was a problem hiding this comment.
Maybe now that we've suffixed all the others, should we update name to subscription_name?
There was a problem hiding this comment.
(I found myself liking the pattern of prefix <entity>_name for clarity. But if we want the change, create_queue, create_topic, create_rule also need to be updated)
There was a problem hiding this comment.
I like and agree with this change, but both because of coming-to-wire for CC and, less-lazily-and-more-professionally, to keep this PR scope constrained, do folks mind if I put that as an issue for our next sprint?
There was a problem hiding this comment.
OOB folks concurred this is fine, issue created for nov milestone.
yunhaoling
reviewed
Oct 1, 2020
yunhaoling
reviewed
Oct 1, 2020
sdk/servicebus/azure-servicebus/azure/servicebus/aio/management/_management_client_async.py
Outdated
Show resolved
Hide resolved
Fix doctype that had old name, make changelog note more precise. Co-authored-by: Adam Ling (MSFT) <adam_ling@outlook.com>
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yunhaoling
approved these changes
Oct 2, 2020
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
iscai-msft
added a commit
that referenced
this pull request
Oct 7, 2020
…into fr-business-cards * 'master' of https://github.com/Azure/azure-sdk-for-python: (71 commits) move the environment prep above the tooling that needs it (#14246) Increment version for appconfiguration releases (#14245) Azure Communication Service - Phone Number Administration (#14237) [text analytics] fix query param in cli call to get endpoint (#14243) Resolve Failing Documentation Build for azure-mgmt-core (#14239) Add code reviewers (#14229) [ServiceBus] make amqp_message properties read-only (#14095) [ServiceBus]remove topic parameter object settability (#14116) app config owner (#12986) [KeyVault] Handle Role Definition UUID Name Internally (#14218) Increment version for storage releases (#14224) Update Key Vault changelogs for October release (#14226) [ServiceBus] CI Test hotfixes (#14195) [text analytics] regen TA with GA autorest (#14215) [Storage][STG74]ChangeLog (#14192) fixes python 2.7 issue with unicode and strings again! (#14216) Feature/storage stg74 (#14175) Update communication pacakges to version b2 (#14209) [KeyVault] Add Status Methods to Query Backup and Restore Operations (#14158) Update buffered sender (#13851) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On request from cross-language SDK leads, disabling these Union types to encourage clarity of what can be passed here, as well as reduce ambiguity from "what object does this act on."