Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EventHubs] combine various connection string parsing logic #16725

Closed
swathipil opened this issue Feb 12, 2021 · 0 comments · Fixed by #18059
Closed

[EventHubs] combine various connection string parsing logic #16725

swathipil opened this issue Feb 12, 2021 · 0 comments · Fixed by #18059
Assignees
@swathipil
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs Messaging Messaging crew
Milestone
[2021] May

Comments

@swathipil
Copy link
Member

similar to : #13683

_connection_string_parser.py holds redundant/duplicate parsing logic, and should be combined with _client_base.py logic for parsing connection strings. Should be very similar to SB PR here: #16464

Doing so will help improve maintainability.
@swathipil swathipil added this to the Backlog milestone Feb 12, 2021
@swathipil swathipil self-assigned this Feb 12, 2021
@swathipil swathipil added the Client This issue points to a problem in the data-plane of the library. label Feb 12, 2021
@yunhaoling yunhaoling modified the milestones: Backlog, [2021] April Mar 11, 2021
@yunhaoling yunhaoling modified the milestones: [2021] April, [2021] May Apr 12, 2021
@lmazuel lmazuel added the Messaging Messaging crew label Apr 12, 2021
@swathipil swathipil mentioned this issue Apr 15, 2021
Merged
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Nov 11, 2021
CodeGen from PR 16725 in Azure/azure-rest-api-specs
cc6200a 
[Hub Generated] Review request for Microsoft.VirtualMachineImages to add version stable/2020-02-14 (Azure#16725)

* update description for build vm size

* finalize str

Co-authored-by: rez1 <rez1@DESKTOP-2UNMLHO.redmond.corp.microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@swathipil swathipil

Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs Messaging Messaging crew
Projects
None yet
Milestone
[2021] May
Development

Successfully merging a pull request may close this issue.

[Event Hubs] combine conn str parsing logic swathipil/azure-sdk-for-python
3 participants
@lmazuel @yunhaoling @swathipil