Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Event Hubs] combine conn str parsing logic #18059

Merged
merged 5 commits into from
Apr 22, 2021
Merged

[Event Hubs] combine conn str parsing logic #18059

merged 5 commits into from
Apr 22, 2021

Conversation

swathipil
Copy link
Member

fixes: #16725

@ghost ghost added the Event Hubs label Apr 15, 2021
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@swathipil swathipil closed this Apr 19, 2021
@swathipil swathipil reopened this Apr 19, 2021
@swathipil
Copy link
Member Author

/check-enforcer evaluate

@swathipil
Copy link
Member Author

/azp run python - eventhub - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@swathipil
Copy link
Member Author

/azp run python - eventhub - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@swathipil
Copy link
Member Author

/azp run python - eventhub - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@swathipil
Copy link
Member Author

/azp run python - eventhub - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@swathipil
Copy link
Member Author

/azp run python - eventhub - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@swathipil
Copy link
Member Author

/azp run python - eventhub - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@swathipil swathipil merged commit 8ac54ee into Azure:master Apr 22, 2021
@swathipil swathipil deleted the swathipil/eh/combine-csp-logic branch April 22, 2021 16:26
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Apr 22, 2021
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
677a76a 
…into azure_purview_catalog

* 'master' of https://github.com/Azure/azure-sdk-for-python: (205 commits)
  update FormField docstring (Azure#18226)
  [Event Hubs] combine conn str parsing logic (Azure#18059)
  [Blob]Edit Test for Single Thread Substream Retry (Azure#18206)
  maintenance changelog config (Azure#18216)
  Privated hierarchy traversal and fixed encryption algorithm (Azure#18212)
  Remove duplicate calls to bypass-local-dns.yml (Azure#18180)
  Patch changelog (Azure#18188)
  enable polling by default (Azure#18184)
  [Communication]: Added identity exception tests (Azure#18191)
  version (Azure#18202)
  [AutoRelease] t2-maintenance-2021-04-20-69227 (Azure#18166)
  Updated identity samples (Azure#18189)
  Sync eng/common directory with azure-sdk-tools for PR 1565 (Azure#18155)
  Clean Up PR Triggers (Azure#18186)
  [Tables] on a 413 throw a RequestEntity Too Large Error (Azure#18181)
  Add environment.yml to unify conda versioning (Azure#18141)
  [Fix]Add retry for streaming download (Azure#18164)
  Sync eng/common directory with azure-sdk-tools for PR 1558 (Azure#18178)
  Stop filtering projects by ci.yml files (Azure#18174)
  [Communication] - SDK - Added contributing file (Azure#18018)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunhaoling yunhaoling yunhaoling approved these changes

@annatisch annatisch Awaiting requested review from annatisch

@rakshith91 rakshith91 Awaiting requested review from rakshith91

Assignees
No one assigned
Labels
Event Hubs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[EventHubs] combine various connection string parsing logic
2 participants
@swathipil @yunhaoling