Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python link verification #12543

Merged
merged 35 commits into from
Jul 24, 2020
Merged

python link verification #12543

merged 35 commits into from
Jul 24, 2020

Conversation

KarishmaGhiya
Copy link
Member

No description provided.

@KarishmaGhiya KarishmaGhiya changed the title python link verification [do not merge] python link verification Jul 14, 2020
@KarishmaGhiya KarishmaGhiya self-assigned this Jul 16, 2020
@KarishmaGhiya KarishmaGhiya added the EngSys This issue is impacting the engineering system. label Jul 16, 2020
@ahsonkhan ahsonkhan mentioned this pull request Jul 17, 2020
Merged
@KarishmaGhiya KarishmaGhiya changed the title [do not merge] python link verification python link verification Jul 22, 2020
@KarishmaGhiya
Copy link
Member Author

/azp run python - storage - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

lmazuel
lmazuel requested changes Jul 22, 2020
View reviewed changes
Copy link
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect change of template

tools/azure-sdk-tools/packaging_tools/templates/README.md Outdated Show resolved Hide resolved
lmazuel
lmazuel previously approved these changes Jul 24, 2020
View reviewed changes
chlowell
chlowell reviewed Jul 24, 2020
View reviewed changes
sdk/keyvault/azure-keyvault-certificates/CHANGELOG.md Outdated Show resolved Hide resolved
sdk/keyvault/azure-keyvault-keys/CHANGELOG.md Outdated Show resolved Hide resolved
sdk/keyvault/azure-keyvault-keys/CHANGELOG.md Outdated Show resolved Hide resolved
sdk/keyvault/azure-keyvault-secrets/CHANGELOG.md Outdated Show resolved Hide resolved
sdk/identity/azure-identity/CHANGELOG.md Outdated Show resolved Hide resolved
sdk/identity/azure-identity/CHANGELOG.md Show resolved Hide resolved
@KarishmaGhiya @chlowell
Update sdk/keyvault/azure-keyvault-certificates/CHANGELOG.md
61715f9 
Co-authored-by: Charles Lowell <chlowe@microsoft.com>
KarishmaGhiya and others added 4 commits July 24, 2020 12:21
@KarishmaGhiya @chlowell
Update sdk/keyvault/azure-keyvault-secrets/CHANGELOG.md
1ab0115 
Co-authored-by: Charles Lowell <chlowe@microsoft.com>
@KarishmaGhiya @chlowell
Update sdk/keyvault/azure-keyvault-keys/CHANGELOG.md
2251b32 
Co-authored-by: Charles Lowell <chlowe@microsoft.com>
@KarishmaGhiya @chlowell
Update sdk/keyvault/azure-keyvault-keys/CHANGELOG.md
aeae61d 
Co-authored-by: Charles Lowell <chlowe@microsoft.com>
@KarishmaGhiya @chlowell
Update sdk/identity/azure-identity/CHANGELOG.md
94e0abd 
Co-authored-by: Charles Lowell <chlowe@microsoft.com>
@KarishmaGhiya @chlowell
Update sdk/keyvault/azure-keyvault-secrets/CHANGELOG.md
3c0d9cb 
Co-authored-by: Charles Lowell <chlowe@microsoft.com>
chlowell
chlowell approved these changes Jul 24, 2020
View reviewed changes
Copy link
Member

@chlowell chlowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identity and Key Vault changes look good to me.

@KarishmaGhiya
Copy link
Member Author

/check-enforcer override

@weshaggard
Copy link
Member

Some pipelines were hitting the github rate limiting issue and aren't real failures, so overriding.

@weshaggard weshaggard merged commit 22be12d into Azure:master Jul 24, 2020
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Jul 29, 2020
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
44af22f 
…into regenerate_keys

* 'master' of https://github.com/Azure/azure-sdk-for-python:
  Add foundations for eng/common restructure (Azure#12725)
  Sync eng/common directory with azure-sdk-tools repository (Azure#12730)
  fix flaky test (Azure#12721)
  python link verification (Azure#12543)
  [ServiceBus] Remove legacy control client (Azure#12644)
  mirror update from MicrosoftDocs/azure-docs-sdk-python#709 (Azure#12691)
  [Service Bus] Rule supports parameters of sql expressions and properties of cor filter with multiple data types (Azure#12580)
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Jul 29, 2020
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
2549e53 
…into regenerate_certs

* 'master' of https://github.com/Azure/azure-sdk-for-python: (45 commits)
  Prevent AttributeError during get_certificate_version (Azure#12747)
  re-apply updates after resetting master (Azure#12771)
  Sync eng/common directory with azure-sdk-tools repository (Azure#12745)
  Enable bandit for servicebus (Azure#12763)
  Skip pypy3 for service bus CI pipeline (Azure#12732)
  Update CODEOWNERS (Azure#12765)
  updated tox file (Azure#11087)
  Updating to match Microsoft recommended template (Azure#11045)
  [text analytics] update version in master (Azure#12749)
  Explicitly stringify message prints in samples per manual doc pass recommendation. (Azure#12709)
  Run only analyse dependency step for aggregate report (Azure#12728)
  VSCodeCredential supports Python 2.7 on Windows (Azure#12731)
  Enable bandit (Azure#12722)
  Move InteractiveCredential to a new module (Azure#12706)
  Add foundations for eng/common restructure (Azure#12725)
  Sync eng/common directory with azure-sdk-tools repository (Azure#12730)
  fix flaky test (Azure#12721)
  python link verification (Azure#12543)
  [ServiceBus] Remove legacy control client (Azure#12644)
  mirror update from MicrosoftDocs/azure-docs-sdk-python#709 (Azure#12691)
  ...
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Jul 29, 2020
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
40ae41c 
…into add_back_pii

* 'master' of https://github.com/Azure/azure-sdk-for-python: (40 commits)
  [text analytics] generate multiapi client, made v3.1-preview.1 default version (Azure#12720)
  Prevent AttributeError during get_certificate_version (Azure#12747)
  re-apply updates after resetting master (Azure#12771)
  Sync eng/common directory with azure-sdk-tools repository (Azure#12745)
  Enable bandit for servicebus (Azure#12763)
  Skip pypy3 for service bus CI pipeline (Azure#12732)
  Update CODEOWNERS (Azure#12765)
  updated tox file (Azure#11087)
  Updating to match Microsoft recommended template (Azure#11045)
  [text analytics] update version in master (Azure#12749)
  Explicitly stringify message prints in samples per manual doc pass recommendation. (Azure#12709)
  Run only analyse dependency step for aggregate report (Azure#12728)
  VSCodeCredential supports Python 2.7 on Windows (Azure#12731)
  Enable bandit (Azure#12722)
  Move InteractiveCredential to a new module (Azure#12706)
  Add foundations for eng/common restructure (Azure#12725)
  Sync eng/common directory with azure-sdk-tools repository (Azure#12730)
  fix flaky test (Azure#12721)
  python link verification (Azure#12543)
  [ServiceBus] Remove legacy control client (Azure#12644)
  ...
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Jan 28, 2021
CodeGen from PR 12543 in Azure/azure-rest-api-specs
2c0978b 
remove track1 config in storage, keyvault, compute, network, monitor (Azure#12543)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Jan 28, 2021
CodeGen from PR 12543 in Azure/azure-rest-api-specs
700e5e3 
remove track1 config in storage, keyvault, compute, network, monitor (Azure#12543)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Jan 28, 2021
CodeGen from PR 12543 in Azure/azure-rest-api-specs
6ea4162 
remove track1 config in storage, keyvault, compute, network, monitor (Azure#12543)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Jan 28, 2021
CodeGen from PR 12543 in Azure/azure-rest-api-specs
0d1034e 
remove track1 config in storage, keyvault, compute, network, monitor (Azure#12543)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristapratico kristapratico kristapratico left review comments

@chlowell chlowell chlowell approved these changes

@weshaggard weshaggard weshaggard approved these changes

@lmazuel lmazuel lmazuel approved these changes

@rakshith91 rakshith91 rakshith91 left review comments

@danieljurek danieljurek Awaiting requested review from danieljurek

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

@mayurid mayurid Awaiting requested review from mayurid

@zikalino zikalino Awaiting requested review from zikalino

@schaabs schaabs Awaiting requested review from schaabs

@xiangyan99 xiangyan99 Awaiting requested review from xiangyan99

@amishra-dev amishra-dev Awaiting requested review from amishra-dev

@annatisch annatisch Awaiting requested review from annatisch

@aim-for-better aim-for-better Awaiting requested review from aim-for-better

@idear1203 idear1203 Awaiting requested review from idear1203

@kalyanaj kalyanaj Awaiting requested review from kalyanaj

@southpolesteve southpolesteve Awaiting requested review from southpolesteve

@xingwu1 xingwu1 Awaiting requested review from xingwu1

@zfoster zfoster Awaiting requested review from zfoster

Assignees

@KarishmaGhiya KarishmaGhiya

Labels
EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@KarishmaGhiya @weshaggard @lmazuel @chlowell @rakshith91 @kristapratico