Resolve Failing Documentation Build for azure-mgmt-core #14239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scbedd
requested review from
danieljurek,
mitchdenny,
weshaggard,
amishra-dev,
annatisch,
changlong-liu,
johanste,
jsntcy,
kasobol-msft,
lmazuel,
msyyc,
rakshith91,
tasherif-msft,
xiafu-msft,
xiangyan99 and
zezha-msft
as code owners
scbedd
force-pushed
the
feature/resolve-remaining-failing-builds
branch
from
f1ffd67 to
8c64001
Compare
…H the wheel versions. nightly should be expecting azure-storage-blob==12.3.7a
scbedd
removed request for
danieljurek,
annatisch,
weshaggard,
amishra-dev,
rakshith91,
xiangyan99,
johanste and
jsntcy
scbedd
requested review from
praveenkuttappan
and removed request for
zezha-msft,
xiafu-msft,
changlong-liu,
kasobol-msft,
tasherif-msft and
msyyc
…at will be installed from the wheel directory
|
Hey @praveenkuttappan really 'preciate the signoff. I just cleared it because I caught an issue. When we install the version from the wheel directory, the version will be We get the |
praveenkuttappan
approved these changes
Oct 5, 2020
iscai-msft
added a commit
that referenced
this pull request
Oct 7, 2020
…into fr-business-cards * 'master' of https://github.com/Azure/azure-sdk-for-python: (71 commits) move the environment prep above the tooling that needs it (#14246) Increment version for appconfiguration releases (#14245) Azure Communication Service - Phone Number Administration (#14237) [text analytics] fix query param in cli call to get endpoint (#14243) Resolve Failing Documentation Build for azure-mgmt-core (#14239) Add code reviewers (#14229) [ServiceBus] make amqp_message properties read-only (#14095) [ServiceBus]remove topic parameter object settability (#14116) app config owner (#12986) [KeyVault] Handle Role Definition UUID Name Internally (#14218) Increment version for storage releases (#14224) Update Key Vault changelogs for October release (#14226) [ServiceBus] CI Test hotfixes (#14195) [text analytics] regen TA with GA autorest (#14215) [Storage][STG74]ChangeLog (#14192) fixes python 2.7 issue with unicode and strings again! (#14216) Feature/storage stg74 (#14175) Update communication pacakges to version b2 (#14209) [KeyVault] Add Status Methods to Query Backup and Restore Operations (#14158) Update buffered sender (#13851) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The install_requires wasn't properly replacing to
a<buildid>. It was looking for.devstill.This means that it's not properly installing the azure-core-1.8.2aXX version that hasn't released yet. This update ensures that
azure-mgmt-corewill require a1.8.2aso it'll match the unreleased version of the package.@praveenkuttappan take a look? This will turn our build green, but isn't repeatable like the
.devone was. We should take another look at this and dynamically recreate therec, which will allow us to get away from the string-replacement that is currently happening.