[formrecognizer] add locale to receipt samples #14292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iscai-msft
reviewed
Oct 6, 2020
| @@ -90,10 +90,14 @@ def begin_recognize_receipts(self, receipt, **kwargs): | |||
| :keyword int polling_interval: Waiting time between two polls for LRO operations | |||
| if no Retry-After header is present. Defaults to 5 seconds. | |||
| :keyword str continuation_token: A continuation token to restart a poller from a saved state. | |||
| :keyword str locale: Locale of the receipt. Supported locales include: en-AU, en-CA, en-GB, en-IN, | |||
There was a problem hiding this comment.
nit: can we include the default at the beginning, i.e. Default is en-US, other supported locales include..., this way the default is more easy to read?
| @@ -46,7 +46,7 @@ async def recognize_receipts(self): | |||
| ) as form_recognizer_client: | |||
|
|
|||
| with open(path_to_sample_forms, "rb") as f: | |||
| poller = await form_recognizer_client.begin_recognize_receipts(receipt=f) | |||
| poller = await form_recognizer_client.begin_recognize_receipts(receipt=f, locale="en-US") | |||
There was a problem hiding this comment.
also sorry for trampling on the reason of this PR, but is it necessary to include locale in the samples, esp since it's a kwarg and we're passing in the default value?
There was a problem hiding this comment.
Wanted to show how to pass it at least somewhere so added to one of the samples. I don't think it would make sense to use a non-english example, so thought explicitly passing it here wouldn't hurt.
iscai-msft
approved these changes
Oct 6, 2020
iscai-msft
added a commit
that referenced
this pull request
Oct 7, 2020
…into fr-business-cards * 'master' of https://github.com/Azure/azure-sdk-for-python: (21 commits) Sync eng/common directory with azure-sdk-tools for PR 1052 (#14232) [Storage][FileShare]Regenerate code for file tier (#14302) [ServiceBus] ServiceBus Operation Timeout Support (#13854) Increment package version after release of azure_data_tables (#14309) Increment version for textanalytics releases (#14295) [formrecognizer] add locale to receipt samples (#14292) [form recognizer] add sample business cards to test forms (#14303) add back code (#14289) update release date (#14291) Increment version for search releases (#14290) Update Changelog for communication packages (#14268) Changelog for azure-identity 1.5.0b2 (#14288) [text analytics] changelog add release date, fix wording (#14286) Computer Vision 0.7.0 release (#14269) SetDevVersion Is Triggering Oddly (#14261) Revise get_token docs (#14263) Increment version for servicebus releases (#14265) redo the dep update (#14264) [EventGrid] Prepare for beta3 release (#14262) [ServiceBus] b7 release doc fixes (#14247) ...
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Nov 5, 2020
…into new_polling * 'master' of https://github.com/Azure/azure-sdk-for-python: (68 commits) Pin Deps in "TestOldest" Regression (Azure#14316) Sync eng/common directory with azure-sdk-tools for PR 1052 (Azure#14232) [Storage][FileShare]Regenerate code for file tier (Azure#14302) [ServiceBus] ServiceBus Operation Timeout Support (Azure#13854) Increment package version after release of azure_data_tables (Azure#14309) Increment version for textanalytics releases (Azure#14295) [formrecognizer] add locale to receipt samples (Azure#14292) [form recognizer] add sample business cards to test forms (Azure#14303) add back code (Azure#14289) update release date (Azure#14291) Increment version for search releases (Azure#14290) Update Changelog for communication packages (Azure#14268) Changelog for azure-identity 1.5.0b2 (Azure#14288) [text analytics] changelog add release date, fix wording (Azure#14286) Computer Vision 0.7.0 release (Azure#14269) SetDevVersion Is Triggering Oddly (Azure#14261) Revise get_token docs (Azure#14263) Increment version for servicebus releases (Azure#14265) redo the dep update (Azure#14264) [EventGrid] Prepare for beta3 release (Azure#14262) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.