-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storage][FileShare]Regenerate code for file tier #14302
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiafu-msft
requested review from
amishra-dev,
annatisch,
kasobol-msft,
rakshith91,
tasherif-msft and
zezha-msft
as code owners
October 6, 2020 20:49
tasherif-msft
previously approved these changes
Oct 6, 2020
@@ -868,8 +877,8 @@ def get_permission(self, file_permission_key, timeout=None, cls=None, **kwargs): | |||
return deserialized | |||
get_permission.metadata = {'url': '/{shareName}'} | |||
|
|||
def set_quota(self, timeout=None, quota=None, lease_access_conditions=None, cls=None, **kwargs): | |||
"""Sets quota for the specified share. | |||
def set_properties(self, timeout=None, quota=None, access_tier=None, lease_access_conditions=None, cls=None, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for changing the method :)
tasherif-msft
approved these changes
Oct 7, 2020
iscai-msft
added a commit
that referenced
this pull request
Oct 7, 2020
…into fr-business-cards * 'master' of https://github.com/Azure/azure-sdk-for-python: (21 commits) Sync eng/common directory with azure-sdk-tools for PR 1052 (#14232) [Storage][FileShare]Regenerate code for file tier (#14302) [ServiceBus] ServiceBus Operation Timeout Support (#13854) Increment package version after release of azure_data_tables (#14309) Increment version for textanalytics releases (#14295) [formrecognizer] add locale to receipt samples (#14292) [form recognizer] add sample business cards to test forms (#14303) add back code (#14289) update release date (#14291) Increment version for search releases (#14290) Update Changelog for communication packages (#14268) Changelog for azure-identity 1.5.0b2 (#14288) [text analytics] changelog add release date, fix wording (#14286) Computer Vision 0.7.0 release (#14269) SetDevVersion Is Triggering Oddly (#14261) Revise get_token docs (#14263) Increment version for servicebus releases (#14265) redo the dep update (#14264) [EventGrid] Prepare for beta3 release (#14262) [ServiceBus] b7 release doc fixes (#14247) ...
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Nov 5, 2020
…into new_polling * 'master' of https://github.com/Azure/azure-sdk-for-python: (68 commits) Pin Deps in "TestOldest" Regression (Azure#14316) Sync eng/common directory with azure-sdk-tools for PR 1052 (Azure#14232) [Storage][FileShare]Regenerate code for file tier (Azure#14302) [ServiceBus] ServiceBus Operation Timeout Support (Azure#13854) Increment package version after release of azure_data_tables (Azure#14309) Increment version for textanalytics releases (Azure#14295) [formrecognizer] add locale to receipt samples (Azure#14292) [form recognizer] add sample business cards to test forms (Azure#14303) add back code (Azure#14289) update release date (Azure#14291) Increment version for search releases (Azure#14290) Update Changelog for communication packages (Azure#14268) Changelog for azure-identity 1.5.0b2 (Azure#14288) [text analytics] changelog add release date, fix wording (Azure#14286) Computer Vision 0.7.0 release (Azure#14269) SetDevVersion Is Triggering Oddly (Azure#14261) Revise get_token docs (Azure#14263) Increment version for servicebus releases (Azure#14265) redo the dep update (Azure#14264) [EventGrid] Prepare for beta3 release (Azure#14262) ...
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-python
that referenced
this pull request
May 19, 2021
Dev kubernetesconfiguration microsoft.kubernetes configuration 2021 05 01 preview (Azure#14302) * Adds base for updating Microsoft.KubernetesConfiguration from version preview/2020-07-01-preview to version 2021-05-01-preview * Updates readme * Updates API version in new specs and examples * Add Extensions Async API and other fixes (Azure#13709) * Add Extensions Async API and other fixes * Re-add missed out changes * Fix validation errors, remove UpdateExtension.json * Update Readme.md * Add back files removed accidentally * Revert accidental changes & fix readme.md * Remove SourceControlConfig from this api version * Fix Readme.md error for go package * Fix Go readme issues * Fix Go readme issues - revert accidental change * Fix Go readme issues * Add kubernetesconfiguration GA version to this version Tag for SDK * Fix Operations api descriptions * Fix spelling mistakes * Update ApiVersionParameter reference in kubernetesconfiguration * Fix review suggestions * Add SourceControlConfiguration resourceType to this api-version * Updated readme files for the added SourceControlConfiguration resource type * Fix readme files to revert to previous + additions for new api-version * Consolidated common definitions to avoid duplication errors * Rename definitions folder - fix Avocado error * Consolidated common definitions reference * Fix definitions.json * Fix go readme * Revert "Add Extensions Async API and other fixes (Azure#13709)" (Azure#13972) This reverts commit b78af6ebfe1391f2c73bc39da3c20c159806b1a0. * Dev kubernetesconfiguration microsoft.kubernetes configuration 2021 05 01 preview (Azure#13992) * Add Extensions Async API and other fixes * Re-add missed out changes * Fix validation errors, remove UpdateExtension.json * Update Readme.md * Add back files removed accidentally * Revert accidental changes & fix readme.md * Remove SourceControlConfig from this api version * Fix Readme.md error for go package * Fix Go readme issues * Fix Go readme issues - revert accidental change * Fix Go readme issues * Add kubernetesconfiguration GA version to this version Tag for SDK * Fix Operations api descriptions * Fix spelling mistakes * Update ApiVersionParameter reference in kubernetesconfiguration * Fix review suggestions * Add SourceControlConfiguration resourceType to this api-version * Updated readme files for the added SourceControlConfiguration resource type * Fix readme files to revert to previous + additions for new api-version * Consolidated common definitions to avoid duplication errors * Rename definitions folder - fix Avocado error * Consolidated common definitions reference * Fix definitions.json * Fix go readme * Remove extensions resource in the route of ListAsyncOperations at Cluster scope * Remove extension parameter in the spec * Remove extension parameter from route of ListAsycOperations * Add Origin property to Available Operations response body * Make Identity property nullable * Add Get, List Extension Types (Azure#13562) * Add Get, List Extension Types * style check fixes * - update spec - rename and update example files - fix validation errors * fix examples * - update readme.md - generate example files with oav - try to fix some new validation errors * more validation fixes * add ExtensionTypeVersion_List * - update readme for SDKs - update examples * fix typo and linting * rename ExtensionTypeVersions_List * - address comments - update list extension versions based on location * fix list versions route * fix tag and unused parameters in spec file * fix autorest validatoin errors * udpate readme * update readme * try to fix sdk validation warnings * - prettier fix - revert changes to types.json * fix pageable missing itemName Co-authored-by: Carlo Cardella <carloc@microsoft.com> Co-authored-by: chunyu3 <chunyu@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.