Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Communication]: Fix replace keys for nested json #16557

Merged
merged 1 commit into from
Feb 5, 2021
Merged

[Communication]: Fix replace keys for nested json #16557

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions sdk/communication/azure-communication-identity/tests/_shared/testcase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,12 @@ def process_response(self, response):

def _replace_keys(self, body):
def _replace_recursively(dictionary):
if type(dictionary) != dict:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wonder if somehow using type instead of isinstance did something

return
for key in dictionary:
value = dictionary[key]
if key in self._keys:
dictionary[key] = self._replacement
else:
_replace_recursively(dictionary[key])
elif isinstance(value, dict):
_replace_recursively(value)

import json
try:
Expand Down