[Communication]: Fix replace keys for nested json #16557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run python - communication - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lsundaralingam
requested review from
ankitarorabit,
memontic-ms,
turalf and
a team
as code owners
beltr0n
reviewed
Feb 5, 2021
| @@ -51,13 +51,12 @@ def process_response(self, response): | |||
|
|
|||
| def _replace_keys(self, body): | |||
| def _replace_recursively(dictionary): | |||
| if type(dictionary) != dict: | |||
There was a problem hiding this comment.
i wonder if somehow using type instead of isinstance did something
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Feb 5, 2021
…into new_polling * 'master' of https://github.com/Azure/azure-sdk-for-python: (250 commits) Converting to pure unit tests (Azure#16499) Fix replace keys for nested json (Azure#16557) update release date (Azure#16543) Feature/communication chat preview3 new model (Azure#16561) [text analytics] Exposed the length property in classes impacted by `string_index_type` (Azure#16538) [textanalytics] add :keyword: to docstrings for TextDocumentInput and DetectLanguageInput (Azure#16542) [SB] combine conn str parser logic in base handler and _common (Azure#16464) [text analytics] add analyze readme bullet point (Azure#16552) resolve issues with failing search documents on mindependency checks (Azure#16553) [text analytics] analyze changes (Azure#16418) [Core] Added enum meta class (Azure#16316) Adding missing supported fields to invoice sample (Azure#16547) Update EventHub ci.yml to skip unsupported pypy3 (Azure#16545) patching the publishing of artifacts only on successful run (Azure#16539) need to bump msrest up one (Azure#16544) [EventHub&ServiceBUs] Update readme pointing to uamqp installation guidance (added alpine installation) (Azure#16515) add dotenv as a dep for azure-sdk-tools (Azure#16532) skip prebuilt from_url tests for now (Azure#16534) Latest/Minimum filter retrieved packages by pyVersion compatibility (Azure#16510) CertificateCredential accepts certs as bytes (Azure#16410) ...
lsundaralingam
changed the title
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-python
that referenced
this pull request
Nov 12, 2021
[Hub Generated] Review request for Microsoft.LabServices to add version preview/2021-11-15-preview (Azure#16557) * Adds base for updating Microsoft.LabServices from version preview/2021-10-01-preview to version 2021-11-15-preview * Updates readme * Updates API version in new specs and examples * add locations/usages resource * fix usages id constraint to allow for empty string * add skus resource and examples * add integer format, fix quantity type from string to number * fix readonly property per arm feedback Co-authored-by: Nick Depinet <ndepinet@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.