Correct expiration epoch time #18026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leoaqr
requested review from
ankitarorabit,
memontic-ms,
turalf and
a team
as code owners
ghost
added
the
sdk/communication/azure-communication-chat/azure/communication/chat/_shared/utils.py
Outdated
Show resolved
Hide resolved
sdk/communication/azure-communication-chat/azure/communication/chat/_shared/utils.py
Outdated
Show resolved
Hide resolved
sdk/communication/azure-communication-chat/azure/communication/chat/_shared/utils.py
Show resolved
Hide resolved
|
Could you also add unit tests to cover this? Also, should this change be propagated across the other packages as well? |
Leoaqr
force-pushed
the
leo/correctEpochTime
branch
from
c56ea6b
to
31ca7a4
Compare
|
Agree with @sarkar-rajarshi - this should have some unit tests including both naïve and TZ-aware inputs. With validation: |
added 3 commits
April 16, 2021 05:03
Leoaqr
force-pushed
the
leo/correctEpochTime
branch
from
872e34b
to
f0c2d59
Compare
annatisch
reviewed
Apr 16, 2021
sdk/communication/azure-communication-chat/azure/communication/chat/_shared/utils.py
Show resolved
Hide resolved
|
/azp run python - communication - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
annatisch
approved these changes
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.