Sync the _shared folder for Communication

[petrsvihlik]

I found out that the _shared folder (sdk\communication\azure-communication-<package>\azure\communication\<package>\_shared) is not in sync across the Communication packages (SMS, PhoneNumbers, Chat, Identity, and NetworkTraversal).

The differences made our _shared folders split into the following branches:

• Branch A:
  • PhoneNumbers
  • SMS
  • Chat (1 difference compared to SMS and PhoneNumbers)
• Branch B:
  • Identity
  • NetworkTraversal (1 little change related to linting compared to Identity)

@jbeauregardb attempted to unify the folders in the past (#17985) but Identity was not updated (and I think NetworkTraversal was introduced later and that's how Branch B was created).

The second important milestone was #18026 that removed replace(tzinfo=TZ_UTC) from creation of the current timestamp.

• There was a comment saying that we "should have some unit tests including both naïve and TZ-aware inputs." which wasn't processed. I'll probably add some tests for that.
• Also, it'd probably make sense to be able to handle both the naïve and TZ-aware inputs in the code to be compatible with the older versions of Python. E.g. similarly to what they do in Azure.Core. I'll take a closer look at it and suggest a change.

This PR is an attempt to cherry pick the right changes and unify the folders.
I'm including all past contributors and owners of concerned packages as reviewers.

[azure-sdk]

API changes have been detected in azure-communication-chat. You can review API changes here

API changes

- # Package is parsed using api-stub-generator(version:0.2.4)
+ # Package is parsed using api-stub-generator(version:0.2.5)
-             metadata: Dict = None, 
-             sender_display_name: Union[str, NoneType] = None, 
-             content: str = None, 
+             content = ..., 
-             content = ..., 
-             metadata: Dict = None, 

[azure-sdk]

API changes have been detected in azure-communication-sms. You can review API changes here

API changes

- # Package is parsed using api-stub-generator(version:0.2.4)
+ # Package is parsed using api-stub-generator(version:0.2.5)
-         ) -> SmsClient
+         ) ->  admonitio
-         ) -> SmsClient
+         ) ->  admonitio

[azure-sdk]

API changes have been detected in azure-communication-phonenumbers. You can review API changes here

API changes

- # Package is parsed using api-stub-generator(version:0.2.4)
+ # Package is parsed using api-stub-generator(version:0.2.5)

[petrsvihlik]

Since we don't expose the value of datetime.utcnow() anywhere outside the get_current_utc_as_int(), I think we can keep it without the .replace(tzinfo=TZ_UTC). I added a test for UTC without a timezone specified to make sure the _convert_datetime_to_utc_int works in all cases.
I ran the tests on both Python 2.x and 3.x and all seems to be passing.

[juancamilor]

@LuChen-Microsoft FYI

[petrsvihlik]

Added a new line to CODEOWNERS to enforce the reviews for the _shared folders bbaff76 and prevent similar situation from happening again.

[petrsvihlik]

Also, it'd probably make sense to be able to handle both the naïve and TZ-aware inputs in the code to be compatible with the older versions of Python. E.g. similarly to what they do in Azure.Core. I'll take a closer look at it and suggest a change.

It seems that TZ_UTC covers this well.

I also did some extensive testing and discovered that deserialization of the expires_on doesn't work correctly - there was a 1hr difference between the string payload and the deserialized int. So in 5371ea7, I replaced this:

return AccessToken(token, _convert_datetime_to_utc_int(datetime.fromtimestamp(payload['exp']).replace(tzinfo=TZ_UTC)))

with:

return AccessToken(token, _convert_datetime_to_utc_int(datetime.fromtimestamp(payload['exp'], TZ_UTC)))

Now it should be all good to review.

@AriZavala2 @LuChen-Microsoft @RoyHerrod @jbeauregardb can you please verify the changes?

[petrsvihlik]

Confirmed with @annatisch that this change is legit. Explanation:

token types follow a specific protocol, so the method signatures needed to be updated to be consistent.

This PR unifies the code to follow the change made in the Chat lib.

[annatisch]

/azp run python - azure-communication-chat - tests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[annatisch]

/azp run python - azure-communication-phonenumbers - tests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[annatisch]

/azp run python - azure-communication-sms - tests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[annatisch]

/azp run python - azure-communication-identity - tests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[annatisch]

/azp run python - azure-communication-networktraversal - tests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).