[Tables] Client and pipeline refactor #18045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
sdk/tables/azure-data-tables/azure/data/tables/_table_service_client.py
Outdated
Show resolved
Hide resolved
sdk/tables/azure-data-tables/azure/data/tables/aio/_base_client_async.py
Show resolved
Hide resolved
Comment on lines
56
to
57
| async def __aenter__(self): | ||
| await self._client.__aenter__() |
There was a problem hiding this comment.
Because this inherits from the sync base client, will there be a weird behavior where you can use an async client as a sync context manager:
with TableClient(...) as tc:
await tc.get_entity(...)There was a problem hiding this comment.
Nope - the async client does not inherit from the sync base client. For exactly this reason. It only inherits from the AccountHostsMixin
sdk/tables/azure-data-tables/azure/data/tables/aio/_table_service_client_async.py
Show resolved
Hide resolved
|
/azp run python - tables - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Comment on lines
+55
to
+68
| _SUPPORTED_API_VERSIONS = ["2019-02-02", "2019-07-07"] | ||
|
|
||
|
|
||
| def get_api_version(kwargs, default): | ||
| # type: (Dict[str, Any], str) -> str | ||
| api_version = kwargs.pop("api_version", None) | ||
| if api_version and api_version not in _SUPPORTED_API_VERSIONS: | ||
| versions = "\n".join(_SUPPORTED_API_VERSIONS) | ||
| raise ValueError( | ||
| "Unsupported API version '{}'. Please select from:\n{}".format( | ||
| api_version, versions | ||
| ) | ||
| ) | ||
| return api_version or default |
There was a problem hiding this comment.
Do we support multiple API versions now? Are there major differences between the two?
There was a problem hiding this comment.
One of the guidelines is that all SDKs support an API version parameter. So that part is mandatory. However in next stand up we should confirm what all languages are setting as the default API version.
Co-authored-by: Sean Kane <68240067+seankane-msft@users.noreply.github.com>
Co-authored-by: Sean Kane <68240067+seankane-msft@users.noreply.github.com>
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-python
that referenced
this pull request
Mar 22, 2022
New API version to Microsoft.Security 2021-11-01 (Azure#18045) * Adds base for updating Microsoft.Security from version stable/2021-01-01 to version 2021-11-01 * Updates readme * Updates API version in new specs and examples * New API version to Microsoft.Security pick 5459ef18a7 New API version to Microsoft.Security pick c8462f9c60 [Microsoft.Security alerts] fix examples/Alerts/SimulateAlerts_example.json pick b5f4550d6b [Microsoft.Security alerts] add missing API to readme.md * [Microsoft.Security alerts] fix examples/Alerts/SimulateAlerts_example.json * [Microsoft.Security alerts] add missing API to readme.md * Fix readme.md file after rebase * Removing "x-ms-long-running-operation" header * Setting target package back to package-composite-v3 * Updating securityContacts.json to the latest version * Reverting securityContacts.json to equal main, should be updated by the relevant team Co-authored-by: Nitsan Bracha <nibracha@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.