Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tables] Client and pipeline refactor #18045

Merged
merged 16 commits into from
Apr 16, 2021
Merged

[Tables] Client and pipeline refactor #18045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
d054269
Removed unused encryption
annatisch Apr 13, 2021
2a357fe
Started refactor
annatisch Apr 13, 2021
f8a2dd6
More refactoring of clients
annatisch Apr 13, 2021
2088afa
Updated async retry policy
annatisch Apr 14, 2021
0166fe7
Some test and sample fixes
annatisch Apr 14, 2021
f431969
pylint
annatisch Apr 14, 2021
0079591
Fixed acl tests
annatisch Apr 14, 2021
8230bc6
Skip retry for now
annatisch Apr 14, 2021
28d281e
Fix pipeline sharing
annatisch Apr 14, 2021
b43e633
Fixed retry tests
annatisch Apr 15, 2021
3b1cacc
Pylint
annatisch Apr 15, 2021
a984206
Update sdk/tables/azure-data-tables/tests/test_retry.py
annatisch Apr 16, 2021
98dcd71
Update sdk/tables/azure-data-tables/tests/test_retry_async.py
annatisch Apr 16, 2021
d570fde
Updated changelog
annatisch Apr 16, 2021
d476036
Merge branch 'tables-batch' of https://github.com/annatisch/azure-sdk…
annatisch Apr 16, 2021
1983f86
Fix CI
annatisch Apr 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion sdk/tables/azure-data-tables/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,16 @@
# Release History

## 12.0.0b7 (Unreleased)
* Fixed issue with Cosmos merge operations
**Breaking**
* Removed explicit `LinearRetry` and `ExponentialRetry` in favor of keyword parameter.
* Renamed `filter` parameter in query APIs to `query_filter`.
* The `location_mode` attribute on clients is now read-only. This has been added as a keyword parameter to the constructor.

**Fixes**
* Fixed issue with Cosmos merge operations.
* Removed legacy Storage policies from pipeline.
* Removed unused legacy client-side encryption attributes from client classes.
* Fixed sharing of pipeline between service/table clients.

## 12.0.0b6 (2021-04-06)
* Updated deserialization of datetime fields in entities to support preservation of the service format with additional decimal place.
Expand Down
2 changes: 1 addition & 1 deletion sdk/tables/azure-data-tables/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ Querying entities in the table:
from azure.data.tables import TableClient
my_filter = "PartitionKey eq 'RedMarker'"
table_client = TableClient.from_connection_string(conn_str="<connection_string>", table_name="mytable")
entities = table_client.query_entities(filter=my_filter)
entities = table_client.query_entities(my_filter)
for entity in entities:
for key in entity.keys():
print("Key: {}, Value: {}".format(key, entity[key]))
Expand Down
3 changes: 0 additions & 3 deletions sdk/tables/azure-data-tables/azure/data/tables/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
BatchTransactionResult,
BatchErrorException,
)
from ._policies import ExponentialRetry, LinearRetry
from ._version import VERSION
from ._deserialize import TableErrorCode
from ._table_batch import TableBatchOperations
Expand All @@ -35,8 +34,6 @@
__all__ = [
"TableClient",
"TableServiceClient",
"ExponentialRetry",
"LinearRetry",
"LocationMode",
"ResourceTypes",
"AccountSasPermissions",
Expand Down
9 changes: 0 additions & 9 deletions sdk/tables/azure-data-tables/azure/data/tables/_authentication.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@
except ImportError:
pass

from ._constants import DEV_ACCOUNT_NAME, DEV_ACCOUNT_SECONDARY_NAME

from ._common_conversion import (
_sign_string,
)
Expand Down Expand Up @@ -87,13 +85,6 @@ def _get_canonicalized_resource(self, request):
return "/" + self.account_name + str(uri_path)
except TypeError:
pass

# for emulator, use the DEV_ACCOUNT_NAME instead of DEV_ACCOUNT_SECONDARY_NAME
# as this is how the emulator works
if self.is_emulated and uri_path.find(DEV_ACCOUNT_SECONDARY_NAME) == 1:
# only replace the first instance
uri_path = uri_path.replace(DEV_ACCOUNT_SECONDARY_NAME, DEV_ACCOUNT_NAME, 1)

return "/" + self.account_name + uri_path

def _get_canonicalized_headers(self, request):
Expand Down
Loading