Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve docs and samples for glossaries and custom models #18587

Merged
merged 26 commits into from
Aug 24, 2021
Merged

improve docs and samples for glossaries and custom models #18587

merged 26 commits into from
Aug 24, 2021

Conversation

mshaban-msft
Copy link
Contributor

solves #17918

@mshaban-msft mshaban-msft force-pushed the 17918/improve_docs_for_custom_models_and_glossaries branch from bf6ddf2 to 31badc0 Compare June 28, 2021 14:10
@mshaban-msft
Copy link
Contributor Author

@kristapratico
i added some sample file for glossaries .tsv (same as .tab)
you can find the PR here
added some random medical word translation (to be consistent with the readme)
is it better if i asked the service team to provide some sample glossary files?

@kristapratico
Copy link
Member

@kristapratico
i added some sample file for glossaries .tsv (same as .tab)
you can find the PR here
added some random medical word translation (to be consistent with the readme)
is it better if i asked the service team to provide some sample glossary files?

The glossary sample file we provide should reflect translation changes if somebody tries to use it. If you run translation using the glossary file you created, does the output show that the glossary was used? If so, I think we should use your sample. If not, then let's check with the service team to see if they have any good examples.

@check-enforcer
Copy link

check-enforcer bot commented Jul 7, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@mshaban-msft mshaban-msft force-pushed the 17918/improve_docs_for_custom_models_and_glossaries branch from 8f57afb to da13ccf Compare July 8, 2021 12:46
MIDDLEEAST\v-moshaban added 20 commits August 23, 2021 19:46
@mshaban-msft mshaban-msft force-pushed the 17918/improve_docs_for_custom_models_and_glossaries branch from da13ccf to ae14c79 Compare August 23, 2021 17:47
kristapratico
kristapratico approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@kristapratico kristapratico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kristapratico kristapratico merged commit 986302f into Azure:main Aug 24, 2021
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Aug 25, 2021
@iscai-msft
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-python …
c71823c 
…into switch_to_rest

* 'main' of https://github.com/Azure/azure-sdk-for-python:
  Address API view issues (Azure#20407)
  skip custom translation model samples (Azure#20414)
  [purview account] first release for azure-purview-account (Azure#20335)
  improve docs and samples for glossaries and custom models (Azure#18587)
  Sync eng/common directory with azure-sdk-tools for PR 1918 (Azure#20342)
  Update .docsettings.yml (Azure#20402)
  improve begin_translation docstring (Azure#20401)
  [translation] fix poller.details (Azure#20392)
  Chain exceptions from LibsecretPersistence (Azure#20380)
  [AutoRelease] t2-datamigration-2021-08-19-04035 (Azure#20349)
  [AutoRelease] t2-policyinsights-2021-08-23-78735 (Azure#20381)
  [AutoRelease] t2-servicebus-2021-08-19-00756 (Azure#20350)
  [AutoRelease] t2-costmanagement-2021-07-27-84467 (Azure#19949)
  keyvault and storage have a conflict between mindependency and what local azure-identity requires. resolve it (Azure#20391)
  Add Cloud Configuration section to Identity readme (Azure#20373)
  Consistency related changes (Azure#20385)
iscai-msft added a commit that referenced this pull request Aug 25, 2021
@iscai-msft
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-python …
f2c2b0d 
…into header_tuples

* 'main' of https://github.com/Azure/azure-sdk-for-python: (23 commits)
  make core tests offline (#19986)
  [translation] naming alignment (#20406)
  Address API view issues (#20407)
  skip custom translation model samples (#20414)
  [purview account] first release for azure-purview-account (#20335)
  improve docs and samples for glossaries and custom models (#18587)
  Sync eng/common directory with azure-sdk-tools for PR 1918 (#20342)
  Update .docsettings.yml (#20402)
  improve begin_translation docstring (#20401)
  [translation] fix poller.details (#20392)
  Chain exceptions from LibsecretPersistence (#20380)
  [AutoRelease] t2-datamigration-2021-08-19-04035 (#20349)
  [AutoRelease] t2-policyinsights-2021-08-23-78735 (#20381)
  [AutoRelease] t2-servicebus-2021-08-19-00756 (#20350)
  [AutoRelease] t2-costmanagement-2021-07-27-84467 (#19949)
  keyvault and storage have a conflict between mindependency and what local azure-identity requires. resolve it (#20391)
  Add Cloud Configuration section to Identity readme (#20373)
  Consistency related changes (#20385)
  Document Pod Identity's special use of client_id (#20377)
  [rest] use azure json encoder for json input bodies (#20361)
  ...
hildurhodd pushed a commit to hildurhodd/azure-sdk-for-python that referenced this pull request Aug 26, 2021
@hildurhodd
improve docs and samples for glossaries and custom models (Azure#18587)
5702a23 
* update the readme

* update readme file

* added custom translation samples

* fix 'no-locale' thing in links

* update glossary docs

* update glossaries

* link to sample glossaries instead of writing code in readme

* update custom model sample linking

* remove relative linking in readme

* make subheadings in bold text to be more readable

* conform with 'Document Translation' naming

* disambiguate container sas url

* capitaliz Azure name

* remove misplaced period

* update samples -> custom model

* update async sample -> custom model

* remove localization from url

* update readme with new file types for glossaries

* adding sample glossaries -> xlf

* white space

* use simplified single input method

* update 'job' terminology

* update azure-core naming

* update glossary blob file reference name

* link to supported glossaries table

* remove locale from url
hildurhodd pushed a commit to hildurhodd/azure-sdk-for-python that referenced this pull request Aug 26, 2021
@hildurhodd
improve docs and samples for glossaries and custom models (Azure#18587)
6b90a9a 
* update the readme

* update readme file

* added custom translation samples

* fix 'no-locale' thing in links

* update glossary docs

* update glossaries

* link to sample glossaries instead of writing code in readme

* update custom model sample linking

* remove relative linking in readme

* make subheadings in bold text to be more readable

* conform with 'Document Translation' naming

* disambiguate container sas url

* capitaliz Azure name

* remove misplaced period

* update samples -> custom model

* update async sample -> custom model

* remove localization from url

* update readme with new file types for glossaries

* adding sample glossaries -> xlf

* white space

* use simplified single input method

* update 'job' terminology

* update azure-core naming

* update glossary blob file reference name

* link to supported glossaries table

* remove locale from url
hildurhodd pushed a commit to hildurhodd/azure-sdk-for-python that referenced this pull request Aug 30, 2021
@hildurhodd
improve docs and samples for glossaries and custom models (Azure#18587)
8fb444d 
* update the readme

* update readme file

* added custom translation samples

* fix 'no-locale' thing in links

* update glossary docs

* update glossaries

* link to sample glossaries instead of writing code in readme

* update custom model sample linking

* remove relative linking in readme

* make subheadings in bold text to be more readable

* conform with 'Document Translation' naming

* disambiguate container sas url

* capitaliz Azure name

* remove misplaced period

* update samples -> custom model

* update async sample -> custom model

* remove localization from url

* update readme with new file types for glossaries

* adding sample glossaries -> xlf

* white space

* use simplified single input method

* update 'job' terminology

* update azure-core naming

* update glossary blob file reference name

* link to supported glossaries table

* remove locale from url
msyyc added a commit that referenced this pull request Aug 30, 2021
@hildurhodd @audunn
@iscai-msft @azure-sdk @weshaggard @swathipil @mccoyp @yunhaoling @v-xuto @ckairen @chlowell @scbedd @RAY-316 @BigCat20196 @kristapratico @benbp @msyyc @xiangyan99 @chidozieononiwu @annatisch
t2-Netapp-update-to-2021-06-01 (#20453)
fac427d 
* CodeGen from PR 15691 in Azure/azure-rest-api-specs
[NetAppFiles] fix default in volumeproperties (#15691)

* fix default in volumeproperties

* Update description

* Update description

Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com>

* version,CHANGELOG

* test

* bump node version (#20353)

* Remove old unused update changelog script (#20357)

Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>

* Handle value types for results (#20358)

* Handle value types for results

* update test

* lint

* comprehension

* more precis

* fix test

* [rest] change text from a property to a method (#20290)

* [ServiceBus] update migration guide with message count info (#20360)

#20245

* Update CODEOWNERS (#20366)

* More Renaming in query (#20303)

* More Reanaming in query

* changelog

* commit 2

* some changes

* remove errror

* Update sdk/monitor/azure-monitor-query/azure/monitor/query/_models.py

* Apply suggestions from code review

Co-authored-by: Adam Ling (MSFT) <adam_ling@outlook.com>

* Update sdk/monitor/azure-monitor-query/CHANGELOG.md

Co-authored-by: Adam Ling (MSFT) <adam_ling@outlook.com>

* Fix Monitor opentelemetry exporter readme issues (#19038)

* [Key Vault] Add 7.3-preview support for administration (#20364)

* Update metadata values (#20365)

* Update metadata values

* distributed trace

* oops

* Update sdk/monitor/azure-monitor-query/CHANGELOG.md

* Apply suggestions from code review

* Bug fix for pipeline downloading incorrect package ver (#20294)

* Bug fix: pipeline to download correct package ver

* Update clean version

* Update clean version

* Cleanup

* Cleanup

* Cleanup

* Cleanup

* Comments added

* Testing

* Final-Version

* CertificateCredential supports PKCS12 certs (#16384)

* [rest] use azure json encoder for json input bodies (#20361)

* Document Pod Identity's special use of client_id (#20377)

* Consistency related changes (#20385)

* time stamp

* Rename AggragationType to MetricAggregationType

* Metric Class

* logs batch result

* MetricNamespaceClassification

* LogsTable + LogsTableColumn

* lint

* more lint

* Add Cloud Configuration section to Identity readme (#20373)

* keyvault and storage have a conflict between mindependency and what local azure-identity requires. resolve it (#20391)

* [AutoRelease] t2-costmanagement-2021-07-27-84467 (#19949)

* CodeGen from PR 15291 in Azure/azure-rest-api-specs
Updating Query filter description (#15291)

Co-authored-by: Jorge Chavez Nieto <jochav@microsoft.com>

* version,CHANGELOG

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: Jorge Chavez Nieto <jochav@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

* [AutoRelease] t2-servicebus-2021-08-19-00756 (#20350)

* CodeGen from PR 14749 in Azure/azure-rest-api-specs
add apitestErrorCode doc (#14749)

* add apitestErrorCode doc

* add armRPC doc

* add roundTripInconsistentProperty doc

* small fix

* update

* update signalR armTemplate

* update yaml

* new file

* add testScenario with armTemplate

* update doc

* update readme.md

* update doc

* update NOTE section

* add signalRCreateOrUpdate example file

* udpate doc

* add generate test scenario section

* update doc

* add serviceFacbric test scenario file

* update managedClusters.yaml

* update generateABasicTestScenario.md

* update features doc

* add run api test gif

* version,CHANGELOG

* test

* Update test_cli_mgmt_servicebus_namespace.py

* Update test_queues.py

* Update test_queues.py

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: Zed Lei <59104634+RAY-316@users.noreply.github.com>
Co-authored-by: Jiefeng Chen <51037443+BigCat20196@users.noreply.github.com>

* [AutoRelease] t2-policyinsights-2021-08-23-78735 (#20381)

* CodeGen from PR 15165 in Azure/azure-rest-api-specs
[policyinsights] Fix next_link (#15165)

* fix next_link

* directive

* Update readme.nodejs.md

* js directvie

* Update readme.md

* supress other language

* Update readme.go.md

* swagger lint

* swagger lint

* swagger lint

* Update readme.md

* version,CHANGELOG

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: Zed Lei <59104634+RAY-316@users.noreply.github.com>

* [AutoRelease] t2-datamigration-2021-08-19-04035 (#20349)

* CodeGen from PR 15259 in Azure/azure-rest-api-specs
Dev datamigration microsoft.data migration 2021 06 30 (#15259)

* Created new api version and refactoring changes (such as fixing new build restrictions)

* Adding breaking changes

* Adding location to the services update example

* Adding location for projects update and refactoring the task command

* Resolving tasks command ModelValidation test failure

* Resolving issue based on zhenglaizhang's recommendation

* Adding comma to resolve issue

Co-authored-by: Artem Pavlichenko <arpavlic@microsoft.com>

* version,CHANGELOG

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: Artem Pavlichenko <arpavlic@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

* Chain exceptions from LibsecretPersistence (#20380)

* [translation] fix poller.details (#20392)

* fixing docstring types for async client

* populate poller.details.id immediately

* pylint

* add bug fix to changelog

* improve begin_translation docstring (#20401)

* Update .docsettings.yml (#20402)

* Sync eng/common directory with azure-sdk-tools for PR 1918 (#20342)

* Stress test deployment script resiliency fixes

* Use PSModule-Helpers to install powershell-yaml

Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>

* improve docs and samples for glossaries and custom models (#18587)

* update the readme

* update readme file

* added custom translation samples

* fix 'no-locale' thing in links

* update glossary docs

* update glossaries

* link to sample glossaries instead of writing code in readme

* update custom model sample linking

* remove relative linking in readme

* make subheadings in bold text to be more readable

* conform with 'Document Translation' naming

* disambiguate container sas url

* capitaliz Azure name

* remove misplaced period

* update samples -> custom model

* update async sample -> custom model

* remove localization from url

* update readme with new file types for glossaries

* adding sample glossaries -> xlf

* white space

* use simplified single input method

* update 'job' terminology

* update azure-core naming

* update glossary blob file reference name

* link to supported glossaries table

* remove locale from url

* [purview account] first release for azure-purview-account (#20335)

* purview account

* CI

* verion-tolerant

* endpoint order

* add test for collections

* Update CHANGELOG.md

* review

* update reamdme

* skip custom translation model samples (#20414)

* Address API view issues (#20407)

* logs client

* lc-2

* models changes

* more changes

* more changes

* more arch changes

* changelog

* tests

* lint

* fix tests

* timespan

* [translation] naming alignment (#20406)

* list_all_translation_statuses -> list_translation_statuses

* list_all_document_statuses -> list_document_statuses

* cancelled -> canceled, cancelling -> canceling

* FileFormat -> DocumentTranslationFileFormat

* update changelog

* make core tests offline (#19986)

* make core tests offline

* clean up

* use localhost instead of 127.0.0.1

* update

* update

* update

* Get rid of LogsBatchQueryResult (#20418)

* Get rid of LogsBatchQueryResult

* Update sdk/monitor/azure-monitor-query/README.md

* oops

* comments

* [AutoRelease] t2-iothub-2021-08-25-25696 (#20409)

* CodeGen from PR 15722 in Azure/azure-rest-api-specs
Removing readonly for isVerified property as it is no more readonly property (#15722)

* version,CHANGELOG

* test

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

* [AutoRelease] t2-healthcareapis-2021-08-26-27542 (#20422)

* CodeGen from PR 15381 in Azure/azure-rest-api-specs
Update readme.md (#15381)

* version,CHANGELOG

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

* Stip empty changelog sections before release (#20437)

Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>

* Update question-answering readme links (#20439)

* ensure test principal creation succeeds properly (#20446)

Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>

* New dummy password in README (#20328)

* Sync eng/common directory with azure-sdk-tools for PR 1943 (#20450)

* Bug fix: Storing .env file for bicep file at service dir

* Styling

Co-authored-by: Albert Cheng <albertcheng@microsoft.com>

* [AutoRelease] t2-keyvault-2021-08-26-55443 (#20423)

* CodeGen from PR 15458 in Azure/azure-rest-api-specs
Add rotation permission (#15458)

* Add rotation permission

* Update keys.json

Remove required from lifetimeActions

* Change to expiryTime

* version,CHANGELOG

* test

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

* new recordings

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: iscai-msft <43154838+iscai-msft@users.noreply.github.com>
Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>
Co-authored-by: Rakshith Bhyravabhotla <sabhyrav@microsoft.com>
Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>
Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>
Co-authored-by: Adam Ling (MSFT) <adam_ling@outlook.com>
Co-authored-by: Tong Xu (MSFT) <57166602+v-xuto@users.noreply.github.com>
Co-authored-by: ckairen <38804567+ckairen@users.noreply.github.com>
Co-authored-by: Charles Lowell <chlowe@microsoft.com>
Co-authored-by: Scott Beddall <45376673+scbedd@users.noreply.github.com>
Co-authored-by: Azure CLI Bot <azclibot@microsoft.com>
Co-authored-by: Jorge Chavez Nieto <jochav@microsoft.com>
Co-authored-by: Zed Lei <59104634+RAY-316@users.noreply.github.com>
Co-authored-by: Jiefeng Chen <51037443+BigCat20196@users.noreply.github.com>
Co-authored-by: Artem Pavlichenko <arpavlic@microsoft.com>
Co-authored-by: Krista Pratico <krpratic@microsoft.com>
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
Co-authored-by: Mohamed Shaban <v-moshaban@microsoft.com>
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Co-authored-by: Xiang Yan <xiangsjtu@gmail.com>
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
Co-authored-by: annatisch <antisch@microsoft.com>
Co-authored-by: Albert Cheng <albertcheng@microsoft.com>
iscai-msft pushed a commit that referenced this pull request Sep 29, 2021
@iscai-msft
improve docs and samples for glossaries and custom models (#18587)
70e35a9 
* update the readme

* update readme file

* added custom translation samples

* fix 'no-locale' thing in links

* update glossary docs

* update glossaries

* link to sample glossaries instead of writing code in readme

* update custom model sample linking

* remove relative linking in readme

* make subheadings in bold text to be more readable

* conform with 'Document Translation' naming

* disambiguate container sas url

* capitaliz Azure name

* remove misplaced period

* update samples -> custom model

* update async sample -> custom model

* remove localization from url

* update readme with new file types for glossaries

* adding sample glossaries -> xlf

* white space

* use simplified single input method

* update 'job' terminology

* update azure-core naming

* update glossary blob file reference name

* link to supported glossaries table

* remove locale from url
iscai-msft added a commit that referenced this pull request Sep 29, 2021
@hildurhodd @audunn
@iscai-msft @azure-sdk @weshaggard @swathipil @mccoyp @yunhaoling @v-xuto @ckairen @chlowell @scbedd @RAY-316 @BigCat20196 @kristapratico @benbp @msyyc @xiangyan99 @chidozieononiwu @annatisch
t2-Netapp-update-to-2021-06-01 (#20453)
22dcf25 
* CodeGen from PR 15691 in Azure/azure-rest-api-specs
[NetAppFiles] fix default in volumeproperties (#15691)

* fix default in volumeproperties

* Update description

* Update description

Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com>

* version,CHANGELOG

* test

* bump node version (#20353)

* Remove old unused update changelog script (#20357)

Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>

* Handle value types for results (#20358)

* Handle value types for results

* update test

* lint

* comprehension

* more precis

* fix test

* [rest] change text from a property to a method (#20290)

* [ServiceBus] update migration guide with message count info (#20360)

#20245

* Update CODEOWNERS (#20366)

* More Renaming in query (#20303)

* More Reanaming in query

* changelog

* commit 2

* some changes

* remove errror

* Update sdk/monitor/azure-monitor-query/azure/monitor/query/_models.py

* Apply suggestions from code review

Co-authored-by: Adam Ling (MSFT) <adam_ling@outlook.com>

* Update sdk/monitor/azure-monitor-query/CHANGELOG.md

Co-authored-by: Adam Ling (MSFT) <adam_ling@outlook.com>

* Fix Monitor opentelemetry exporter readme issues (#19038)

* [Key Vault] Add 7.3-preview support for administration (#20364)

* Update metadata values (#20365)

* Update metadata values

* distributed trace

* oops

* Update sdk/monitor/azure-monitor-query/CHANGELOG.md

* Apply suggestions from code review

* Bug fix for pipeline downloading incorrect package ver (#20294)

* Bug fix: pipeline to download correct package ver

* Update clean version

* Update clean version

* Cleanup

* Cleanup

* Cleanup

* Cleanup

* Comments added

* Testing

* Final-Version

* CertificateCredential supports PKCS12 certs (#16384)

* [rest] use azure json encoder for json input bodies (#20361)

* Document Pod Identity's special use of client_id (#20377)

* Consistency related changes (#20385)

* time stamp

* Rename AggragationType to MetricAggregationType

* Metric Class

* logs batch result

* MetricNamespaceClassification

* LogsTable + LogsTableColumn

* lint

* more lint

* Add Cloud Configuration section to Identity readme (#20373)

* keyvault and storage have a conflict between mindependency and what local azure-identity requires. resolve it (#20391)

* [AutoRelease] t2-costmanagement-2021-07-27-84467 (#19949)

* CodeGen from PR 15291 in Azure/azure-rest-api-specs
Updating Query filter description (#15291)

Co-authored-by: Jorge Chavez Nieto <jochav@microsoft.com>

* version,CHANGELOG

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: Jorge Chavez Nieto <jochav@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

* [AutoRelease] t2-servicebus-2021-08-19-00756 (#20350)

* CodeGen from PR 14749 in Azure/azure-rest-api-specs
add apitestErrorCode doc (#14749)

* add apitestErrorCode doc

* add armRPC doc

* add roundTripInconsistentProperty doc

* small fix

* update

* update signalR armTemplate

* update yaml

* new file

* add testScenario with armTemplate

* update doc

* update readme.md

* update doc

* update NOTE section

* add signalRCreateOrUpdate example file

* udpate doc

* add generate test scenario section

* update doc

* add serviceFacbric test scenario file

* update managedClusters.yaml

* update generateABasicTestScenario.md

* update features doc

* add run api test gif

* version,CHANGELOG

* test

* Update test_cli_mgmt_servicebus_namespace.py

* Update test_queues.py

* Update test_queues.py

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: Zed Lei <59104634+RAY-316@users.noreply.github.com>
Co-authored-by: Jiefeng Chen <51037443+BigCat20196@users.noreply.github.com>

* [AutoRelease] t2-policyinsights-2021-08-23-78735 (#20381)

* CodeGen from PR 15165 in Azure/azure-rest-api-specs
[policyinsights] Fix next_link (#15165)

* fix next_link

* directive

* Update readme.nodejs.md

* js directvie

* Update readme.md

* supress other language

* Update readme.go.md

* swagger lint

* swagger lint

* swagger lint

* Update readme.md

* version,CHANGELOG

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: Zed Lei <59104634+RAY-316@users.noreply.github.com>

* [AutoRelease] t2-datamigration-2021-08-19-04035 (#20349)

* CodeGen from PR 15259 in Azure/azure-rest-api-specs
Dev datamigration microsoft.data migration 2021 06 30 (#15259)

* Created new api version and refactoring changes (such as fixing new build restrictions)

* Adding breaking changes

* Adding location to the services update example

* Adding location for projects update and refactoring the task command

* Resolving tasks command ModelValidation test failure

* Resolving issue based on zhenglaizhang's recommendation

* Adding comma to resolve issue

Co-authored-by: Artem Pavlichenko <arpavlic@microsoft.com>

* version,CHANGELOG

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: Artem Pavlichenko <arpavlic@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

* Chain exceptions from LibsecretPersistence (#20380)

* [translation] fix poller.details (#20392)

* fixing docstring types for async client

* populate poller.details.id immediately

* pylint

* add bug fix to changelog

* improve begin_translation docstring (#20401)

* Update .docsettings.yml (#20402)

* Sync eng/common directory with azure-sdk-tools for PR 1918 (#20342)

* Stress test deployment script resiliency fixes

* Use PSModule-Helpers to install powershell-yaml

Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>

* improve docs and samples for glossaries and custom models (#18587)

* update the readme

* update readme file

* added custom translation samples

* fix 'no-locale' thing in links

* update glossary docs

* update glossaries

* link to sample glossaries instead of writing code in readme

* update custom model sample linking

* remove relative linking in readme

* make subheadings in bold text to be more readable

* conform with 'Document Translation' naming

* disambiguate container sas url

* capitaliz Azure name

* remove misplaced period

* update samples -> custom model

* update async sample -> custom model

* remove localization from url

* update readme with new file types for glossaries

* adding sample glossaries -> xlf

* white space

* use simplified single input method

* update 'job' terminology

* update azure-core naming

* update glossary blob file reference name

* link to supported glossaries table

* remove locale from url

* [purview account] first release for azure-purview-account (#20335)

* purview account

* CI

* verion-tolerant

* endpoint order

* add test for collections

* Update CHANGELOG.md

* review

* update reamdme

* skip custom translation model samples (#20414)

* Address API view issues (#20407)

* logs client

* lc-2

* models changes

* more changes

* more changes

* more arch changes

* changelog

* tests

* lint

* fix tests

* timespan

* [translation] naming alignment (#20406)

* list_all_translation_statuses -> list_translation_statuses

* list_all_document_statuses -> list_document_statuses

* cancelled -> canceled, cancelling -> canceling

* FileFormat -> DocumentTranslationFileFormat

* update changelog

* make core tests offline (#19986)

* make core tests offline

* clean up

* use localhost instead of 127.0.0.1

* update

* update

* update

* Get rid of LogsBatchQueryResult (#20418)

* Get rid of LogsBatchQueryResult

* Update sdk/monitor/azure-monitor-query/README.md

* oops

* comments

* [AutoRelease] t2-iothub-2021-08-25-25696 (#20409)

* CodeGen from PR 15722 in Azure/azure-rest-api-specs
Removing readonly for isVerified property as it is no more readonly property (#15722)

* version,CHANGELOG

* test

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

* [AutoRelease] t2-healthcareapis-2021-08-26-27542 (#20422)

* CodeGen from PR 15381 in Azure/azure-rest-api-specs
Update readme.md (#15381)

* version,CHANGELOG

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

* Stip empty changelog sections before release (#20437)

Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>

* Update question-answering readme links (#20439)

* ensure test principal creation succeeds properly (#20446)

Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>

* New dummy password in README (#20328)

* Sync eng/common directory with azure-sdk-tools for PR 1943 (#20450)

* Bug fix: Storing .env file for bicep file at service dir

* Styling

Co-authored-by: Albert Cheng <albertcheng@microsoft.com>

* [AutoRelease] t2-keyvault-2021-08-26-55443 (#20423)

* CodeGen from PR 15458 in Azure/azure-rest-api-specs
Add rotation permission (#15458)

* Add rotation permission

* Update keys.json

Remove required from lifetimeActions

* Change to expiryTime

* version,CHANGELOG

* test

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

* new recordings

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: iscai-msft <43154838+iscai-msft@users.noreply.github.com>
Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>
Co-authored-by: Rakshith Bhyravabhotla <sabhyrav@microsoft.com>
Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>
Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>
Co-authored-by: Adam Ling (MSFT) <adam_ling@outlook.com>
Co-authored-by: Tong Xu (MSFT) <57166602+v-xuto@users.noreply.github.com>
Co-authored-by: ckairen <38804567+ckairen@users.noreply.github.com>
Co-authored-by: Charles Lowell <chlowe@microsoft.com>
Co-authored-by: Scott Beddall <45376673+scbedd@users.noreply.github.com>
Co-authored-by: Azure CLI Bot <azclibot@microsoft.com>
Co-authored-by: Jorge Chavez Nieto <jochav@microsoft.com>
Co-authored-by: Zed Lei <59104634+RAY-316@users.noreply.github.com>
Co-authored-by: Jiefeng Chen <51037443+BigCat20196@users.noreply.github.com>
Co-authored-by: Artem Pavlichenko <arpavlic@microsoft.com>
Co-authored-by: Krista Pratico <krpratic@microsoft.com>
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
Co-authored-by: Mohamed Shaban <v-moshaban@microsoft.com>
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Co-authored-by: Xiang Yan <xiangsjtu@gmail.com>
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
Co-authored-by: annatisch <antisch@microsoft.com>
Co-authored-by: Albert Cheng <albertcheng@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristapratico kristapratico kristapratico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mshaban-msft @kristapratico