Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[purview account] first release for azure-purview-account #20335

Merged
merged 9 commits into from
Aug 25, 2021
Merged

[purview account] first release for azure-purview-account #20335

merged 9 commits into from
Aug 25, 2021

Conversation

msyyc
Copy link
Member

@msyyc msyyc commented Aug 18, 2021 •
edited
Loading

autorest --version=3.4.5 --python --track2 --use=D:\dev3\autorest.python --use=@autorest\modelerfour@4.19.2 --python-sdks-folder=D:\dev3\azure-sdk-for-python\sdk --python-mode=update D:\dev3\azure-sdk-for-python\sdk\purview\azure-purview-account\swagger\README.md --version-tolerant

@msyyc msyyc self-assigned this Aug 18, 2021
@msyyc msyyc requested a review from iscai-msft August 23, 2021 05:40
iscai-msft
iscai-msft reviewed Aug 23, 2021
View reviewed changes
Copy link
Contributor

@iscai-msft iscai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there, jsut some docstring / test nits. Thanks!

sdk/purview/azure-purview-account/README.md Outdated
response = client.send_request(request)
try:
response.raise_for_status()
assert response.status_code == 200
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this sample is out of date because we've embedded the requests. Can you switch this to calling client.list_keys()? Additionally, can you iterate over the returned keys and print out information on them? thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p.s., we also generally don't include asserts in our sample code, we use assert for testing instead

sdk/purview/azure-purview-account/README.md Outdated
even when it isn't enabled for the client:

```python
result = client.send_request(request, logging_enable=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to switch this call to an operation call, for example

result = client.list_keys(..., logging_enable=True)

sdk/purview/azure-purview-account/tests/test_smoke.py Outdated
client = self.create_client(endpoint=purviewaccount_endpoint)
response = client.collections.list_collections()
result = [item for item in response]
assert len(result) > 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also verify some of the attributes in the key response if possible, for example verify that their names are what you expect etc

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

side note: i refer to "key names", not 100% sure that's actually whats in the response body, but what I mean is just identifying information about each key

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think detailed check is not necessary since the resource is created manually in advance. And the resource may be changed in the future. But we could check whether keys exist.

iscai-msft
iscai-msft approved these changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@iscai-msft iscai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the documentation could be improved, but I don't want to block the release on this

sdk/purview/azure-purview-account/tests/test_smoke_async.py
@PurviewAccountPowerShellPreparer()
async def test_basic_smoke_test(self, purviewaccount_endpoint):
self.recording_processors.append(PurviewAccountRecordingProcessor())
client = self.create_async_client(endpoint=purviewaccount_endpoint)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like the tests!

@msyyc msyyc merged commit cfbc939 into Azure:main Aug 25, 2021
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Aug 25, 2021
@iscai-msft
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-python …
c71823c 
…into switch_to_rest

* 'main' of https://github.com/Azure/azure-sdk-for-python:
  Address API view issues (Azure#20407)
  skip custom translation model samples (Azure#20414)
  [purview account] first release for azure-purview-account (Azure#20335)
  improve docs and samples for glossaries and custom models (Azure#18587)
  Sync eng/common directory with azure-sdk-tools for PR 1918 (Azure#20342)
  Update .docsettings.yml (Azure#20402)
  improve begin_translation docstring (Azure#20401)
  [translation] fix poller.details (Azure#20392)
  Chain exceptions from LibsecretPersistence (Azure#20380)
  [AutoRelease] t2-datamigration-2021-08-19-04035 (Azure#20349)
  [AutoRelease] t2-policyinsights-2021-08-23-78735 (Azure#20381)
  [AutoRelease] t2-servicebus-2021-08-19-00756 (Azure#20350)
  [AutoRelease] t2-costmanagement-2021-07-27-84467 (Azure#19949)
  keyvault and storage have a conflict between mindependency and what local azure-identity requires. resolve it (Azure#20391)
  Add Cloud Configuration section to Identity readme (Azure#20373)
  Consistency related changes (Azure#20385)
iscai-msft added a commit that referenced this pull request Aug 25, 2021
@iscai-msft
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-python …
f2c2b0d 
…into header_tuples

* 'main' of https://github.com/Azure/azure-sdk-for-python: (23 commits)
  make core tests offline (#19986)
  [translation] naming alignment (#20406)
  Address API view issues (#20407)
  skip custom translation model samples (#20414)
  [purview account] first release for azure-purview-account (#20335)
  improve docs and samples for glossaries and custom models (#18587)
  Sync eng/common directory with azure-sdk-tools for PR 1918 (#20342)
  Update .docsettings.yml (#20402)
  improve begin_translation docstring (#20401)
  [translation] fix poller.details (#20392)
  Chain exceptions from LibsecretPersistence (#20380)
  [AutoRelease] t2-datamigration-2021-08-19-04035 (#20349)
  [AutoRelease] t2-policyinsights-2021-08-23-78735 (#20381)
  [AutoRelease] t2-servicebus-2021-08-19-00756 (#20350)
  [AutoRelease] t2-costmanagement-2021-07-27-84467 (#19949)
  keyvault and storage have a conflict between mindependency and what local azure-identity requires. resolve it (#20391)
  Add Cloud Configuration section to Identity readme (#20373)
  Consistency related changes (#20385)
  Document Pod Identity's special use of client_id (#20377)
  [rest] use azure json encoder for json input bodies (#20361)
  ...
hildurhodd pushed a commit to hildurhodd/azure-sdk-for-python that referenced this pull request Aug 26, 2021
@msyyc @hildurhodd
[purview account] first release for azure-purview-account (Azure#20335)
7df4255 
* purview account

* CI

* verion-tolerant

* endpoint order

* add test for collections

* Update CHANGELOG.md

* review

* update reamdme
hildurhodd pushed a commit to hildurhodd/azure-sdk-for-python that referenced this pull request Aug 26, 2021
@msyyc @hildurhodd
[purview account] first release for azure-purview-account (Azure#20335)
ffcc105 
* purview account

* CI

* verion-tolerant

* endpoint order

* add test for collections

* Update CHANGELOG.md

* review

* update reamdme
hildurhodd pushed a commit to hildurhodd/azure-sdk-for-python that referenced this pull request Aug 30, 2021
@msyyc @hildurhodd
[purview account] first release for azure-purview-account (Azure#20335)
b820ff2 
* purview account

* CI

* verion-tolerant

* endpoint order

* add test for collections

* Update CHANGELOG.md

* review

* update reamdme
msyyc added a commit that referenced this pull request Aug 30, 2021
@hildurhodd @audunn
@iscai-msft @azure-sdk @weshaggard @swathipil @mccoyp @yunhaoling @v-xuto @ckairen @chlowell @scbedd @RAY-316 @BigCat20196 @kristapratico @benbp @msyyc @xiangyan99 @chidozieononiwu @annatisch
t2-Netapp-update-to-2021-06-01 (#20453)
fac427d 
* CodeGen from PR 15691 in Azure/azure-rest-api-specs
[NetAppFiles] fix default in volumeproperties (#15691)

* fix default in volumeproperties

* Update description

* Update description

Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com>

* version,CHANGELOG

* test

* bump node version (#20353)

* Remove old unused update changelog script (#20357)

Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>

* Handle value types for results (#20358)

* Handle value types for results

* update test

* lint

* comprehension

* more precis

* fix test

* [rest] change text from a property to a method (#20290)

* [ServiceBus] update migration guide with message count info (#20360)

#20245

* Update CODEOWNERS (#20366)

* More Renaming in query (#20303)

* More Reanaming in query

* changelog

* commit 2

* some changes

* remove errror

* Update sdk/monitor/azure-monitor-query/azure/monitor/query/_models.py

* Apply suggestions from code review

Co-authored-by: Adam Ling (MSFT) <adam_ling@outlook.com>

* Update sdk/monitor/azure-monitor-query/CHANGELOG.md

Co-authored-by: Adam Ling (MSFT) <adam_ling@outlook.com>

* Fix Monitor opentelemetry exporter readme issues (#19038)

* [Key Vault] Add 7.3-preview support for administration (#20364)

* Update metadata values (#20365)

* Update metadata values

* distributed trace

* oops

* Update sdk/monitor/azure-monitor-query/CHANGELOG.md

* Apply suggestions from code review

* Bug fix for pipeline downloading incorrect package ver (#20294)

* Bug fix: pipeline to download correct package ver

* Update clean version

* Update clean version

* Cleanup

* Cleanup

* Cleanup

* Cleanup

* Comments added

* Testing

* Final-Version

* CertificateCredential supports PKCS12 certs (#16384)

* [rest] use azure json encoder for json input bodies (#20361)

* Document Pod Identity's special use of client_id (#20377)

* Consistency related changes (#20385)

* time stamp

* Rename AggragationType to MetricAggregationType

* Metric Class

* logs batch result

* MetricNamespaceClassification

* LogsTable + LogsTableColumn

* lint

* more lint

* Add Cloud Configuration section to Identity readme (#20373)

* keyvault and storage have a conflict between mindependency and what local azure-identity requires. resolve it (#20391)

* [AutoRelease] t2-costmanagement-2021-07-27-84467 (#19949)

* CodeGen from PR 15291 in Azure/azure-rest-api-specs
Updating Query filter description (#15291)

Co-authored-by: Jorge Chavez Nieto <jochav@microsoft.com>

* version,CHANGELOG

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: Jorge Chavez Nieto <jochav@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

* [AutoRelease] t2-servicebus-2021-08-19-00756 (#20350)

* CodeGen from PR 14749 in Azure/azure-rest-api-specs
add apitestErrorCode doc (#14749)

* add apitestErrorCode doc

* add armRPC doc

* add roundTripInconsistentProperty doc

* small fix

* update

* update signalR armTemplate

* update yaml

* new file

* add testScenario with armTemplate

* update doc

* update readme.md

* update doc

* update NOTE section

* add signalRCreateOrUpdate example file

* udpate doc

* add generate test scenario section

* update doc

* add serviceFacbric test scenario file

* update managedClusters.yaml

* update generateABasicTestScenario.md

* update features doc

* add run api test gif

* version,CHANGELOG

* test

* Update test_cli_mgmt_servicebus_namespace.py

* Update test_queues.py

* Update test_queues.py

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: Zed Lei <59104634+RAY-316@users.noreply.github.com>
Co-authored-by: Jiefeng Chen <51037443+BigCat20196@users.noreply.github.com>

* [AutoRelease] t2-policyinsights-2021-08-23-78735 (#20381)

* CodeGen from PR 15165 in Azure/azure-rest-api-specs
[policyinsights] Fix next_link (#15165)

* fix next_link

* directive

* Update readme.nodejs.md

* js directvie

* Update readme.md

* supress other language

* Update readme.go.md

* swagger lint

* swagger lint

* swagger lint

* Update readme.md

* version,CHANGELOG

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: Zed Lei <59104634+RAY-316@users.noreply.github.com>

* [AutoRelease] t2-datamigration-2021-08-19-04035 (#20349)

* CodeGen from PR 15259 in Azure/azure-rest-api-specs
Dev datamigration microsoft.data migration 2021 06 30 (#15259)

* Created new api version and refactoring changes (such as fixing new build restrictions)

* Adding breaking changes

* Adding location to the services update example

* Adding location for projects update and refactoring the task command

* Resolving tasks command ModelValidation test failure

* Resolving issue based on zhenglaizhang's recommendation

* Adding comma to resolve issue

Co-authored-by: Artem Pavlichenko <arpavlic@microsoft.com>

* version,CHANGELOG

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: Artem Pavlichenko <arpavlic@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

* Chain exceptions from LibsecretPersistence (#20380)

* [translation] fix poller.details (#20392)

* fixing docstring types for async client

* populate poller.details.id immediately

* pylint

* add bug fix to changelog

* improve begin_translation docstring (#20401)

* Update .docsettings.yml (#20402)

* Sync eng/common directory with azure-sdk-tools for PR 1918 (#20342)

* Stress test deployment script resiliency fixes

* Use PSModule-Helpers to install powershell-yaml

Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>

* improve docs and samples for glossaries and custom models (#18587)

* update the readme

* update readme file

* added custom translation samples

* fix 'no-locale' thing in links

* update glossary docs

* update glossaries

* link to sample glossaries instead of writing code in readme

* update custom model sample linking

* remove relative linking in readme

* make subheadings in bold text to be more readable

* conform with 'Document Translation' naming

* disambiguate container sas url

* capitaliz Azure name

* remove misplaced period

* update samples -> custom model

* update async sample -> custom model

* remove localization from url

* update readme with new file types for glossaries

* adding sample glossaries -> xlf

* white space

* use simplified single input method

* update 'job' terminology

* update azure-core naming

* update glossary blob file reference name

* link to supported glossaries table

* remove locale from url

* [purview account] first release for azure-purview-account (#20335)

* purview account

* CI

* verion-tolerant

* endpoint order

* add test for collections

* Update CHANGELOG.md

* review

* update reamdme

* skip custom translation model samples (#20414)

* Address API view issues (#20407)

* logs client

* lc-2

* models changes

* more changes

* more changes

* more arch changes

* changelog

* tests

* lint

* fix tests

* timespan

* [translation] naming alignment (#20406)

* list_all_translation_statuses -> list_translation_statuses

* list_all_document_statuses -> list_document_statuses

* cancelled -> canceled, cancelling -> canceling

* FileFormat -> DocumentTranslationFileFormat

* update changelog

* make core tests offline (#19986)

* make core tests offline

* clean up

* use localhost instead of 127.0.0.1

* update

* update

* update

* Get rid of LogsBatchQueryResult (#20418)

* Get rid of LogsBatchQueryResult

* Update sdk/monitor/azure-monitor-query/README.md

* oops

* comments

* [AutoRelease] t2-iothub-2021-08-25-25696 (#20409)

* CodeGen from PR 15722 in Azure/azure-rest-api-specs
Removing readonly for isVerified property as it is no more readonly property (#15722)

* version,CHANGELOG

* test

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

* [AutoRelease] t2-healthcareapis-2021-08-26-27542 (#20422)

* CodeGen from PR 15381 in Azure/azure-rest-api-specs
Update readme.md (#15381)

* version,CHANGELOG

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

* Stip empty changelog sections before release (#20437)

Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>

* Update question-answering readme links (#20439)

* ensure test principal creation succeeds properly (#20446)

Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>

* New dummy password in README (#20328)

* Sync eng/common directory with azure-sdk-tools for PR 1943 (#20450)

* Bug fix: Storing .env file for bicep file at service dir

* Styling

Co-authored-by: Albert Cheng <albertcheng@microsoft.com>

* [AutoRelease] t2-keyvault-2021-08-26-55443 (#20423)

* CodeGen from PR 15458 in Azure/azure-rest-api-specs
Add rotation permission (#15458)

* Add rotation permission

* Update keys.json

Remove required from lifetimeActions

* Change to expiryTime

* version,CHANGELOG

* test

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

* new recordings

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: iscai-msft <43154838+iscai-msft@users.noreply.github.com>
Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>
Co-authored-by: Rakshith Bhyravabhotla <sabhyrav@microsoft.com>
Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>
Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>
Co-authored-by: Adam Ling (MSFT) <adam_ling@outlook.com>
Co-authored-by: Tong Xu (MSFT) <57166602+v-xuto@users.noreply.github.com>
Co-authored-by: ckairen <38804567+ckairen@users.noreply.github.com>
Co-authored-by: Charles Lowell <chlowe@microsoft.com>
Co-authored-by: Scott Beddall <45376673+scbedd@users.noreply.github.com>
Co-authored-by: Azure CLI Bot <azclibot@microsoft.com>
Co-authored-by: Jorge Chavez Nieto <jochav@microsoft.com>
Co-authored-by: Zed Lei <59104634+RAY-316@users.noreply.github.com>
Co-authored-by: Jiefeng Chen <51037443+BigCat20196@users.noreply.github.com>
Co-authored-by: Artem Pavlichenko <arpavlic@microsoft.com>
Co-authored-by: Krista Pratico <krpratic@microsoft.com>
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
Co-authored-by: Mohamed Shaban <v-moshaban@microsoft.com>
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Co-authored-by: Xiang Yan <xiangsjtu@gmail.com>
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
Co-authored-by: annatisch <antisch@microsoft.com>
Co-authored-by: Albert Cheng <albertcheng@microsoft.com>
iscai-msft pushed a commit that referenced this pull request Sep 29, 2021
@msyyc @iscai-msft
[purview account] first release for azure-purview-account (#20335)
b325d7e 
* purview account

* CI

* verion-tolerant

* endpoint order

* add test for collections

* Update CHANGELOG.md

* review

* update reamdme
iscai-msft added a commit that referenced this pull request Sep 29, 2021
@hildurhodd @audunn
@iscai-msft @azure-sdk @weshaggard @swathipil @mccoyp @yunhaoling @v-xuto @ckairen @chlowell @scbedd @RAY-316 @BigCat20196 @kristapratico @benbp @msyyc @xiangyan99 @chidozieononiwu @annatisch
t2-Netapp-update-to-2021-06-01 (#20453)
22dcf25 
* CodeGen from PR 15691 in Azure/azure-rest-api-specs
[NetAppFiles] fix default in volumeproperties (#15691)

* fix default in volumeproperties

* Update description

* Update description

Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com>

* version,CHANGELOG

* test

* bump node version (#20353)

* Remove old unused update changelog script (#20357)

Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>

* Handle value types for results (#20358)

* Handle value types for results

* update test

* lint

* comprehension

* more precis

* fix test

* [rest] change text from a property to a method (#20290)

* [ServiceBus] update migration guide with message count info (#20360)

#20245

* Update CODEOWNERS (#20366)

* More Renaming in query (#20303)

* More Reanaming in query

* changelog

* commit 2

* some changes

* remove errror

* Update sdk/monitor/azure-monitor-query/azure/monitor/query/_models.py

* Apply suggestions from code review

Co-authored-by: Adam Ling (MSFT) <adam_ling@outlook.com>

* Update sdk/monitor/azure-monitor-query/CHANGELOG.md

Co-authored-by: Adam Ling (MSFT) <adam_ling@outlook.com>

* Fix Monitor opentelemetry exporter readme issues (#19038)

* [Key Vault] Add 7.3-preview support for administration (#20364)

* Update metadata values (#20365)

* Update metadata values

* distributed trace

* oops

* Update sdk/monitor/azure-monitor-query/CHANGELOG.md

* Apply suggestions from code review

* Bug fix for pipeline downloading incorrect package ver (#20294)

* Bug fix: pipeline to download correct package ver

* Update clean version

* Update clean version

* Cleanup

* Cleanup

* Cleanup

* Cleanup

* Comments added

* Testing

* Final-Version

* CertificateCredential supports PKCS12 certs (#16384)

* [rest] use azure json encoder for json input bodies (#20361)

* Document Pod Identity's special use of client_id (#20377)

* Consistency related changes (#20385)

* time stamp

* Rename AggragationType to MetricAggregationType

* Metric Class

* logs batch result

* MetricNamespaceClassification

* LogsTable + LogsTableColumn

* lint

* more lint

* Add Cloud Configuration section to Identity readme (#20373)

* keyvault and storage have a conflict between mindependency and what local azure-identity requires. resolve it (#20391)

* [AutoRelease] t2-costmanagement-2021-07-27-84467 (#19949)

* CodeGen from PR 15291 in Azure/azure-rest-api-specs
Updating Query filter description (#15291)

Co-authored-by: Jorge Chavez Nieto <jochav@microsoft.com>

* version,CHANGELOG

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: Jorge Chavez Nieto <jochav@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

* [AutoRelease] t2-servicebus-2021-08-19-00756 (#20350)

* CodeGen from PR 14749 in Azure/azure-rest-api-specs
add apitestErrorCode doc (#14749)

* add apitestErrorCode doc

* add armRPC doc

* add roundTripInconsistentProperty doc

* small fix

* update

* update signalR armTemplate

* update yaml

* new file

* add testScenario with armTemplate

* update doc

* update readme.md

* update doc

* update NOTE section

* add signalRCreateOrUpdate example file

* udpate doc

* add generate test scenario section

* update doc

* add serviceFacbric test scenario file

* update managedClusters.yaml

* update generateABasicTestScenario.md

* update features doc

* add run api test gif

* version,CHANGELOG

* test

* Update test_cli_mgmt_servicebus_namespace.py

* Update test_queues.py

* Update test_queues.py

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: Zed Lei <59104634+RAY-316@users.noreply.github.com>
Co-authored-by: Jiefeng Chen <51037443+BigCat20196@users.noreply.github.com>

* [AutoRelease] t2-policyinsights-2021-08-23-78735 (#20381)

* CodeGen from PR 15165 in Azure/azure-rest-api-specs
[policyinsights] Fix next_link (#15165)

* fix next_link

* directive

* Update readme.nodejs.md

* js directvie

* Update readme.md

* supress other language

* Update readme.go.md

* swagger lint

* swagger lint

* swagger lint

* Update readme.md

* version,CHANGELOG

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: Zed Lei <59104634+RAY-316@users.noreply.github.com>

* [AutoRelease] t2-datamigration-2021-08-19-04035 (#20349)

* CodeGen from PR 15259 in Azure/azure-rest-api-specs
Dev datamigration microsoft.data migration 2021 06 30 (#15259)

* Created new api version and refactoring changes (such as fixing new build restrictions)

* Adding breaking changes

* Adding location to the services update example

* Adding location for projects update and refactoring the task command

* Resolving tasks command ModelValidation test failure

* Resolving issue based on zhenglaizhang's recommendation

* Adding comma to resolve issue

Co-authored-by: Artem Pavlichenko <arpavlic@microsoft.com>

* version,CHANGELOG

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: Artem Pavlichenko <arpavlic@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

* Chain exceptions from LibsecretPersistence (#20380)

* [translation] fix poller.details (#20392)

* fixing docstring types for async client

* populate poller.details.id immediately

* pylint

* add bug fix to changelog

* improve begin_translation docstring (#20401)

* Update .docsettings.yml (#20402)

* Sync eng/common directory with azure-sdk-tools for PR 1918 (#20342)

* Stress test deployment script resiliency fixes

* Use PSModule-Helpers to install powershell-yaml

Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>

* improve docs and samples for glossaries and custom models (#18587)

* update the readme

* update readme file

* added custom translation samples

* fix 'no-locale' thing in links

* update glossary docs

* update glossaries

* link to sample glossaries instead of writing code in readme

* update custom model sample linking

* remove relative linking in readme

* make subheadings in bold text to be more readable

* conform with 'Document Translation' naming

* disambiguate container sas url

* capitaliz Azure name

* remove misplaced period

* update samples -> custom model

* update async sample -> custom model

* remove localization from url

* update readme with new file types for glossaries

* adding sample glossaries -> xlf

* white space

* use simplified single input method

* update 'job' terminology

* update azure-core naming

* update glossary blob file reference name

* link to supported glossaries table

* remove locale from url

* [purview account] first release for azure-purview-account (#20335)

* purview account

* CI

* verion-tolerant

* endpoint order

* add test for collections

* Update CHANGELOG.md

* review

* update reamdme

* skip custom translation model samples (#20414)

* Address API view issues (#20407)

* logs client

* lc-2

* models changes

* more changes

* more changes

* more arch changes

* changelog

* tests

* lint

* fix tests

* timespan

* [translation] naming alignment (#20406)

* list_all_translation_statuses -> list_translation_statuses

* list_all_document_statuses -> list_document_statuses

* cancelled -> canceled, cancelling -> canceling

* FileFormat -> DocumentTranslationFileFormat

* update changelog

* make core tests offline (#19986)

* make core tests offline

* clean up

* use localhost instead of 127.0.0.1

* update

* update

* update

* Get rid of LogsBatchQueryResult (#20418)

* Get rid of LogsBatchQueryResult

* Update sdk/monitor/azure-monitor-query/README.md

* oops

* comments

* [AutoRelease] t2-iothub-2021-08-25-25696 (#20409)

* CodeGen from PR 15722 in Azure/azure-rest-api-specs
Removing readonly for isVerified property as it is no more readonly property (#15722)

* version,CHANGELOG

* test

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

* [AutoRelease] t2-healthcareapis-2021-08-26-27542 (#20422)

* CodeGen from PR 15381 in Azure/azure-rest-api-specs
Update readme.md (#15381)

* version,CHANGELOG

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

* Stip empty changelog sections before release (#20437)

Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>

* Update question-answering readme links (#20439)

* ensure test principal creation succeeds properly (#20446)

Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>

* New dummy password in README (#20328)

* Sync eng/common directory with azure-sdk-tools for PR 1943 (#20450)

* Bug fix: Storing .env file for bicep file at service dir

* Styling

Co-authored-by: Albert Cheng <albertcheng@microsoft.com>

* [AutoRelease] t2-keyvault-2021-08-26-55443 (#20423)

* CodeGen from PR 15458 in Azure/azure-rest-api-specs
Add rotation permission (#15458)

* Add rotation permission

* Update keys.json

Remove required from lifetimeActions

* Change to expiryTime

* version,CHANGELOG

* test

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

* new recordings

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: iscai-msft <43154838+iscai-msft@users.noreply.github.com>
Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>
Co-authored-by: Rakshith Bhyravabhotla <sabhyrav@microsoft.com>
Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>
Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>
Co-authored-by: Adam Ling (MSFT) <adam_ling@outlook.com>
Co-authored-by: Tong Xu (MSFT) <57166602+v-xuto@users.noreply.github.com>
Co-authored-by: ckairen <38804567+ckairen@users.noreply.github.com>
Co-authored-by: Charles Lowell <chlowe@microsoft.com>
Co-authored-by: Scott Beddall <45376673+scbedd@users.noreply.github.com>
Co-authored-by: Azure CLI Bot <azclibot@microsoft.com>
Co-authored-by: Jorge Chavez Nieto <jochav@microsoft.com>
Co-authored-by: Zed Lei <59104634+RAY-316@users.noreply.github.com>
Co-authored-by: Jiefeng Chen <51037443+BigCat20196@users.noreply.github.com>
Co-authored-by: Artem Pavlichenko <arpavlic@microsoft.com>
Co-authored-by: Krista Pratico <krpratic@microsoft.com>
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
Co-authored-by: Mohamed Shaban <v-moshaban@microsoft.com>
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Co-authored-by: Xiang Yan <xiangsjtu@gmail.com>
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
Co-authored-by: annatisch <antisch@microsoft.com>
Co-authored-by: Albert Cheng <albertcheng@microsoft.com>
@msyyc msyyc deleted the purview-account-2021-08-18 branch November 25, 2021 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iscai-msft iscai-msft iscai-msft approved these changes

@lmazuel lmazuel Awaiting requested review from lmazuel

@mayurid mayurid Awaiting requested review from mayurid

@scbedd scbedd Awaiting requested review from scbedd scbedd is a code owner

@danieljurek danieljurek Awaiting requested review from danieljurek

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard is a code owner

Assignees

@msyyc msyyc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msyyc @iscai-msft