[AutoPR monitor/resource-manager] Added GA API version for Scheduled Query Rule #2416

AutorestCI · 2018-04-17T17:48:01Z

Created to sync Azure/azure-rest-api-specs#2858

Resolving Comments Resolving Comments

AutorestCI · 2018-04-17T17:49:40Z

(message created by the CI based on PR content)

Installation instruction

Package azure-mgmt-monitor

You can install the package azure-mgmt-monitor of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_2858#egg=azure-mgmt-monitor&subdirectory=azure-mgmt-monitor"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_2858#egg=azure-mgmt-monitor&subdirectory=azure-mgmt-monitor"

If you have a local clone of this repository, you can also do:

git checkout restapi_auto_2858
pip install -e ./azure-mgmt-monitor

Or build a wheel file to distribute for testing:

git checkout restapi_auto_2858
pip wheel --no-deps ./azure-mgmt-monitor

Direct download

Your files can be directly downloaded here:

codecov-io · 2018-04-17T18:03:39Z

Codecov Report

Merging #2416 into restapi_auto_monitor/resource-manager will decrease coverage by 0.07%.
The diff coverage is 43.04%.

@@                            Coverage Diff                            @@
##           restapi_auto_monitor/resource-manager    #2416      +/-   ##
=========================================================================
- Coverage                                  54.54%   54.47%   -0.08%     
=========================================================================
  Files                                       5429     5472      +43     
  Lines                                     127628   128397     +769     
=========================================================================
+ Hits                                       69615    69942     +327     
- Misses                                     58013    58455     +442

Impacted Files	Coverage Δ
...azure/mgmt/monitor/models/action_group_resource.py	`29.41% <0%> (-6.31%)`	⬇️
...onitor/azure/mgmt/monitor/models/metric_trigger.py	`29.41% <0%> (-6.31%)`	⬇️
...gmt/monitor/operations/action_groups_operations.py	`16.77% <100%> (ø)`	⬆️
...mgmt-monitor/azure/mgmt/monitor/models/__init__.py	`100% <100%> (ø)`	⬆️
.../monitor/models/monitor_management_client_enums.py	`100% <100%> (ø)`	⬆️
...or/azure/mgmt/monitor/monitor_management_client.py	`100% <100%> (ø)`	⬆️
...-monitor/azure/mgmt/monitor/operations/__init__.py	`100% <100%> (ø)`	⬆️
azure-mgmt-monitor/azure/mgmt/monitor/version.py	`100% <100%> (ø)`	⬆️
...gmt/monitor/operations/metric_alerts_operations.py	`18.46% <18.46%> (ø)`
...tor/operations/scheduled_query_rules_operations.py	`18.96% <18.96%> (ø)`
... and 86 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c48dd2...72a9a89. Read the comment docs.

Made SKU as top level proprty and including generic error response format Couple of changes - 1. Made SKU as top level proprty as mentioned here - https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/resource-api-reference.md#put-resource 2. including generic error response format

Minor Changes to align implementation 1. Removed SKU - Billing Model is still under discussion, hence need not to be exposed to customers. 2. Enabled field ichanged to align with camel case. 3. 'throttleTillDate' in properties.action changed to 'throttlingInMin' to denote correct meaning and it’s data type changed to number instead of date. 4. 'status' to be removed in properties.action from examples. 5. 'severity' made a required field in properties.action. 6. Removed Examples from original spec json

Added Default Response payload in all APIs Changes - 1. Added Default Response payload in all APIs 2. Made azNs description more clear

AutorestCI · 2018-04-24T17:53:49Z

This PR has been merged into #2460

…Query Rule (#2416) * Generated from d183bad923d3a0a4092d21203f850db6cde9f4e9 Resolving Comments Resolving Comments * Generated from df40ac3bbf17ea0180dd4adff2af3094065feca0 Made SKU as top level proprty and including generic error response format Couple of changes - 1. Made SKU as top level proprty as mentioned here - https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/resource-api-reference.md#put-resource 2. including generic error response format * Generated from 7578160670750a68d05f77ec8163b25bb72f391e Minor Changes to align implementation 1. Removed SKU - Billing Model is still under discussion, hence need not to be exposed to customers. 2. Enabled field ichanged to align with camel case. 3. 'throttleTillDate' in properties.action changed to 'throttlingInMin' to denote correct meaning and it’s data type changed to number instead of date. 4. 'status' to be removed in properties.action from examples. 5. 'severity' made a required field in properties.action. 6. Removed Examples from original spec json * Generated from fb180fb311d73934d0f5150f72638cc3de155ea0 Added Default Response payload in all APIs Changes - 1. Added Default Response payload in all APIs 2. Made azNs description more clear * Generated from fb180fb311d73934d0f5150f72638cc3de155ea0 Added Default Response payload in all APIs Changes - 1. Added Default Response payload in all APIs 2. Made azNs description more clear

* [AutoPR monitor/resource-manager] Added GA API version for Scheduled Query Rule (#2416) * Generated from d183bad923d3a0a4092d21203f850db6cde9f4e9 Resolving Comments Resolving Comments * Generated from df40ac3bbf17ea0180dd4adff2af3094065feca0 Made SKU as top level proprty and including generic error response format Couple of changes - 1. Made SKU as top level proprty as mentioned here - https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/resource-api-reference.md#put-resource 2. including generic error response format * Generated from 7578160670750a68d05f77ec8163b25bb72f391e Minor Changes to align implementation 1. Removed SKU - Billing Model is still under discussion, hence need not to be exposed to customers. 2. Enabled field ichanged to align with camel case. 3. 'throttleTillDate' in properties.action changed to 'throttlingInMin' to denote correct meaning and it’s data type changed to number instead of date. 4. 'status' to be removed in properties.action from examples. 5. 'severity' made a required field in properties.action. 6. Removed Examples from original spec json * Generated from fb180fb311d73934d0f5150f72638cc3de155ea0 Added Default Response payload in all APIs Changes - 1. Added Default Response payload in all APIs 2. Made azNs description more clear * Generated from fb180fb311d73934d0f5150f72638cc3de155ea0 Added Default Response payload in all APIs Changes - 1. Added Default Response payload in all APIs 2. Made azNs description more clear * [AutoPR monitor/resource-manager] Minor Updates - description text (#2513) * Generated from 0c826790271a1be2d4af5905ee0eb089b4260feb Merge pull request #1 from abversqr/MinorUpdates Minor updates * Generated from 1610a74a5c49c73a546972daca1e7a43798a8cea Merge branch 'master' into master * [AutoPR monitor/resource-manager] Add "autoMitigate" to Metric Alert API spec for 2018-03-01 (#2592) * Generated from d5b9b4545a8d15c70d3c8318d39e2f7b43229387 AutoMitigate changes * Generated from d5b9b4545a8d15c70d3c8318d39e2f7b43229387 AutoMitigate changes * [AutoPR monitor/resource-manager] [Monitor] Deconflict "Action" name in MetricAlert (#2617) * Generated from 35adc5e493c20a57e6e2cb35d87c578133d2b7a6 [Monitor] Deconflict "Action" name in MetricAlert Generates bad SDK. * Generated from ebfaf0bdd7f2bcf736598d8ec501f490a83d1268 Update reference to MetricAlertAction * [AutoPR monitor/resource-manager] Adding patch support for SQR API (#2596) * Generated from f53526896e5c001f79bd46ca892f825172b53abf Merge branch 'master' into patchsupport * Generated from f53526896e5c001f79bd46ca892f825172b53abf Merge branch 'master' into patchsupport * Generated from b37d3ace14508e3bc3f87ee29b7f2ad0b7025f67 Resolving multiple model issue Changes - 1. Renamed "MetricTrigger" to "LogMetricTrigger" 2. Aligned "Resources" to other specs * Rebuild by #2460 * Auto packaging

Generated from d183bad923d3a0a4092d21203f850db6cde9f4e9

3526cd4

Resolving Comments Resolving Comments

AutorestCI requested a review from lmazuel as a code owner April 17, 2018 17:48

AutorestCI mentioned this pull request Apr 17, 2018

Added GA API version for Scheduled Query Rule Azure/azure-rest-api-specs#2858

Merged

10 tasks

AutorestCI added the RestPRInProgress label Apr 17, 2018

AutorestCI added 4 commits April 18, 2018 18:15

Generated from fb180fb311d73934d0f5150f72638cc3de155ea0

ce23ad1

Added Default Response payload in all APIs Changes - 1. Added Default Response payload in all APIs 2. Made azNs description more clear

Generated from fb180fb311d73934d0f5150f72638cc3de155ea0

1fadbb9

Added Default Response payload in all APIs Changes - 1. Added Default Response payload in all APIs 2. Made azNs description more clear

AutorestCI added RestPRMerged and removed RestPRInProgress labels Apr 24, 2018

AutorestCI merged commit d19dcb8 into restapi_auto_monitor/resource-manager Apr 24, 2018

lmazuel deleted the restapi_auto_2858 branch April 27, 2018 01:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AutoPR monitor/resource-manager] Added GA API version for Scheduled Query Rule #2416

[AutoPR monitor/resource-manager] Added GA API version for Scheduled Query Rule #2416

AutorestCI commented Apr 17, 2018

AutorestCI commented Apr 17, 2018 •

edited

Loading

codecov-io commented Apr 17, 2018 •

edited

Loading

AutorestCI commented Apr 24, 2018

[AutoPR monitor/resource-manager] Added GA API version for Scheduled Query Rule #2416

[AutoPR monitor/resource-manager] Added GA API version for Scheduled Query Rule #2416

Conversation

AutorestCI commented Apr 17, 2018

AutorestCI commented Apr 17, 2018 • edited Loading

Installation instruction

Package azure-mgmt-monitor

Direct download

codecov-io commented Apr 17, 2018 • edited Loading

Codecov Report

AutorestCI commented Apr 24, 2018

AutorestCI commented Apr 17, 2018 •

edited

Loading

codecov-io commented Apr 17, 2018 •

edited

Loading