-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AutoPR monitor/resource-manager] [Monitor] Deconflict "Action" name in MetricAlert #2617
[AutoPR monitor/resource-manager] [Monitor] Deconflict "Action" name in MetricAlert #2617
Conversation
[Monitor] Deconflict "Action" name in MetricAlert Generates bad SDK.
(message created by the CI based on PR content) Installation instructionPackage azure-mgmt-monitorYou can install the package You can build a wheel to distribute for test using the following command: If you have a local clone of this repository, you can also do:
Or build a wheel file to distribute for testing:
Direct downloadYour files can be directly downloaded here: |
Codecov Report
@@ Coverage Diff @@
## restapi_auto_monitor/resource-manager #2617 +/- ##
=========================================================================
- Coverage 56.04% 54.48% -1.57%
=========================================================================
Files 6865 5474 -1391
Lines 156009 128412 -27597
=========================================================================
- Hits 87442 69965 -17477
+ Misses 68567 58447 -10120
Continue to review full report at Codecov.
|
Update reference to MetricAlertAction
…in MetricAlert (#2617) * Generated from 35adc5e493c20a57e6e2cb35d87c578133d2b7a6 [Monitor] Deconflict "Action" name in MetricAlert Generates bad SDK. * Generated from ebfaf0bdd7f2bcf736598d8ec501f490a83d1268 Update reference to MetricAlertAction
* [AutoPR monitor/resource-manager] Added GA API version for Scheduled Query Rule (#2416) * Generated from d183bad923d3a0a4092d21203f850db6cde9f4e9 Resolving Comments Resolving Comments * Generated from df40ac3bbf17ea0180dd4adff2af3094065feca0 Made SKU as top level proprty and including generic error response format Couple of changes - 1. Made SKU as top level proprty as mentioned here - https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/resource-api-reference.md#put-resource 2. including generic error response format * Generated from 7578160670750a68d05f77ec8163b25bb72f391e Minor Changes to align implementation 1. Removed SKU - Billing Model is still under discussion, hence need not to be exposed to customers. 2. Enabled field ichanged to align with camel case. 3. 'throttleTillDate' in properties.action changed to 'throttlingInMin' to denote correct meaning and it’s data type changed to number instead of date. 4. 'status' to be removed in properties.action from examples. 5. 'severity' made a required field in properties.action. 6. Removed Examples from original spec json * Generated from fb180fb311d73934d0f5150f72638cc3de155ea0 Added Default Response payload in all APIs Changes - 1. Added Default Response payload in all APIs 2. Made azNs description more clear * Generated from fb180fb311d73934d0f5150f72638cc3de155ea0 Added Default Response payload in all APIs Changes - 1. Added Default Response payload in all APIs 2. Made azNs description more clear * [AutoPR monitor/resource-manager] Minor Updates - description text (#2513) * Generated from 0c826790271a1be2d4af5905ee0eb089b4260feb Merge pull request #1 from abversqr/MinorUpdates Minor updates * Generated from 1610a74a5c49c73a546972daca1e7a43798a8cea Merge branch 'master' into master * [AutoPR monitor/resource-manager] Add "autoMitigate" to Metric Alert API spec for 2018-03-01 (#2592) * Generated from d5b9b4545a8d15c70d3c8318d39e2f7b43229387 AutoMitigate changes * Generated from d5b9b4545a8d15c70d3c8318d39e2f7b43229387 AutoMitigate changes * [AutoPR monitor/resource-manager] [Monitor] Deconflict "Action" name in MetricAlert (#2617) * Generated from 35adc5e493c20a57e6e2cb35d87c578133d2b7a6 [Monitor] Deconflict "Action" name in MetricAlert Generates bad SDK. * Generated from ebfaf0bdd7f2bcf736598d8ec501f490a83d1268 Update reference to MetricAlertAction * [AutoPR monitor/resource-manager] Adding patch support for SQR API (#2596) * Generated from f53526896e5c001f79bd46ca892f825172b53abf Merge branch 'master' into patchsupport * Generated from f53526896e5c001f79bd46ca892f825172b53abf Merge branch 'master' into patchsupport * Generated from b37d3ace14508e3bc3f87ee29b7f2ad0b7025f67 Resolving multiple model issue Changes - 1. Renamed "MetricTrigger" to "LogMetricTrigger" 2. Aligned "Resources" to other specs * Rebuild by #2460 * Auto packaging
Created to sync Azure/azure-rest-api-specs#3128