Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[keyvault] Drop Python 3.6 support in packages #25449

Merged
merged 11 commits into from
Aug 3, 2022

Conversation

wonhyeongseo
Copy link
Contributor

@wonhyeongseo wonhyeongseo commented Jul 28, 2022

Description

Fix #25077

Is your feature request related to a problem? Please describe.
In accordance with the August Milestone of Azure for dropping Python 3.6 support, I have made changes to the keyvault packages.

Describe the solution you'd like
Drop Python 3.6 support and add 3.10 to the supported versions list.

Describe alternatives you've considered
None

Additional context
#25077
#22367
4a7fc09

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added KeyVault customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Jul 28, 2022
@ghost
Copy link

ghost commented Jul 28, 2022

Thank you for your contribution wonhyeongseo! We will review the pull request and get back to you soon.

@wonhyeongseo wonhyeongseo force-pushed the python-3.7 branch 2 times, most recently from f25d75d to e74ddb7 Compare July 28, 2022 10:45
[keyvault] Drop Python 3.6 support in packages

chore: fix CHANGELOG.md typo
@mccoyp
Copy link
Member

mccoyp commented Jul 30, 2022

Hi @wonhyeongseo, thank you so much for opening a PR! I'll take a look at this as soon as I can next week.

@wonhyeongseo
Copy link
Contributor Author

wonhyeongseo commented Jul 30, 2022

@mccoyp Thank you for the review! I just can't seem to grasp the pylint error in the Build pipeline. When you commited 8 days ago here, it seems to have passed fine. So I would like any kind of input to pass the pipeline- for an easier review process on your part. Thank you again for commenting on my first PR.

@mccoyp
Copy link
Member

mccoyp commented Aug 1, 2022

@mccoyp Thank you for the review! I just can't seem to grasp the pylint error in the Build pipeline. When you commited 8 days ago here, it seems to have passed fine. So I would like any kind of input to pass the pipeline- for an easier review process on your part. Thank you again for commenting on my first PR.

The current pipeline failures are likely coming from an unrelated change that updated the version of some pylint guidelines -- I'm fixing that at the moment 🙂 I'll let you know if you need to rebase your PR with the main branch once that's done.

scbedd
scbedd previously requested changes Aug 1, 2022
Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes to revert duplicate py3.9 versions added to the matrix configs. Everything else looks good, but I would prefer to let the keyvault owner @mccoyp sign off on this!

@mccoyp mccoyp mentioned this pull request Aug 2, 2022
6 tasks
@wonhyeongseo
Copy link
Contributor Author

@scbedd @mccoyp @lmazuel
Thank you for your fantastic reviews and comments! I will continue to contribute to Azure SDK knowing that I can learn rapidly from awesome people like you! Have a great day!

Copy link
Member

@mccoyp mccoyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for updating the PR! This all looks good to me. The pipeline is still red because of the failure being worked on in #25519, but I'll go ahead and merge this since it's unrelated.

@mccoyp
Copy link
Member

mccoyp commented Aug 3, 2022

/check-enforcer override

@mccoyp mccoyp dismissed scbedd’s stale review August 3, 2022 00:45

Changes addressed (thanks for the review, Scott!)

@mccoyp mccoyp merged commit 29561e3 into Azure:main Aug 3, 2022
@wonhyeongseo wonhyeongseo deleted the python-3.7 branch August 3, 2022 01:09
wonder6845 pushed a commit to wonder6845/azure-sdk-for-python that referenced this pull request Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. KeyVault
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Key Vault] Drop Python 3.6 support
4 participants