-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[keyvault] Drop Python 3.6 support in packages #25449
Conversation
Thank you for your contribution wonhyeongseo! We will review the pull request and get back to you soon. |
f25d75d
to
e74ddb7
Compare
[keyvault] Drop Python 3.6 support in packages chore: fix CHANGELOG.md typo
Hi @wonhyeongseo, thank you so much for opening a PR! I'll take a look at this as soon as I can next week. |
@mccoyp Thank you for the review! I just can't seem to grasp the pylint error in the Build pipeline. When you commited 8 days ago here, it seems to have passed fine. So I would like any kind of input to pass the pipeline- for an easier review process on your part. Thank you again for commenting on my first PR. |
The current pipeline failures are likely coming from an unrelated change that updated the version of some pylint guidelines -- I'm fixing that at the moment 🙂 I'll let you know if you need to rebase your PR with the |
eng/pipelines/templates/stages/platform-matrix-cryptography-dependency.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes to revert duplicate py3.9
versions added to the matrix configs. Everything else looks good, but I would prefer to let the keyvault owner @mccoyp sign off on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for updating the PR! This all looks good to me. The pipeline is still red because of the failure being worked on in #25519, but I'll go ahead and merge this since it's unrelated.
/check-enforcer override |
Changes addressed (thanks for the review, Scott!)
Description
Fix #25077
Is your feature request related to a problem? Please describe.
In accordance with the August Milestone of Azure for dropping Python 3.6 support, I have made changes to the keyvault packages.
Describe the solution you'd like
Drop Python 3.6 support and add 3.10 to the supported versions list.
Describe alternatives you've considered
None
Additional context
#25077
#22367
4a7fc09
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines