Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target 3.10 in mypy.ini #25502

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Target 3.10 in mypy.ini #25502

merged 1 commit into from
Aug 2, 2022

Conversation

mccoyp
Copy link
Member

@mccoyp mccoyp commented Aug 2, 2022

Description

A few mypy.ini files across the repo are targeting Python 3.6, when they should target the most recent available version (3.10) instead. Discovered in #25449 (thanks, @wonhyeongseo!)

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.
    • Verifying updates with CI

@ghost ghost added Storage Storage Service (Queues, Blobs, Files) App Configuration Azure.ApplicationModel.Configuration Search Cognitive - Form Recognizer Cognitive - Metrics Advisor Tables labels Aug 2, 2022
@azure-sdk
Copy link
Collaborator

azure-sdk commented Aug 2, 2022 •
edited
Loading

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-ai-metricsadvisor
azure-search-documents

@mccoyp mccoyp marked this pull request as ready for review August 2, 2022 17:26
xiangyan99
xiangyan99 approved these changes Aug 2, 2022
View reviewed changes
Copy link
Member

@xiangyan99 xiangyan99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

kristapratico
kristapratico approved these changes Aug 2, 2022
View reviewed changes
Copy link
Member

@kristapratico kristapratico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mccoyp
Copy link
Member Author

mccoyp commented Aug 2, 2022

Tables CI failures are from a mindependency failure that should/will be fixed separately. Gonna override check enforcer on this one since the change isn't resulting in new failures.

@mccoyp
Copy link
Member Author

mccoyp commented Aug 2, 2022

/check-enforcer override

@mccoyp mccoyp merged commit 4a758e8 into Azure:main Aug 2, 2022
@mccoyp mccoyp deleted the mypy-ini branch August 2, 2022 17:43
wonder6845 pushed a commit to wonder6845/azure-sdk-for-python that referenced this pull request Aug 23, 2022
@mccoyp @wonder6845
Target 3.10 in mypy.ini (Azure#25502)
5261c83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangyan99 xiangyan99 xiangyan99 approved these changes

@kristapratico kristapratico kristapratico approved these changes

@annatisch annatisch Awaiting requested review from annatisch annatisch is a code owner

@YalinLi0312 YalinLi0312 Awaiting requested review from YalinLi0312 YalinLi0312 is a code owner

@iscai-msft iscai-msft Awaiting requested review from iscai-msft iscai-msft is a code owner

@catalinaperalta catalinaperalta Awaiting requested review from catalinaperalta

@rakshith91 rakshith91 Awaiting requested review from rakshith91

@lmazuel lmazuel Awaiting requested review from lmazuel

@lzchen lzchen Awaiting requested review from lzchen lzchen is a code owner

@hectorhdzg hectorhdzg Awaiting requested review from hectorhdzg hectorhdzg is a code owner

@jeremydvoss jeremydvoss Awaiting requested review from jeremydvoss jeremydvoss is a code owner

@jalauzon-msft jalauzon-msft Awaiting requested review from jalauzon-msft jalauzon-msft is a code owner

@vincenttran-msft vincenttran-msft Awaiting requested review from vincenttran-msft vincenttran-msft is a code owner

Assignees
No one assigned
Labels
App Configuration Azure.ApplicationModel.Configuration Cognitive - Form Recognizer Cognitive - Metrics Advisor Search Storage Storage Service (Queues, Blobs, Files) Tables
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mccoyp @azure-sdk @xiangyan99 @kristapratico