[AutoPR] datafactory/resource-manager #5747
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| recursive-include tests *.py *.yaml | ||
| include *.rst | ||
| include azure/__init__.py | ||
| include azure/mgmt/__init__.py | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| # coding=utf-8 | ||
| # -------------------------------------------------------------------------- | ||
| # Copyright (c) Microsoft Corporation. All rights reserved. | ||
| # Licensed under the MIT License. See License.txt in the project root for | ||
| # license information. | ||
| # | ||
| # Code generated by Microsoft (R) AutoRest Code Generator. | ||
| # Changes may cause incorrect behavior and will be lost if the code is | ||
| # regenerated. | ||
| # -------------------------------------------------------------------------- | ||
| from msrestazure import AzureConfiguration | ||
|
|
||
| from .version import VERSION | ||
|
|
||
|
|
||
| class DataFactoryManagementClientConfiguration(AzureConfiguration): | ||
| """Configuration for DataFactoryManagementClient | ||
| Note that all parameters used to create this instance are saved as instance | ||
| attributes. | ||
|
|
||
| :param credentials: Credentials needed for the client to connect to Azure. | ||
| :type credentials: :mod:`A msrestazure Credentials | ||
| object<msrestazure.azure_active_directory>` | ||
| :param subscription_id: The subscription identifier. | ||
| :type subscription_id: str | ||
| :param str base_url: Service URL | ||
| """ | ||
|
|
||
| def __init__( | ||
| self, credentials, subscription_id, base_url=None): | ||
|
|
||
| if credentials is None: | ||
| raise ValueError("Parameter 'credentials' must not be None.") | ||
| if subscription_id is None: | ||
| raise ValueError("Parameter 'subscription_id' must not be None.") | ||
| if not base_url: | ||
| base_url = 'https://management.azure.com' | ||
|
|
||
| super(DataFactoryManagementClientConfiguration, self).__init__(base_url) | ||
|
|
||
| # Starting Autorest.Python 4.0.64, make connection pool activated by default | ||
| self.keep_alive = True | ||
|
|
||
| self.add_user_agent('azure-mgmt-datafactory/{}'.format(VERSION)) | ||
| self.add_user_agent('Azure-SDK-For-Python') | ||
|
|
||
| self.credentials = credentials | ||
| self.subscription_id = subscription_id |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given there are SDK breaking changes in this release, shouldn't the major version change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessarily (https://github.com/Azure/azure-sdk-for-python/blob/master/doc/dev/mgmt/mgmt_release.md - pls check bottom of the page).
0.7.0 also had breaking changes.
Unless you want to specifically change to 1.0.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine, let's re;ease with 0.8.0. Thanks!