Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare-Release should strip empty sections in changelog entry #1895

Closed
weshaggard opened this issue Aug 11, 2021 · 1 comment
Closed

Prepare-Release should strip empty sections in changelog entry #1895

weshaggard opened this issue Aug 11, 2021 · 1 comment
Assignees
@chidozieononiwu
Labels
Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Comments

@weshaggard
Copy link
Member

As part of prepare-release instead of erroring when there is an empty section we should just strip the empty sections. We should still warn if there are none of the recommended sections after we strip the empty ones.
@weshaggard weshaggard added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Aug 11, 2021
@weshaggard weshaggard mentioned this issue Aug 11, 2021
Closed
@chidozieononiwu chidozieononiwu mentioned this issue Aug 25, 2021
Merged
ghost pushed a commit that referenced this issue Aug 26, 2021
@chidozieononiwu
Strip empty changelog sections before release (#1935)
f633e92 
When updating the CHANGELOG.md for release, this will strip out all the headers with empty sections.
Should fix #1878 and #1895
@chidozieononiwu
Copy link
Member

Fixed with #1935

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chidozieononiwu chidozieononiwu

Labels
Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weshaggard @chidozieononiwu