Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip empty changelog sections before release #1935

Merged
1 commit merged into from
Aug 26, 2021
Merged

Strip empty changelog sections before release #1935

1 commit merged into from
Aug 26, 2021

Conversation

chidozieononiwu
Copy link
Member

When updating the CHANGELOG.md for release, this will strip out all the headers with empty sections.
Should fix #1878 and #1895

@chidozieononiwu chidozieononiwu requested a review from a team as a code owner August 25, 2021 23:27
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

heaths
heaths approved these changes Aug 26, 2021
View reviewed changes
eng/common/scripts/Update-ChangeLog.ps1 Outdated Show resolved Hide resolved
@chidozieononiwu chidozieononiwu force-pushed the VerifyChangeLogInPrepReleaseScript branch from 4c9ef0f to b25562e Compare August 26, 2021 21:24
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@chidozieononiwu chidozieononiwu force-pushed the VerifyChangeLogInPrepReleaseScript branch from b25562e to 47e6773 Compare August 26, 2021 21:58
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Aug 26, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@ghost
Copy link

ghost commented Aug 26, 2021

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit f633e92 into Azure:main Aug 26, 2021
@chidozieononiwu chidozieononiwu mentioned this pull request Aug 26, 2021
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard left review comments

@heaths heaths heaths approved these changes

@xirzec xirzec Awaiting requested review from xirzec

@ramya-rao-a ramya-rao-a Awaiting requested review from ramya-rao-a

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[EngSys] Validate Changelog before merge instead of during release
4 participants
@chidozieononiwu @azure-sdk @heaths @weshaggard