Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce "job" version of prepare-pipelines.yml, with "pool" defined to use Ubuntu 20.04 #4930

Merged
1 commit merged into from
Dec 12, 2022

Conversation

konrad-jamrozik
Copy link
Contributor

@konrad-jamrozik konrad-jamrozik commented Dec 9, 2022

This PR, in tandem with PRs #4915 and #4916, addresses #4888. This PR subsumes the abandoned PR of #4911.

Specifically, this PR ensures that prepare-pipelines.yml is configured to use specific pool, set to use Ubuntu 20.04:

pool:
  name: azsdk-pool-mms-ubuntu-2004-general
  vmImage: MMSUbuntu20.04

Without the pool definition pointing to Ubuntu 20.04, the steps within the file used an implicit default, which resolves to ubuntu-latest. This caused breakage as explained in #4888. Setting the pool to Ubuntu 20.04 will allow us to:

Technical considerations of the changes

Testing done

I have confirmed the proposed modification to the .yml file will work by modifying the existing prepare-pipelines.yml directly to have exactly the same contents as the /jobs/prepare-pipelines.yml introduced in this PR, and observing the relevant build succeeds on azure-sdk-for-java:

image

while it failed before this change:

image

Footnotes

[1] for example, internal / java / prepare-pipelines pipeline, or internal / net / prepare-pipelines pipeline.

[2] as evidenced by the Ubuntu 20.04 image software page, it has .NET Core 3.1. The pool definition value points to a 1ES hosted image which has the software listed on that page, as explained by this comment: #4888 (comment).

[3] See this comment: #4888 (comment).

[4] as evidenced by the Ubuntu 22.04 image software page.

[5] Observe that on pool definition YAML reference page, we can read:

Properties that use this definition: pipeline.pool, stages.stage.pool, jobs.job.pool, jobs.deployment.pool.

i.e. steps.pool is not listed.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@konrad-jamrozik
Copy link
Contributor Author

/check-enforcer override

@konrad-jamrozik
Copy link
Contributor Author

I have approved all releases from #4930 (comment)

@ghost
Copy link

ghost commented Dec 12, 2022

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants