Delete obsolete CheckEnforcer tool #4963
Conversation
konrad-jamrozik
requested review from
praveenkuttappan and
weshaggard
as code owners
konrad-jamrozik
changed the title
|
FYI there is still one more repository using the old check enforcer, but I think it's ok to start deleting the code while we keep the service running. I have an update to migrate this repository here, but was blocked at the time on a minor issue. I will follow-up on this. @konrad-jamrozik it is ok to delete the readme, the docs have been moved/updated and live here. The active check-enforcer source is in that same repo here. |
konrad-jamrozik
changed the title
konrad-jamrozik
force-pushed
the
users/kojamroz/iss_4888_remove_check_enforcer
branch
from
b721955
to
7b6d506
Compare
@benbp for the source link, you linked just to the repo, but I guess you meant perhaps to link to the main.go file? Also, please note that since you approved this PR I have updated the main README to point to the new Check Enforcer location, and I have removed the I will keep this PR open until we are fully migrated and we can decommission the tool. Just to avoid potential confusion on what is going on. |
eng/CHECKENFORCER
Outdated
| @@ -1,41 +0,0 @@ | |||
| format: v0.1-alpha | |||
There was a problem hiding this comment.
@benbp did you have any plans to use this configuration with the new checkenforcer? If not then we should probably remove this from the other repos too.
There was a problem hiding this comment.
No plans. I have an item on my todo to remove the other markdown files from the repos.
There was a problem hiding this comment.
Ok make sure your todo list translates to github issues so we don't lose them.
There was a problem hiding this comment.
@benbp I can go ahead and get rid of all the CHECKENFORCER files, given I already work on this.
Can I maybe also somehow assist with merging this?
Azure/azure-dev#981
Is this about figuring out better name for the event.yml file?
Just hoping here to wrap-up this removal work and not leave anything dangling.
There was a problem hiding this comment.
@benbp I can go ahead and get rid of all the
CHECKENFORCERfiles, given I already work on this.Can I maybe also somehow assist with merging this? Azure/azure-dev#981
Is this about figuring out better name for the
event.ymlfile?Just hoping here to wrap-up this removal work and not leave anything dangling.
Postponed until:
konrad-jamrozik
added
the
Central-EngSys
|
We are having discussion about this PR on internal Teams chat on Looks it the new GitHub-action based Check Enforcer possibly cannot be triggered by other GitHub workflows, which makes it unsuitable for https://github.com/Azure/azure-dev, as it uses such workflows. We are currently discussing possible approaches. |
|
I am closing this PR for now, as there is more work to be done before we can decommission the tool. I captured our findings and work required here: Once the prerequisite work is done, we can re-open this PR. |
konrad-jamrozik
deleted the
users/kojamroz/iss_4888_remove_check_enforcer
branch
konrad-jamrozik
restored the
users/kojamroz/iss_4888_remove_check_enforcer
branch
|
@benbp I have deleted the resource groups used by the legacy CheckEnforcer, per this comment. I believe now we can delete the tool source itself, hence reopening this PR. Note that the deleted |
konrad-jamrozik
force-pushed
the
users/kojamroz/iss_4888_remove_check_enforcer
branch
from
9c2c2f3
to
9376f64
Compare
- Update README for Check Enforcer - Delete obsolete CHECKENFORCER file
konrad-jamrozik
force-pushed
the
users/kojamroz/iss_4888_remove_check_enforcer
branch
from
9376f64
to
4f6541e
Compare
|
/check-enforcer override |
konrad-jamrozik
deleted the
users/kojamroz/iss_4888_remove_check_enforcer
branch
Deleting obsolete, no longer used sources of check enforcer, per this comment: #4937 (review). Now we use a different version of it, based on GitHub actions.
Related work item:
azure-devrepo to use the new Check Enforcer and decommission the obsoleteCheckEnforcertool #4991Once this PR is merged, I will remove the internals / tool - check-enforcer pipeline as well.
@weshaggard @benbp I believe the README in the removed directory (
tools/check-enforcer/README) probably has bunch of useful information and should be reclaimed/moved. I also want to use this as an opportunity to review and update our check enforcer docs. Hence my questions:docdirectory, and link to it from top-level README?Thanks!