-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set .NET used by our tools to net6.0
+ minor updates to .sln files
#4937
Conversation
net6.0
+ minor updates to .sln files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving changes under tools/http-fault-injector
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 thank you for doing this! For check-enforcer and possibly webhook router, we can start to delete those projects entirely, I think. @hallipr just to double check, nothing of yours relies on the webhook-router eventhubs, right?
If so, I will make a separate PR to delete these projects. @weshaggard I am merging, assuming Ben's approval is enough. Let me know in case that's incorrect assumption xD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR addresses issues #4888, #4934 and #4935 for the following tools and other projects, by migrating their target frameworks to
net6.0
, and ensuring that theirci.yml
setsDotNetCoreVersion: 6.0.403
:version-guard
;CreateRuleFabricBot
and its tests;code-owners-parser
and its tests. This required disabling execution ofget-codeowners.ps1
script as part of the test suite. Follow-up work to re-enable it: Re-enable code-owners-parser get-codeowners.ps1 test script after migration to net6.0 is done #4938;<TargetFramework>netstandard2.0
tonet6.0
inAzure.ClientSdk.Analyzers
andCodeOwnersParser
#5029notification-configuration
;identity-resolution
;generator
(i.e.Stress.Generator
) and its tests;Azure.ClientSdk.Analyzers
and its tests;SwaggerApiParser
. This only required settingci.yml
to point to .NET 6, as it was already targetingnet6.0
;snippet-generator
and its tests;tools\agent-time-extractor\AgentTimeExtractor\AgentTimeExtractor.csproj
;src\dotnet\APIView\TestLibrary\TestLibrary.csproj
, which was usingnetcoreapp2.1
which is out of support since August 2021, but the APIView pipeline and the pipeline seems to be failing due to unrelated reasons, so usage ofnetcoreapp2.1
seems to be non-blocking. Nevertheless, I updated it tonet6.0
anyway;Azure.Sdk.Tools.HttpFaultInjector
;Azure.Sdk.Tools.HttpFaultInjector.StorageBlobsSample
;Azure.Sdk.Tools.HttpFaultInjector.HttpClientSample
;TestProxy
, but not theTestProxy
itself, as it was already onnet6.0
, albeit it also targetsnet5.0
, which I left unchanged;PixelServer
, which required adding an import toProgram.cs
. Note I couldn't find a correspondingci.yml
or pipeline for it.Tools not updated to
net6.0
in this PR<TargetFramework>
occurrences not migrated as part of this PR, and why:netstandard
as it is compatible with .NET 6.0;tools\pipeline-generator\Azure.Sdk.Tools.PipelineGenerator\Azure.Sdk.Tools.PipelineGenerator.csproj
, because it is done in PR Update PipelineGenerator target framework fromnetcoreapp3.1
tonet6.0
#4915tools\check-enforcer\Azure.Sdk.Tools.CheckEnforcer\Azure.Sdk.Tools.CheckEnforcer.csproj
, as it usesarchetype-sdk-tool-azure-function.yml
archetype, which doesn't support theDotNetCoreVersion
override.CheckEnforcer
currently targetsnetcoreapp3.1
;tools\github-issues\Azure.Sdk.Tools.GitHubIssues\Azure.Sdk.Tools.GitHubIssues.csproj
, for the same reason ascheck-enforcer
.GitHubIssues
currently targetsnetcoreapp3.1
.tools\webhook-router\Azure.Sdk.Tools.WebhookRouter\Azure.Sdk.Tools.WebhookRouter.csproj
, for the same reasons ascheck-enforcer
.WebhookRouter
currently targetnetcoreapp3.1
.Additional remarks
For a list of all PRs doing migration to
net6.0
, see this comment:As a secondary mini-refactoring, this PR also adds
ci.yml
files to corresponding.sln
files and updates the.sln
files Visual Studio version used to VS 2022.