Move supporting matrix generator assets out of `eng/common` #5027

konrad-jamrozik · 2022-12-23T08:53:24Z

This PR contributes to addressing:

Update job-matrix samples and tests .NET SDKs to net6.0 and Ubuntu images to 22.04, and move them out of eng/common #4995

by moving out of eng/common/scripts/job-matrix assets that should not be mirrored to language repos. These assets include documentation, samples, and tests.

Changes made

Moved contents of eng/common/scripts/job-matrix/README.md to newly introduced doc/common/matrix_generator.md;
Replaced contents of eng/common/scripts/job-matrix/README.md with a pointer to doc/common/matrix_generator.md;
- Follow-up: Hyperlink from eng/common job-matrix README to matrix_generator.md #5059;
Moved contents of eng/common/scripts/job-matrix/scripts and eng/common/scripts/job-matrix/tests to corresponding directories in newly introduced directory of
eng/common-tests/matrix-generator.

Note the introduced directory and doc file use matrix generator as name, not job matrix. This matches the terminology used in the documentation.

Changes NOT made

The contents of files moved from scripts and tests directories have not been updated at all. The files have been moved unchanged.
The contents of the moved README.md have not been updated, even though they should, as they refer to paths that have changed as a result of the move. To keep the PR diff clean, I will instead update them in a separate PR:
- Update doc/common/matrix_generator.md: review and rewrite for clarity #5023

azure-sdk · 2022-12-23T08:58:02Z

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

doc/common/matrix_generator.md

benbp

Minor updates to the doc to point to the new test location. Otherwise LGTM, thanks!

Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>

azure-sdk · 2022-12-29T22:40:17Z

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

doc/common/matrix_generator.md

weshaggard

Split looks good. Might need to update a couple paths in the docs file though.

azure-sdk · 2023-01-05T00:09:50Z

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

ghost · 2023-01-05T03:06:16Z

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

…5059) This PR is a follow-up to - #5027 This change couldn't have been made before #5027 was merged because it caused CI link validation to fail.

…ake the tests runnable by `common-tests/ci.yml`. (#5095) This PR fixes paths I forgot to update when I did this PR: - #5027 And as such this PR contributes to addressing: - #4995 It also adds `UnitTest` tags to the `matrix-generator` tests so [`common-tests/ci.yml` pipeline](https://dev.azure.com/azure-sdk/internal/_build?definitionId=5809) executes them. ### Related work - #5098

move things out from eng/common/scripts/job-matrix

f8fc363

konrad-jamrozik requested review from sima-zhu, weshaggard, benbp and a team as code owners December 23, 2022 08:53

konrad-jamrozik mentioned this pull request Dec 23, 2022

Update doc/common/matrix_generator.md: review and rewrite for clarity #5023

Merged

konrad-jamrozik self-assigned this Dec 23, 2022

konrad-jamrozik added the Central-EngSys This issue is owned by the Engineering System team. label Dec 23, 2022

konrad-jamrozik changed the title ~~Move matrix generator assets out of eng/common~~ Move supporting matrix generator assets out of eng/common Dec 23, 2022

konrad-jamrozik mentioned this pull request Dec 28, 2022

The template for prepare-pipelines is broken by the move to ubuntu-22.04 #4888

Closed

benbp reviewed Dec 29, 2022

View reviewed changes

doc/common/matrix_generator.md Outdated Show resolved Hide resolved

benbp reviewed Dec 29, 2022

View reviewed changes

doc/common/matrix_generator.md Outdated Show resolved Hide resolved

benbp approved these changes Dec 29, 2022

View reviewed changes

Konrad Jamrozik and others added 2 commits December 29, 2022 14:35

Update doc/common/matrix_generator.md

eb074bf

Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>

Update doc/common/matrix_generator.md

c82bb9f

Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>

weshaggard reviewed Jan 4, 2023

View reviewed changes

doc/common/matrix_generator.md Outdated Show resolved Hide resolved

weshaggard approved these changes Jan 4, 2023

View reviewed changes

weshaggard mentioned this pull request Jan 4, 2023

Adding test pipeline for common-tests #5040

Merged

fix paths to pass CI/CD link verification

f9350e5

fix broken link for CI/CD verification

745370c

azure-sdk added the auto-merge label Jan 5, 2023

ghost merged commit ee39973 into main Jan 5, 2023

ghost deleted the users/kojamroz/iss_4995_move branch January 5, 2023 03:07

konrad-jamrozik mentioned this pull request Jan 5, 2023

Hyperlink from eng/common job-matrix README to matrix_generator.md #5059

Merged

konrad-jamrozik mentioned this pull request Jan 9, 2023

Fix broken relative paths in matrix-generator tests and samples + make the tests runnable by common-tests/ci.yml. #5095

Merged

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move supporting matrix generator assets out of `eng/common` #5027

Move supporting matrix generator assets out of `eng/common` #5027

konrad-jamrozik commented Dec 23, 2022 •

edited

Loading

azure-sdk commented Dec 23, 2022

benbp left a comment

azure-sdk commented Dec 29, 2022

weshaggard left a comment

azure-sdk commented Jan 5, 2023

ghost commented Jan 5, 2023

Move supporting matrix generator assets out of eng/common #5027

Move supporting matrix generator assets out of eng/common #5027

Conversation

konrad-jamrozik commented Dec 23, 2022 • edited Loading

Changes made

Changes NOT made

azure-sdk commented Dec 23, 2022

benbp left a comment

Choose a reason for hiding this comment

azure-sdk commented Dec 29, 2022

weshaggard left a comment

Choose a reason for hiding this comment

azure-sdk commented Jan 5, 2023

ghost commented Jan 5, 2023

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Move supporting matrix generator assets out of `eng/common` #5027

Move supporting matrix generator assets out of `eng/common` #5027

konrad-jamrozik commented Dec 23, 2022 •

edited

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.