Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update job-matrix samples and tests .NET SDKs to net6.0 and Ubuntu images to 22.04, and move them out of eng/common #4995

Closed
konrad-jamrozik opened this issue Dec 20, 2022 · 0 comments
Assignees
Labels
Central-EngSys This issue is owned by the Engineering System team.

Comments

@konrad-jamrozik
Copy link
Contributor

konrad-jamrozik commented Dec 20, 2022

The job-matrix tests and samples need following updates:

This issue is related to:

@konrad-jamrozik konrad-jamrozik added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. Central-EngSys This issue is owned by the Engineering System team. labels Dec 20, 2022
@konrad-jamrozik konrad-jamrozik changed the title Update job-matrix samples and tests .NET SDKs to net6.0and Ubuntu images to 22.04, and move them out of eng/common Update job-matrix samples and tests .NET SDKs to net6.0 and Ubuntu images to 22.04, and move them out of eng/common Dec 20, 2022
@konrad-jamrozik konrad-jamrozik self-assigned this Dec 21, 2022
@konrad-jamrozik konrad-jamrozik removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 21, 2022
ghost pushed a commit that referenced this issue Jan 5, 2023
This PR contributes to addressing:
- #4995 

by moving out of `eng/common/scripts/job-matrix` assets that should not be mirrored to language repos. These assets include documentation, samples, and tests.

## Changes made

- Moved contents of `eng/common/scripts/job-matrix/README.md` to newly introduced `doc/common/matrix_generator.md`;
- Replaced contents of `eng/common/scripts/job-matrix/README.md` with a pointer to `doc/common/matrix_generator.md`;
- Moved contents of `eng/common/scripts/job-matrix/scripts` and `eng/common/scripts/job-matrix/tests` to corresponding directories in newly introduced directory of 
`eng/common-tests/matrix-generator`.

Note the introduced directory and doc file use `matrix generator` as name, not `job matrix`. This matches the terminology used in the documentation.

## Changes NOT made

- The contents of files moved from `scripts` and `tests` directories have not been updated at all. The files have been moved unchanged.
- The contents of the moved `README.md` have not been updated, even though they should, as they refer to paths that have changed as a result of the move. To keep the PR diff clean, I will instead update them in a separate PR:
  - #5023
ghost pushed a commit that referenced this issue Jan 10, 2023
…ake the tests runnable by `common-tests/ci.yml`. (#5095)

This PR fixes paths I forgot to update when I did this PR:
- #5027

And as such this PR contributes to addressing:
- #4995

It also adds `UnitTest` tags to the `matrix-generator` tests so [`common-tests/ci.yml` pipeline](https://dev.azure.com/azure-sdk/internal/_build?definitionId=5809) executes them.

### Related work

- #5098
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Development

No branches or pull requests

1 participant