Remove the obsolete, prefix-based CODEOWNERS matcher
#5431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konrad-jamrozik
added
the
Central-EngSys
konrad-jamrozik
changed the title
CODEOWNERS matcherCODEOWNERS matcher & related tests
|
The following pipelines have been queued for testing: |
This was referenced Feb 13, 2023
konrad-jamrozik
changed the title
CODEOWNERS matcher & related testsCODEOWNERS matcher
ghost
pushed a commit
that referenced
this pull request
Feb 14, 2023
…le + remove obsolete tests (#5437) This is a follow-up PR to: - #5241 That PR was supposed to enable the regex-based matcher everywhere, but didn't. This PR fixes that. This PR also: - removes the obsolete `ProgramSimplePathTests` test class; it is superseded by `ProgramGlobPathTests`, which is renamed in: - #5431 - removes obsolete tests from `get-codeowners.ps1` This PR is a prerequisite for following PRs: - #5103 - #5431
ghost
pushed a commit
that referenced
this pull request
Feb 16, 2023
…ers` executable + add some tests; make assorted refactorings (#5103) This PR is part of work required in preparation to merge: - #5088 Specifically, to enable review of ownership changes due to upcoming wildcards support, as explained in: - #5088 (comment) As such, this PR contributes to: - #2770 This PR is a prerequisite for following PRs: - #5431 ### Merging prerequisite This PR can be merged only after the following PRs are merged and relevant NuGet package published - #5437 - #5104 This is because this PR depends on that NuGet package.
konrad-jamrozik
force-pushed
the
users/kojamroz/remove_prefix
branch
from
42ade90
to
303395e
Compare
remove ProgramSimplePathTests; rename ProgramGlobPathTests to RetrieveCodeOwnersProgramTests remove the obsolete prefix-based `CODEOWNERS` matcher
konrad-jamrozik
force-pushed
the
users/kojamroz/remove_prefix
branch
from
303395e
to
daa828d
Compare
|
The following pipelines have been queued for testing: |
weshaggard
reviewed
Feb 22, 2023
| @@ -38,19 +36,17 @@ public static List<CodeownersEntry> GetCodeownersEntries(string codeownersConten | |||
|
|
|||
| public static CodeownersEntry GetMatchingCodeownersEntry( | |||
| string targetPath, | |||
| string codeownersFilePathOrUrl, | |||
| bool useRegexMatcher = UseRegexMatcherDefault) | |||
| string codeownersFilePathOrUrl) | |||
There was a problem hiding this comment.
@JimSuplizio FYI if you are passing this third parameter and not using the default this will break when you get this update.
weshaggard
approved these changes
Feb 23, 2023
konrad-jamrozik
pushed a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Feb 23, 2023
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#5431 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Konrad Jamrozik <kojamroz@microsoft.com>
|
/check-enforcer override |
ghost
pushed a commit
that referenced
this pull request
Feb 24, 2023
Update the NuGet packages using CODEOWNERS parser to pick up these changes: - #5431 - #5518 Relevant NuGet feeds: - https://dev.azure.com/azure-sdk/public/_artifacts/feed/azure-sdk-for-net/NuGet/Azure.Sdk.Tools.RetrieveCodeOwners/overview - https://dev.azure.com/azure-sdk/public/_artifacts/feed/azure-sdk-for-net/NuGet/Azure.Sdk.Tools.NotificationConfiguration/overview And builds powering them: - https://dev.azure.com/azure-sdk/internal/_build?definitionId=3188 - https://dev.azure.com/azure-sdk/internal/_build?definitionId=1815 Related work: - #2770
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up to:
With this PR, now only the new, regex-based, wildcard-supporting
CODEOWNERSmatcher is present in the codebase.This PR also:
ProgramSimplePathTestsclass (restored and upgraded in Restore and overhaul simple target path tests intoRetrieveCodeOwnersProgramTests#5518);ProgramGlobPathTeststoRetrieveCodeOwnersProgramTests;get-codeowners.ps1.Related PR:
get-codeowners.ps1to work with the updatedRetrieveCodeOwnersexecutable + add some tests; make assorted refactorings #5103This PR contributes to:
Merging prerequisite
This PR can be merged only after the following PRs are merged and relevant NuGet package published
get-codeowners.ps1to work with the updatedRetrieveCodeOwnersexecutable + add some tests; make assorted refactorings #5103CODEOWNERSmatcher #5431