Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore and overhaul simple target path tests into RetrieveCodeOwnersProgramTests #5518

Merged
merged 4 commits into from
Feb 23, 2023

Conversation

konrad-jamrozik
Copy link
Contributor

@konrad-jamrozik konrad-jamrozik commented Feb 19, 2023

NOTE: this PR is stacked on #5431. I will retarget it onto main once #5431 is merged.

This PR is a follow-up to:

Here I recreate tests that exercise the "simple target path" (as opposed to "glob target path") logic of the RetrieveCodeOwners tool.

Related work:

@konrad-jamrozik konrad-jamrozik added the Central-EngSys This issue is owned by the Engineering System team. label Feb 19, 2023
@konrad-jamrozik konrad-jamrozik self-assigned this Feb 19, 2023
@konrad-jamrozik konrad-jamrozik requested a review from a team as a code owner February 19, 2023 03:42
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable

Base automatically changed from users/kojamroz/remove_prefix to main February 23, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants