Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NotificationConfiguration package to 20230214.1 to enable CODEOWNERS regex matcher to default to true #5452

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

konrad-jamrozik
Copy link
Contributor

@konrad-jamrozik konrad-jamrozik commented Feb 14, 2023

Update 2/16/2023: Follow-up PR:


As in subject; the following PR gets deployed with this change:

This PR was originally supposed to enable the new regex-based wildcard-supporting CODEOWNERS matcher everywhere, but the change turned out to be incomplete. The PR that actually will do it is:

Related work:

@konrad-jamrozik konrad-jamrozik added the Central-EngSys This issue is owned by the Engineering System team. label Feb 14, 2023
@konrad-jamrozik konrad-jamrozik self-assigned this Feb 14, 2023
@konrad-jamrozik konrad-jamrozik requested review from weshaggard, benbp and a team February 14, 2023 23:09
@konrad-jamrozik konrad-jamrozik marked this pull request as ready for review February 14, 2023 23:10
@konrad-jamrozik konrad-jamrozik changed the title Update NotificationConfiguration package to 1.0.0-dev.20230214.1 (enable CODEOWNERS regex matcher everywhere) Update NotificationConfiguration package to 20230214.1 to enable CODEOWNERS regex matcher everywhere Feb 14, 2023
@konrad-jamrozik
Copy link
Contributor Author

/check-enforcer override

@konrad-jamrozik konrad-jamrozik merged commit b915ffd into main Feb 16, 2023
@konrad-jamrozik konrad-jamrozik deleted the users/kojamroz/notif_package_bump_new_matcher branch February 16, 2023 21:34
@konrad-jamrozik konrad-jamrozik changed the title Update NotificationConfiguration package to 20230214.1 to enable CODEOWNERS regex matcher everywhere Update NotificationConfiguration package to 20230214.1 to enable CODEOWNERS regex matcher to default to true Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants